Fix wrong warnings about bad flags assigned to good qualities (#2583)

Due to the order of processing in WorstOfAllAggregator, we could get cases when a bad Flag (coming from Bad quality) would be assigned to Good quality, while the quality itself would be replaced just after.
This commit reverses the order, which will silence the wrong warning.

The same code was also reused TrendCheck, thus I am fixing it also there.

Author: knopers8

Framework/src/AggregatorRunner.cxx

@@ -174,7 +174,7 @@ AggregatorRunner::QualityObjectsWithAggregatorNameVector AggregatorRunner::aggre
     ILOG(Info, Devel) << "Processing aggregator: " << aggregatorName << ENDM;
 
     if (mUpdatePolicyManager.isReady(aggregatorName)) {
-      ILOG(Info, Devel) << "   Quality Objects for the aggregator '" << aggregatorName << "' are  ready, aggregating" << ENDM;
+      ILOG(Info, Devel) << "   Quality Objects for the aggregator '" << aggregatorName << "' are ready, aggregating" << ENDM;
       auto newQOs = aggregator->aggregate(mQualityObjects, *mActivity); // we give the whole list
       mTotalNumberObjectsProduced += newQOs.size();
       mTotalNumberAggregatorExecuted++;

Modules/Common/src/TrendCheck.cxx

@@ -345,12 +345,12 @@ Quality TrendCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>*
   Quality result = mQualities.empty() ? Quality::Null : Quality::Good;
   for (auto& [key, quality] : mQualities) {
     (void)key;
-    for (const auto& flag : quality.getFlags()) {
-      result.addFlag(flag.first, flag.second);
-    }
     if (quality.isWorseThan(result)) {
       result.set(quality);
     }
+    for (const auto& flag : quality.getFlags()) {
+      result.addFlag(flag.first, flag.second);
+    }
   }
 
   return result;

Modules/Common/src/WorstOfAllAggregator.cxx

@@ -41,12 +41,12 @@ std::map<std::string, Quality> WorstOfAllAggregator::aggregate(QualityObjectsMap
   Quality current = Quality::Good;
   for (const auto& [qoName, qo] : qoMap) {
     (void)qoName;
-    for (const auto& flag : qo->getFlags()) {
-      current.addFlag(flag.first, flag.second);
-    }
     if (qo->getQuality().isWorseThan(current)) {
       current.set(qo->getQuality());
     }
+    for (const auto& flag : qo->getFlags()) {
+      current.addFlag(flag.first, flag.second);
+    }
   }
   ILOG(Info, Devel) << "Aggregated Quality: " << current << ENDM;