ignore warnings variable in objectManager.cxx

Author: Michal Tichák

Framework/include/QualityControl/ObjectsManager.h

@@ -93,16 +93,15 @@ class ObjectsManager
                   "you are trying to startPublishing object that is not mergeable."
                   " If you know what you are doing use startPublishing<true>(...)");
 #endif
-    startPublishingImpl(obj, policy);
+    startPublishingImpl(obj, policy, IgnoreMergeable);
   }
 
   /**
    * Stop publishing this object
    * @param obj
    * @throw ObjectNotFoundError if object is not found.
    */
-  void
-    stopPublishing(TObject* obj);
+  void stopPublishing(TObject* obj);
 
   /**
    * Stop publishing this object
@@ -240,7 +239,7 @@ class ObjectsManager
   Activity mActivity;
   std::vector<std::string> mMovingWindowsList;
 
-  void startPublishingImpl(TObject* obj, PublicationPolicy);
+  void startPublishingImpl(TObject* obj, PublicationPolicy, bool ignoreMergeableWarning);
 };
 
 } // namespace o2::quality_control::core

Framework/src/ObjectsManager.cxx

@@ -60,19 +60,22 @@ ObjectsManager::~ObjectsManager()
   ILOG(Debug, Devel) << "ObjectsManager destructor" << ENDM;
 }
 
-void ObjectsManager::startPublishingImpl(TObject* object, PublicationPolicy publicationPolicy)
+void ObjectsManager::startPublishingImpl(TObject* object, PublicationPolicy publicationPolicy, bool ignoreMergeableWarning)
 {
   if (!object) {
     ILOG(Warning, Support) << "A nullptr provided to ObjectManager::startPublishing" << ENDM;
     return;
   }
+
   if (mMonitorObjects->FindObject(object->GetName()) != nullptr) {
     ILOG(Warning, Support) << "Object is already being published (" << object->GetName() << "), will remove it and add the new one" << ENDM;
     stopPublishing(object->GetName());
   }
-  if (mergers::isMergeable(object)) {
-    ILOG(Warning, Support) << "Object '" + std::string(object->GetName()) + "' with type '" + std::string(object->ClassName()) + "' is not one of the mergeable types, it might cause issues during publishing";
+
+  if (!ignoreMergeableWarning && !mergers::isMergeable(object)) {
+    ILOG(Warning, Support) << "Object '" + std::string(object->GetName()) + "' with type '" + std::string(object->ClassName()) + "' is not one of the mergeable types, it will not be correctly merged in distributed setups, such as P2 and Grid" << ENDM;
   }
+
   auto* newObject = new MonitorObject(object, mTaskName, mTaskClass, mDetectorName);
   newObject->setIsOwner(false);
   newObject->setActivity(mActivity);

Framework/src/SliceTrendingTask.cxx

@@ -258,7 +258,7 @@ void SliceTrendingTask::generatePlots()
     }
 
     mPlots[plot.name] = c;
-    getObjectsManager()->startPublishing<true>(c, PublicationPolicy::Once);
+    getObjectsManager()->startPublishing(c, PublicationPolicy::Once);
   }
 } // void SliceTrendingTask::generatePlots()
 

Framework/src/TrendingTask.cxx

@@ -268,7 +268,7 @@ void TrendingTask::generatePlots()
     }
     auto c = drawPlot(plotConfig);
     mPlots[plotConfig.name].reset(c);
-    getObjectsManager()->startPublishing<true>(c, PublicationPolicy::Once);
+    getObjectsManager()->startPublishing(c, PublicationPolicy::Once);
   }
 }