[MCH] added some missing parameter initializations in DecodingChecker (#2601)

The missing initializations are related to new parameters introduced
in #2592

Author: aferrero2707

Modules/MUON/MCH/include/MCH/DecodingCheck.h

@@ -52,21 +52,21 @@ class DecodingCheck : public o2::quality_control::checker::CheckInterface
   std::string mSyncFracHistName{ "SyncErrors/SyncedBoardsFractionPerDE" };
   std::string mSyncFracPerSolarHistName{ "SyncErrors/SyncedBoardsFractionPerSolar" };
   std::string mGoodFracRefCompHistName{ "DecodingErrors/RefComp/GoodBoardsFractionPerDE" };
-  std::string mGoodFracPerSolarRefCompHistName{ "DecodingErrors/RefComp/GoodBoardsFractionPerSolar" };
   std::string mSyncFracRefCompHistName{ "SyncErrors/RefComp/SyncedBoardsFractionPerDE" };
+  std::string mGoodFracPerSolarRefCompHistName{ "DecodingErrors/RefComp/GoodBoardsFractionPerSolar" };
   std::string mSyncFracPerSolarRefCompHistName{ "SyncErrors/RefComp/SyncedBoardsFractionPerSolar" };
   int mMaxBadST12{ 2 };
   int mMaxBadST345{ 3 };
   double mMinGoodErrorFrac{ 0.9 };
   std::array<std::optional<double>, 5> mMinGoodErrorFracPerStation;
-  double mMinGoodErrorFracPerSolar{ 0.5 };
   double mMinGoodErrorFracRatio{ 0.9 };
+  double mMinGoodErrorFracPerSolar{ 0.5 };
   double mMinGoodErrorFracRatioPerSolar{ 0.9 };
 
   double mMinGoodSyncFrac{ 0.9 };
   std::array<std::optional<double>, 5> mMinGoodSyncFracPerStation;
-  double mMinGoodSyncFracPerSolar{ 0.5 };
   double mMinGoodSyncFracRatio{ 0.9 };
+  double mMinGoodSyncFracPerSolar{ 0.5 };
   double mMinGoodSyncFracRatioPerSolar{ 0.9 };
 
   double mMinHeartBeatRate{ 0 };

Modules/MUON/MCH/src/DecodingCheck.cxx

@@ -48,19 +48,37 @@ void DecodingCheck::startOfActivity(const Activity& activity)
   mGoodFracPerSolarHistName = getConfigurationParameter<std::string>(mCustomParameters, "GoodFracPerSolarHistName", mGoodFracPerSolarHistName, activity);
   mSyncFracPerSolarHistName = getConfigurationParameter<std::string>(mCustomParameters, "SyncFracPerSolarHistName", mSyncFracPerSolarHistName, activity);
 
+  mGoodFracRefCompHistName = getConfigurationParameter<std::string>(mCustomParameters, "GoodFracRefCompHistName", mGoodFracRefCompHistName, activity);
+  mSyncFracRefCompHistName = getConfigurationParameter<std::string>(mCustomParameters, "SyncFracRefCompHistName", mSyncFracRefCompHistName, activity);
+
+  mGoodFracPerSolarRefCompHistName = getConfigurationParameter<std::string>(mCustomParameters, "GoodFracPerSolarRefCompHistName", mGoodFracPerSolarRefCompHistName, activity);
+  mSyncFracPerSolarRefCompHistName = getConfigurationParameter<std::string>(mCustomParameters, "SyncFracPerSolarRefCompHistName", mSyncFracPerSolarRefCompHistName, activity);
+
   getThresholdsPerStation(mCustomParameters, activity, "MinGoodErrorFrac", mMinGoodErrorFracPerStation, mMinGoodErrorFrac);
-  getThresholdsPerStation(mCustomParameters, activity, "MinGoodSyncFrac", mMinGoodSyncFracPerStation, mMinGoodSyncFrac);
+  mMinGoodErrorFracRatio = getConfigurationParameter<double>(mCustomParameters, "MinGoodErrorFracRatio", mMinGoodErrorFracRatio, activity);
 
   mMinGoodErrorFracPerSolar = getConfigurationParameter<double>(mCustomParameters, "MinGoodErrorFracPerSolar", mMinGoodErrorFracPerSolar, activity);
+  mMinGoodErrorFracRatioPerSolar = getConfigurationParameter<double>(mCustomParameters, "MinGoodErrorFracRatioPerSolar", mMinGoodErrorFracRatioPerSolar, activity);
+
+  getThresholdsPerStation(mCustomParameters, activity, "MinGoodSyncFrac", mMinGoodSyncFracPerStation, mMinGoodSyncFrac);
+  mMinGoodSyncFracRatio = getConfigurationParameter<double>(mCustomParameters, "MinGoodSyncFracRatio", mMinGoodSyncFracRatio, activity);
+
   mMinGoodSyncFracPerSolar = getConfigurationParameter<double>(mCustomParameters, "MinGoodSyncFracPerSolar", mMinGoodSyncFracPerSolar, activity);
+  mMinGoodSyncFracRatioPerSolar = getConfigurationParameter<double>(mCustomParameters, "MinGoodSyncFracRatioPerSolar", mMinGoodSyncFracRatioPerSolar, activity);
+
+  mMinHeartBeatRate = getConfigurationParameter<double>(mCustomParameters, "MinHeartBeatRate", mMinHeartBeatRate, activity);
+  mMaxHeartBeatRate = getConfigurationParameter<double>(mCustomParameters, "MaxHeartBeatRate", mMaxHeartBeatRate, activity);
+
+  mGoodFracRatioPlotRange = getConfigurationParameter<double>(mCustomParameters, "GoodFracRatioPlotRange", mGoodFracRatioPlotRange, activity);
+  mGoodFracRatioPerSolarPlotRange = getConfigurationParameter<double>(mCustomParameters, "GoodFracRatioPerSolarPlotRange", mGoodFracRatioPerSolarPlotRange, activity);
+
+  mSyncFracRatioPlotRange = getConfigurationParameter<double>(mCustomParameters, "SyncFracRatioPlotRange", mSyncFracRatioPlotRange, activity);
+  mSyncFracRatioPerSolarPlotRange = getConfigurationParameter<double>(mCustomParameters, "SyncFracRatioPerSolarPlotRange", mSyncFracRatioPerSolarPlotRange, activity);
 
   mMaxBadST12 = getConfigurationParameter<int>(mCustomParameters, "MaxBadDE_ST12", mMaxBadST12, activity);
   mMaxBadST345 = getConfigurationParameter<int>(mCustomParameters, "MaxBadDE_ST345", mMaxBadST345, activity);
   mQualityChecker.mMaxBadST12 = mMaxBadST12;
   mQualityChecker.mMaxBadST345 = mMaxBadST345;
-
-  mMinHeartBeatRate = getConfigurationParameter<double>(mCustomParameters, "MinHeartBeatRate", mMinHeartBeatRate, activity);
-  mMaxHeartBeatRate = getConfigurationParameter<double>(mCustomParameters, "MaxHeartBeatRate", mMaxHeartBeatRate, activity);
 }
 
 Quality DecodingCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap)