adopt QcInputs in LateTaskInterface::process

Author: knopers8

Framework/include/QualityControl/LateTaskInterface.h

@@ -27,6 +27,8 @@
 #include "QualityControl/UserCodeInterface.h"
 #include "QualityControl/MonitorObject.h"
 #include "QualityControl/QualityObject.h"
+#include "QualityControl/QCInputs.h"
+
 
 namespace o2::monitoring
 {
@@ -96,7 +98,7 @@ class LateTaskInterface : public UserCodeInterface
   //   optionally, it could also hide DPL's InputRecord or decorate it with a method which allows to access sampled
   //   and unsampled data in a unified way.
   // virtual void process(std::map<std::string, std::shared_ptr<const core::MonitorObject>>& moMap, std::map<std::string, std::shared_ptr<const core::QualityObject>>& qoMap) = 0;
-  virtual void process(o2::framework::ProcessingContext& ctx) = 0;
+  virtual void process(const core::QCInputs& data) = 0;
   virtual void endOfActivity(const Activity& activity) = 0;
   virtual void reset() = 0;
 

Framework/src/LateTaskRunner.cxx

@@ -87,10 +87,47 @@ void LateTaskRunner::init(InitContext& iCtx)
 
 void LateTaskRunner::run(ProcessingContext& pCtx)
 {
+  // todo: derive from received objects
   mValidity.update(getCurrentTimestamp());
 
+  QCInputs taskInputs;
+  for (const auto& ref : InputRecordWalker(pCtx.inputs())) {
+    // InputRecordWalker because the output of CheckRunner can be multi-part
+    const auto* inputSpec = ref.spec;
+    if (inputSpec == nullptr) {
+      continue;
+    }
+    const auto dataOrigin = DataSpecUtils::asConcreteOrigin(*inputSpec);
+
+    // fixme: come up with an elegant way for this. LateTask should be probably aware of the requested user inputs aside from just InputSpecs
+    //  also, we should filter only expect objects from the received collections
+    if (dataOrigin.str[0] == 'Q' || dataOrigin.str[0] == 'W') { // main MOs and moving windows from QC tasks
+      auto moc = DataRefUtils::as<MonitorObjectCollection>(ref);
+      moc->postDeserialization();
+
+      for (const auto& obj : *moc) {
+        auto mo = dynamic_cast<MonitorObject*>(obj);
+        if (mo != nullptr) {
+          taskInputs.insert(mo->getName(), std::shared_ptr<MonitorObject>(mo));
+        }
+      }
+
+      moc->SetOwner(false);
+    } else if (dataOrigin.str[0] == 'C' || dataOrigin.str[0] == 'A') { // QOs from Checks and Aggregators
+      // QO
+      auto qo = DataRefUtils::as<QualityObject>(ref);
+      auto key = qo->getName();
+      taskInputs.insert(key, std::shared_ptr<QualityObject>(std::move(qo)));
+
+    } else {
+      BOOST_THROW_EXCEPTION(FatalException() << errinfo_details("LateTaskRunner currently supports only MonitorObject and Quality inputs"));
+    }
+  }
+
+
+
   // run the task
-  mTask->process(pCtx);
+  mTask->process(taskInputs);
 
   // publish objects
   mObjectsManager->setValidity(mValidity);

Modules/Skeleton/include/Skeleton/SkeletonLateTask.h

@@ -24,10 +24,10 @@ class SkeletonLateTask final : public LateTaskInterface
   ~SkeletonLateTask() override;
 
   // Definition of the methods for the template method pattern
-  void initialize(o2::framework::InitContext& ctx) override;
-  void startOfActivity(const Activity& activity) override;
-  void process(o2::framework::ProcessingContext& ctx) override;
-  void endOfActivity(const Activity& activity) override;
+  void initialize(o2::framework::InitContext&) override;
+  void startOfActivity(const Activity&) override;
+  void process(const quality_control::core::QCInputs&) override;
+  void endOfActivity(const Activity&) override;
   void reset() override;
 
   private:

Modules/Skeleton/src/SkeletonLateTask.cxx

@@ -19,6 +19,8 @@
 #include <TH1.h>
 
 #include "QualityControl/QcInfoLogger.h"
+#include "QualityControl/QCInputs.h"
+#include "QualityControl/QCInputsAdapters.h"
 #include "Skeleton/SkeletonLateTask.h"
 #include <Framework/InputRecordWalker.h>
 #include <Framework/DataRefUtils.h>
@@ -54,50 +56,19 @@ void SkeletonLateTask::startOfActivity(const Activity& activity)
   // mGraph->Clear();
 }
 
-void SkeletonLateTask::process(o2::framework::ProcessingContext& ctx)
+void SkeletonLateTask::process(const quality_control::core::QCInputs& data)
 {
   // THIS FUNCTION BODY IS AN EXAMPLE. PLEASE REMOVE EVERYTHING YOU DO NOT NEED.
 
-  if (ctx.inputs().isValid("QcTask")) {
-    auto qcTaskMOs = ctx.inputs().get<MonitorObjectCollection*>("QcTask");
-    if (qcTaskMOs == nullptr) {
-      ILOG(Error, Ops) << "empty ptr" << ENDM;
-      return;
-    }
-
-    ILOG(Info, Ops) << "MOC has " << qcTaskMOs->GetEntries() << " entries" << ENDM;
-    for (auto const& obj : *qcTaskMOs) {
-
-      if (obj == nullptr) {
-        ILOG(Error, Ops) << "Found a null MonitorObject in the collection" << ENDM;
-        continue;
-      }
-
-      auto mo = dynamic_cast<o2::quality_control::core::MonitorObject*>(obj);
-      if (mo == nullptr) {
-        ILOG(Error, Ops) << "Could not cast TObject into MonitorObject" << ENDM;
-        continue;
-      }
-
-      if (mo->getName() == "example") {
-        ILOG(Info, Ops) << "Got the 'example' object" << ENDM;
-      } else {
-        continue;
-      }
-
-      auto histo = dynamic_cast<TH1*>(mo->getObject());
-      if (histo == nullptr) {
-        ILOG(Error, Ops) << "Could not cast MonitorObject to TH1" << ENDM;
-        continue;
-      }
-
-      ILOG(Info, Ops) << "Histogram " << histo->GetName() << " has " << histo->GetEntries() << " entries" << ENDM;
-
-      mGraph->AddPoint(histo->GetEntries(), histo->GetMean());
-    }
+  if (auto histoOpt = getMonitorObject<TH1>(data, "example")) {
+    const TH1& histo = histoOpt.value();
+
+    ILOG(Info, Ops) << "Histogram " << histo.GetName() << " has " << histo.GetEntries() << " entries" << ENDM;
+    mGraph->AddPoint(histo.GetEntries(), histo.GetMean());
   }
-  if (ctx.inputs().isValid("QcCheck")) {
-    ILOG(Info, Ops) << "got QcCheck results" << ENDM;
+
+  if (auto qoOpt = getQualityObject(data, "QcCheck")) {
+    ILOG(Info, Ops) << "Got QcCheck result: " << qoOpt.value().get().getQuality() << ENDM;
   }
 }