Skip to content

Commit ff4bac3

Browse files
authored
removed magic numbers
1 parent 6335c82 commit ff4bac3

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

PWGLF/Tasks/Resonances/lambda1520analysisinpp.cxx

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ struct Lambda1520analysisinpp {
108108
Configurable<float> cMinPtcut{"cMinPtcut", 0.15f, "Minimal pT for tracks"};
109109
Configurable<float> cMinTPCNClsFound{"cMinTPCNClsFound", 120, "minimum TPCNClsFound value for good track"};
110110
Configurable<float> cfgCutEta{"cfgCutEta", 0.8, "Eta range for tracks"};
111+
Configurable<float> cfgCutRapidity{"cfgCutRapidity", 0.5, "rapidity range for particles"};
111112
Configurable<int> cfgMinCrossedRows{"cfgMinCrossedRows", 70, "min crossed rows for good track"};
112113

113114
// DCA Selections
@@ -652,15 +653,21 @@ struct Lambda1520analysisinpp {
652653
return false;
653654
}
654655

656+
auto static constexpr MinPtforPionRejection = 1.f;
657+
auto static constexpr MaxPtforPionRejection = 2.f;
658+
auto static constexpr MaxnSigmaforPionRejection = 2.f;
659+
655660
template <typename T>
656661
bool rejectPion(const T& candidate)
657662
{
658-
if (candidate.pt() > static_cast<float>(1.0) && candidate.pt() < static_cast<float>(2.0) && !candidate.hasTOF() && candidate.tpcNSigmaPi() < static_cast<float>(2)) {
663+
if (candidate.pt() > MinPtforPionRejection && candidate.pt() < MaxPtforPionRejection && !candidate.hasTOF() && candidate.tpcNSigmaPi() < MaxnSigmaforPionRejection) {
659664
return false;
660665
}
661666
return true;
662667
}
663668

669+
auto static constexpr MaxNoLambda1520Daughters = 2;
670+
664671
template <bool IsData, bool IsRot, bool IsMC, bool IsMix, typename CollisionType, typename TracksType>
665672
void fillHistograms(const CollisionType& collision, const TracksType& dTracks1, const TracksType& dTracks2)
666673
{
@@ -828,7 +835,7 @@ struct Lambda1520analysisinpp {
828835

829836
if constexpr (IsData || IsMix) {
830837
// Rapidity cut
831-
if (std::abs(resonanceRapidity) > static_cast<float>(0.5))
838+
if (std::abs(resonanceRapidity) > configTracks.cfgCutRapidity)
832839
continue;
833840
}
834841

@@ -863,7 +870,7 @@ struct Lambda1520analysisinpp {
863870
auto resonanceRotPt = lResonanceRot.Pt();
864871

865872
// Rapidity cut
866-
if (std::abs(lResonanceRot.Rapidity()) >= static_cast<float>(0.5))
873+
if (std::abs(lResonanceRot.Rapidity()) >= configTracks.cfgCutRapidity)
867874
continue;
868875

869876
if (cfgUseCutsOnMother) {
@@ -945,7 +952,7 @@ struct Lambda1520analysisinpp {
945952
motherstrk1 = getMothersIndeces(mctrk1);
946953
mothersPDGtrk1 = getMothersPDGCodes(mctrk1);
947954
}
948-
while (motherstrk1.size() > static_cast<int>(2)) {
955+
while (motherstrk1.size() > MaxNoLambda1520Daughters) {
949956
motherstrk1.pop_back();
950957
mothersPDGtrk1.pop_back();
951958
}
@@ -955,7 +962,7 @@ struct Lambda1520analysisinpp {
955962
motherstrk2 = getMothersIndeces(mctrk2);
956963
mothersPDGtrk2 = getMothersPDGCodes(mctrk2);
957964
}
958-
while (motherstrk2.size() > static_cast<int>(2)) {
965+
while (motherstrk2.size() > MaxNoLambda1520Daughters) {
959966
motherstrk2.pop_back();
960967
mothersPDGtrk2.pop_back();
961968
}
@@ -974,7 +981,7 @@ struct Lambda1520analysisinpp {
974981
if (cUseEtacutMC && std::abs(lResonance.Eta()) > cEtacutMC) // eta cut
975982
continue;
976983

977-
if (cUseRapcutMC && std::abs(resonanceRapidity) > static_cast<float>(0.5)) // rapidity cut
984+
if (cUseRapcutMC && std::abs(resonanceRapidity) > configTracks.cfgCutRapidity) // rapidity cut
978985
continue;
979986

980987
histos.fill(HIST("QA/MC/h2RecoEtaPt_after"), lResonance.Eta(), resonancePt);
@@ -1075,7 +1082,7 @@ struct Lambda1520analysisinpp {
10751082
void processMCTrue(MCEventCandidates::iterator const& collision, aod::McCollisions const&, aod::McParticles const& mcParticles)
10761083
{
10771084
bool isInAfterAllCuts = colCuts.isSelected(collision);
1078-
bool inVtx10 = (std::abs(collision.mcCollision().posZ()) > static_cast<float>(10.0)) ? false : true;
1085+
bool inVtx10 = (std::abs(collision.mcCollision().posZ()) > configEvents.cfgEvtZvtx) ? false : true;
10791086
bool isTriggerTVX = collision.selection_bit(aod::evsel::kIsTriggerTVX);
10801087
bool isSel8 = collision.sel8();
10811088
bool isTrueINELgt0 = isTrueINEL0(collision, mcParticles);
@@ -1110,7 +1117,7 @@ struct Lambda1520analysisinpp {
11101117
histos.fill(HIST("QA/MC/h2GenEtaPt_beforeanycut"), part.eta(), part.pt());
11111118
histos.fill(HIST("QA/MC/h2GenPhiRapidity_beforeanycut"), part.phi(), part.y());
11121119

1113-
if (cUseRapcutMC && std::abs(part.y()) > static_cast<float>(0.5)) // rapidity cut
1120+
if (cUseRapcutMC && std::abs(part.y()) > configTracks.cfgCutRapidity) // rapidity cut
11141121
continue;
11151122

11161123
if (cfgUseDaughterEtaCutMC) {

0 commit comments

Comments
 (0)