[PWGCF] Fix compilation warnings (#8381)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>

Author: 3 people

PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx

@@ -14,6 +14,9 @@
 
 #include <iostream>
 #include <string>
+#include <memory>
+#include <vector>
+#include <map>
 
 #include "TF1.h"
 #include "TGraphErrors.h"
@@ -82,7 +85,7 @@ struct RobustFluctuationObservables {
   // for vertex vs time:
   bool flagShowInfo = false;
   int lastRunNumber = -1;
-  int nBCsPerOrbit = 3564;
+  uint64_t nBCsPerOrbit = 3564;
 
   // bc position correlations
   int64_t prevOrbit = -1;
@@ -101,7 +104,7 @@ struct RobustFluctuationObservables {
   int64_t orbitSOR = -1;
   // int64_t bcSORbis = -1; // global bc of the start of the first orbit - try alternative
   int64_t nBCsPerTF = 1; // 128*3564; // duration of TF in bcs
-  int64_t TFid = -1;     // count time frames in a given run
+  uint64_t TFid = 0;     // count time frames in a given run
   bool flagWaitForNewTF = false;
   uint32_t nOrbitsPerTF = 0;
 
@@ -154,7 +157,7 @@ struct RobustFluctuationObservables {
   // hand-made ITS ROF cut
   Configurable<int> nITSROF{"nITSROF", 6, "nITSROF"};
   Configurable<int> nITSROF_BC_offset{"nITSROF_BC_offset", 65, "nITSROF_BC_offset"};
-  Configurable<int> nITSROF_BC_cutWidth{"nITSROF_BC_cutWidth", 40, "nITSROF_BC_cutWidth"};
+  Configurable<uint64_t> nITSROF_BC_cutWidth{"nITSROF_BC_cutWidth", 40, "nITSROF_BC_cutWidth"};
   // Configurable<int> nITSROF_middle_cut_forITSonlyVert{"nITSROF_middle_cut_forITSonlyVert", 198/2 /*ROF=198 in pp*/, "nITSROF_middle_cut_forITSonlyVert"};
   // Configurable<int> nNoITSonlyVertices{"nNoITSonlyVertices", false, "nITSROF_middle_cut_forITSonlyVert"};
 
@@ -163,7 +166,7 @@ struct RobustFluctuationObservables {
   Configurable<float> cutVzTrackT0diffUpper{"cutVzTrackT0diffUpper", 1., "cutVzTrackT0diffUpper, cm"};
 
   // splitting of the orbit into several BC ranges
-  Configurable<std::vector<int>> vSplitBCpointsOfTheOrbit{"SplitBCpointsOfTheOrbit", {1200, 2000, 3000}, "BC split points of the orbit"};
+  Configurable<std::vector<uint64_t>> vSplitBCpointsOfTheOrbit{"SplitBCpointsOfTheOrbit", {1200, 2000, 3000}, "BC split points of the orbit"};
 
   // orbit QA
   uint32_t orbitAtCollIndexZero = 0;
@@ -968,7 +971,7 @@ struct RobustFluctuationObservables {
     }
 
     if (myDF_ID >= 0 && myDF_ID < nHistQAplotsDF) {
-      int diffOrbits = (int32_t)orbit - (int32_t)orbitAtCollIndexZero;
+      int diffOrbits = static_cast<int32_t>(orbit) - static_cast<int32_t>(orbitAtCollIndexZero);
       TString strDF = Form("DF_%d", static_cast<int>(DF_ID_raw));
       fV_h1D_Orbit_vs_CollIndex[myDF_ID]->Fill(collision.index(), diffOrbits);
       fV_h1D_Orbit_vs_CollIndex[myDF_ID]->SetTitle(strDF);
@@ -1474,23 +1477,23 @@ struct RobustFluctuationObservables {
     // ##### check how often we analyze collision in the same BC (and also the vZ difference)
     if (collision.selection_bit(o2::aod::evsel::kNoTimeFrameBorder)) {
       if (prevBC != 9999) {
-        int32_t diff = (int32_t)collBC - (int32_t)prevBC;
+        int32_t diff = static_cast<int32_t>(collBC) - static_cast<int32_t>(prevBC);
         histosEvent.fill(HIST("hBC_DIFF_to_previous"), diff);
         if (diff == 0)
           histosEvent.fill(HIST("hBC_DIFF_to_previous_vZvZ_2D"), vZ, prev_vZ);
       }
       if (prevBcInTF >= 0) {
-        int32_t diffBcInTF = (int32_t)bcInTF - (int32_t)prevBcInTF;
+        int32_t diffBcInTF = static_cast<int32_t>(bcInTF) - static_cast<int32_t>(prevBcInTF);
         histosEvent.fill(HIST("hBCinTF_DIFF_to_previous"), diffBcInTF);
       }
       if (prevFoundBcInTF >= 0) {
-        int32_t diffGlobalBcInTF = (int32_t)foundBcInTF - (int32_t)prevFoundBcInTF;
+        int32_t diffGlobalBcInTF = static_cast<int32_t>(foundBcInTF) - static_cast<int32_t>(prevFoundBcInTF);
         histosEvent.fill(HIST("hBCinTF_DIFF_to_previous_FOUND_BC"), diffGlobalBcInTF);
       }
 
       // global found BC:
       if (prevGlobalFoundBC != 9999) {
-        int32_t diff = (int32_t)globalFoundBC - (int32_t)prevGlobalFoundBC;
+        int32_t diff = static_cast<int32_t>(globalFoundBC) - static_cast<int32_t>(prevGlobalFoundBC);
         histosEvent.fill(HIST("hBC_DIFF_to_previous_FOUND_BC"), diff);
 
         if (counterPVcontributorsAfterTPCcuts > 0) {
@@ -1620,8 +1623,8 @@ struct RobustFluctuationObservables {
 
       histosEventBcInTF.fill(HIST("hGlobalTracks_vs_bcInTF"), bcInTF, nTracksGlobalAccepted);
     }
-    histosEvent.fill(HIST("hOrbitStartFromCollIndexZeroAft"), (int32_t)orbit - (int32_t)orbitAtCollIndexZero);
-    histosEvent.fill(HIST("h2D_Orbit_vs_CollIndex_Aft"), collision.index(), (int32_t)orbit - (int32_t)orbitAtCollIndexZero);
+    histosEvent.fill(HIST("hOrbitStartFromCollIndexZeroAft"), static_cast<int32_t>(orbit) - static_cast<int32_t>(orbitAtCollIndexZero));
+    histosEvent.fill(HIST("h2D_Orbit_vs_CollIndex_Aft"), collision.index(), static_cast<int32_t>(orbit) - static_cast<int32_t>(orbitAtCollIndexZero));
 
     histosEvent.fill(HIST("hMF"), magneticField);
     int MFsign = magneticField > 0 ? +1 : -1;
@@ -1680,11 +1683,11 @@ struct RobustFluctuationObservables {
     histosEvent.fill(HIST("hBCFound_Aft"), globalFoundBC);
     histosEvent.fill(HIST("h2D_numContrib_vs_BC"), collBC, collision.numContrib());
 
-    int64_t diffFoundBC_vs_BC = (int64_t)globalFoundBC - (int64_t)collBC;
+    int64_t diffFoundBC_vs_BC = static_cast<int64_t>(globalFoundBC) - static_cast<int64_t>(collBC);
     histosEvent.fill(HIST("h2D_diffFoundBC_vs_BC"), collBC, diffFoundBC_vs_BC);
 
     if (collision.has_foundBC())
-      histosEvent.fill(HIST("h2D_diffFoundBC_vs_BC_inTF"), collBC, (int64_t)foundBcInTF - (int64_t)bcInTF);
+      histosEvent.fill(HIST("h2D_diffFoundBC_vs_BC_inTF"), collBC, static_cast<int64_t>(foundBcInTF) - static_cast<int64_t>(bcInTF));
 
     // with FT0 conditions
     if (isFT0) {

PWGCF/FemtoUniverse/Core/FemtoUniverseMath.h

@@ -76,7 +76,6 @@ class FemtoUniverseMath
     const ROOT::Math::PtEtaPhiMVector vecpart1(part1.pt(), part1.eta(), part1.phi(), mass1);
     const ROOT::Math::PtEtaPhiMVector vecpart2(part2.pt(), part2.eta(), part2.phi(), mass2);
     const ROOT::Math::PtEtaPhiMVector trackSum = vecpart1 + vecpart2;
-    const ROOT::Math::PtEtaPhiMVector trackDiff = vecpart1 - vecpart2;
 
     const float beta = trackSum.Beta();
     const float betax = beta * std::cos(trackSum.Phi()) * std::sin(trackSum.Theta());

PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerTask.cxx

@@ -1445,7 +1445,7 @@ struct femtoUniverseProducerTask {
         std::vector<int> tmpPDGCodes = ConfMCTruthPDGCodes; // necessary due to some features of the Configurable
         for (uint32_t pdg : tmpPDGCodes) {
           if (static_cast<int>(pdg) == static_cast<int>(pdgCode)) {
-            if ((pdgCode == 333)) { // && (recoMcIds && recoMcIds->get().contains(particle.globalIndex()))) { // ATTENTION: all Phi mesons are NOT primary particles
+            if (pdgCode == 333) { // && (recoMcIds && recoMcIds->get().contains(particle.globalIndex()))) { // ATTENTION: all Phi mesons are NOT primary particles
               pass = true;
             } else {
               if (particle.isPhysicalPrimary() || (ConfActivateSecondaries && recoMcIds && recoMcIds->get().contains(particle.globalIndex())))
@@ -1497,11 +1497,11 @@ struct femtoUniverseProducerTask {
     if constexpr (resolveDaughs) {
       childIDs[0] = 0;
       childIDs[1] = 0;
-      for (int i = 0; i < tmpIDtrack.size(); i++) {
+      for (std::size_t i = 0; i < tmpIDtrack.size(); i++) {
         const auto& particle = tracks.iteratorAt(tmpIDtrack[i] - tracks.begin().globalIndex());
         for (int daughIndex = 0, n = std::min(2ul, particle.daughtersIds().size()); daughIndex < n; daughIndex++) {
           // loop to find the corresponding index of the daughters
-          for (int j = 0; j < tmpIDtrack.size(); j++) {
+          for (std::size_t j = 0; j < tmpIDtrack.size(); j++) {
             if (tmpIDtrack[j] == particle.daughtersIds()[daughIndex]) {
               childIDs[daughIndex] = i - j;
               break;

PWGCF/FemtoUniverse/Tasks/femtoUniverseEfficiencyBase.cxx

@@ -283,15 +283,15 @@ struct femtoUniverseEfficiencyBase {
   {
     /// Histogramming same event
     for (auto& part : grouppartsOneMCGen) {
-      if (!ConfNoPDGPartOne && part.pidcut() != ConfPDGCodePartOne) {
+      if (!ConfNoPDGPartOne && part.tempFitVar() != ConfPDGCodePartOne) {
         continue;
       }
       trackHistoPartOneGen.fillQA<isMC, false>(part);
     }
 
     if (!ConfIsSame) {
       for (auto& part : grouppartsTwoMCGen) {
-        if (!ConfNoPDGPartTwo && part.pidcut() != ConfPDGCodePartTwo) {
+        if (!ConfNoPDGPartTwo && part.tempFitVar() != ConfPDGCodePartTwo) {
           continue;
         }
         trackHistoPartTwoGen.fillQA<isMC, false>(part);

PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx

@@ -263,7 +263,7 @@ struct femtoUniversePairTaskTrackCascadeExtended {
 
   void processSameEvent(FilteredFDCollision& col, FemtoFullParticles& parts)
   {
-    const auto& magFieldTesla = col.magField();
+    // const auto& magFieldTesla = col.magField();
 
     auto groupPartsOne = partsOne->sliceByCached(aod::femtouniverseparticle::fdCollisionId, col.globalIndex(), cache);
     auto groupPartsTwo = partsTwo->sliceByCached(aod::femtouniverseparticle::fdCollisionId, col.globalIndex(), cache);
@@ -307,9 +307,9 @@ struct femtoUniversePairTaskTrackCascadeExtended {
         continue;
       if (!IsParticleCombined(p1, ConfTrackChoicePartOne))
         continue;
-      const auto& posChild = parts.iteratorAt(p2.index() - 3);
-      const auto& negChild = parts.iteratorAt(p2.index() - 2);
-      const auto& bachelor = parts.iteratorAt(p2.index() - 1);
+      // const auto& posChild = parts.iteratorAt(p2.index() - 3);
+      // const auto& negChild = parts.iteratorAt(p2.index() - 2);
+      // const auto& bachelor = parts.iteratorAt(p2.index() - 1);
 
       /// Child particles must pass this condition to be selected
       /*if (!IsParticleTPC(posChild, CascChildTable[ConfCascType1][0]) || !IsParticleTPC(negChild, CascChildTable[ConfCascType1][1]) || !IsParticleTPC(bachelor, CascChildTable[ConfCascType1][2]))
@@ -320,7 +320,7 @@ struct femtoUniversePairTaskTrackCascadeExtended {
   }
   PROCESS_SWITCH(femtoUniversePairTaskTrackCascadeExtended, processSameEvent, "Enable processing same event for track - cascade", true);
 
-  void processMixedEvent(FilteredFDCollisions& cols, FemtoFullParticles& parts)
+  void processMixedEvent(FilteredFDCollisions& cols, FemtoFullParticles& /*parts*/)
   {
     ColumnBinningPolicy<aod::collision::PosZ, aod::femtouniversecollision::MultNtr> colBinning{{ConfVtxBins, ConfMultBins}, true};
 
@@ -341,9 +341,9 @@ struct femtoUniversePairTaskTrackCascadeExtended {
         if (!IsParticleCombined(p1, ConfTrackChoicePartOne))
           continue;
 
-        const auto& posChild = parts.iteratorAt(p2.index() - 3);
-        const auto& negChild = parts.iteratorAt(p2.index() - 2);
-        const auto& bachelor = parts.iteratorAt(p2.index() - 1);
+        // const auto& posChild = parts.iteratorAt(p2.index() - 3);
+        // const auto& negChild = parts.iteratorAt(p2.index() - 2);
+        // const auto& bachelor = parts.iteratorAt(p2.index() - 1);
 
         /// Child particles must pass this condition to be selected
         /*if (!IsParticleTPC(posChild, CascChildTable[ConfCascType1][0]) || !IsParticleTPC(negChild, CascChildTable[ConfCascType1][1]) || !IsParticleTPC(bachelor, CascChildTable[ConfCascType1][2]))

PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx

@@ -17,6 +17,7 @@
 /// \author Zuzanna Chochulska, WUT Warsaw & CTU Prague, zchochul@cern.ch
 
 #include <vector>
+#include <string>
 #include "Framework/AnalysisTask.h"
 #include "Framework/runDataProcessing.h"
 #include "Framework/HistogramRegistry.h"
@@ -72,8 +73,8 @@ struct femtoUniversePairTaskTrackPhi {
   struct : o2::framework::ConfigurableGroup {
     Configurable<std::string> ConfEfficiencyTrackPath{"ConfEfficiencyTrackPath", "", "Local path to proton efficiency TH2F file"};
     Configurable<std::string> ConfEfficiencyPhiPath{"ConfEfficiencyPhiPath", "", "Local path to Phi efficiency TH2F file"};
-    Configurable<long> ConfEfficiencyTrackTimestamp{"ConfEfficiencyTrackTimestamp", 0, "(long int) Timestamp for hadron"};
-    Configurable<long> ConfEfficiencyPhiTimestamp{"ConfEfficiencyPhiTimestamp", 0, "(long int) Timestamp for phi"};
+    Configurable<int64_t> ConfEfficiencyTrackTimestamp{"ConfEfficiencyTrackTimestamp", 0, "(int64_t) Timestamp for hadron"};
+    Configurable<int64_t> ConfEfficiencyPhiTimestamp{"ConfEfficiencyPhiTimestamp", 0, "(int64_t) Timestamp for phi"};
   } ConfEff;
 
   struct : o2::framework::ConfigurableGroup {
@@ -438,7 +439,7 @@ struct femtoUniversePairTaskTrackPhi {
     ccdb->setCaching(true);
     ccdb->setLocalObjectValidityChecking();
 
-    long now = std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count();
+    int64_t now = std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count();
     ccdb->setCreatedNotAfter(now);
 
     if (!ConfEff.ConfEfficiencyTrackPath.value.empty()) {
@@ -584,10 +585,11 @@ struct femtoUniversePairTaskTrackPhi {
     float mMassTwo = TDatabasePDG::Instance()->GetParticle(-321)->Mass(); // FIXME: Get from the PDG service of the common header
 
     for (auto& [kaon1, kaon2] : combinations(CombinationsStrictlyUpperIndexPolicy(groupPartsKaons, groupPartsKaons))) {
-      if (!IsKaonNSigma(kaon1.p(), trackCuts.getNsigmaTPC(kaon1, o2::track::PID::Kaon), trackCuts.getNsigmaTOF(kaon1, o2::track::PID::Kaon))) {
-      }
-      if (!IsKaonNSigma(kaon2.p(), trackCuts.getNsigmaTPC(kaon2, o2::track::PID::Kaon), trackCuts.getNsigmaTOF(kaon2, o2::track::PID::Kaon))) {
-      }
+      // empty if statements commented out on 20241114 to get rid of MegaLinter errors
+      // if (!IsKaonNSigma(kaon1.p(), trackCuts.getNsigmaTPC(kaon1, o2::track::PID::Kaon), trackCuts.getNsigmaTOF(kaon1, o2::track::PID::Kaon))) {
+      // }
+      // if (!IsKaonNSigma(kaon2.p(), trackCuts.getNsigmaTPC(kaon2, o2::track::PID::Kaon), trackCuts.getNsigmaTOF(kaon2, o2::track::PID::Kaon))) {
+      // }
       if ((kaon1.mAntiLambda() == 1) && (kaon2.mAntiLambda() == 1)) {
         part1Vec.SetPtEtaPhiM(kaon1.pt(), kaon1.eta(), kaon1.phi(), mMassOne);
         part2Vec.SetPtEtaPhiM(kaon2.pt(), kaon2.eta(), kaon2.phi(), mMassOne);
@@ -765,7 +767,7 @@ struct femtoUniversePairTaskTrackPhi {
         registryMCtruth.fill(HIST("MCtruthKp"), part.pt(), part.eta());
         registryMCtruth.fill(HIST("MCtruthKpPt"), part.pt());
       }
-      if ((pdgCode == 333)) {
+      if (pdgCode == 333) {
         registryMCtruth.fill(HIST("MCtruthPhi"), part.pt(), part.eta());
         continue;
       }

PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx

@@ -517,7 +517,7 @@ struct femtoUniversePairTaskTrackV0Extended {
   PROCESS_SWITCH(femtoUniversePairTaskTrackV0Extended, processMCSameEvent, "Enable processing same event for MC truth track - V0", false);
 
   /// This function processes MC same events for V0 - V0
-  void processMCSameEventV0(FilteredFDCollision& col, FemtoFullParticles& parts)
+  void processMCSameEventV0(FilteredFDCollision& col, FemtoFullParticles& /*parts*/)
   {
     auto groupPartsTwo = partsTwoMC->sliceByCached(aod::femtouniverseparticle::fdCollisionId, col.globalIndex(), cache);
     const int multCol = ConfUseCent ? col.multV0M() : col.multNtr();
@@ -753,7 +753,7 @@ struct femtoUniversePairTaskTrackV0Extended {
   PROCESS_SWITCH(femtoUniversePairTaskTrackV0Extended, processMCMixedEvent, "Enable processing mixed events for MC truth track - V0", false);
 
   /// This function processes MC mixed events for V0 - V0
-  void processMCMixedEventV0(FilteredFDCollisions& cols, FemtoFullParticles& parts)
+  void processMCMixedEventV0(FilteredFDCollisions& cols, FemtoFullParticles& /*parts*/)
   {
     ColumnBinningPolicy<aod::collision::PosZ, aod::femtouniversecollision::MultNtr> colBinningMult{{ConfVtxBins, ConfMultBins}, true};
     ColumnBinningPolicy<aod::collision::PosZ, aod::femtouniversecollision::MultV0M> colBinningCent{{ConfVtxBins, ConfMultBins}, true};

PWGCF/Flow/TableProducer/ZDCQvectors.cxx

@@ -365,7 +365,7 @@ struct ZDCqvectors {
       cal.calibList[iteration][step] = ccdb->getForTimeStamp<TList>(ccdb_dir, timestamp);
 
       if (cal.calibList[iteration][step]) {
-        for (int i = 0; i < names.size(); i++) {
+        for (std::size_t i = 0; i < names.size(); i++) {
           TObject* obj = reinterpret_cast<TObject*>(cal.calibList[iteration][step]->FindObject(Form("%s", names[i].Data())));
           if (!obj) {
             if (counter < 1) {
@@ -426,7 +426,7 @@ struct ZDCqvectors {
   double getCorrection(int iteration, int step, const char* objName)
   {
     T* hist = nullptr;
-    double calibConstant;
+    double calibConstant{0};
 
     hist = reinterpret_cast<T*>(cal.calibList[iteration][step]->FindObject(Form("%s", objName)));
     if (!hist) {
@@ -460,7 +460,7 @@ struct ZDCqvectors {
         sparsePars.push_back(h->GetAxis(3)->FindBin(v[1]));
         sparsePars.push_back(h->GetAxis(4)->FindBin(v[2]));
       }
-      for (int i = 0; i < sparsePars.size(); i++) {
+      for (std::size_t i = 0; i < sparsePars.size(); i++) {
         h->GetAxis(i)->SetRange(sparsePars[i], sparsePars[i]);
       }
       calibConstant = h->Projection(sparsePars.size())->GetMean();

PWGCF/Flow/Tasks/FlowGFWPbPb.cxx

@@ -162,7 +162,7 @@ struct FlowGFWPbPb {
     ccdb->setCreatedNotAfter(nolaterthan.value);
 
     // Add some output objects to the histogram registry
-    registry.add("hEventCount", "Number of Events;; No. of Events", {HistType::kTH1D, {{kNOOFEVENTSTEPS, -0.5, kNOOFEVENTSTEPS - 0.5}}});
+    registry.add("hEventCount", "Number of Events;; No. of Events", {HistType::kTH1D, {{kNOOFEVENTSTEPS, -0.5, +kNOOFEVENTSTEPS - 0.5}}});
     registry.get<TH1>(HIST("hEventCount"))->GetXaxis()->SetBinLabel(kFILTERED + 1, "Filtered events");
     registry.get<TH1>(HIST("hEventCount"))->GetXaxis()->SetBinLabel(kSEL8 + 1, "Sel8");
     registry.get<TH1>(HIST("hEventCount"))->GetXaxis()->SetBinLabel(kOCCUPANCY + 1, "Occupancy");

PWGCF/Flow/Tasks/FlowRunbyRun.cxx

@@ -185,7 +185,6 @@ struct FlowRunbyRun {
     for (auto& track : tracks) {
       TH1sList[runNumber][hPhi]->Fill(track.phi());
       TH1sList[runNumber][hEta]->Fill(track.eta());
-      bool WithinPtPOI = (cfgCutPtPOIMin < track.pt()) && (track.pt() < cfgCutPtPOIMax); // within POI pT range
       bool WithinPtRef = (cfgCutPtRefMin < track.pt()) && (track.pt() < cfgCutPtRefMax); // within RF pT range
       if (WithinPtRef) {
         fGFW->Fill(track.eta(), 1, track.phi(), wacc * weff, 1);