NucleiTask - Partial fit of O2Linter

Author: giovannimalfattore

PWGLF/Tasks/Nuspex/LFNucleiBATask.cxx

@@ -2232,8 +2232,7 @@ struct LFNucleiBATask {
 
     tracks.copyIndexBindings(tracksWithITS);
 
-    // NOLINTNEXTLINE(performance-unnecessary-copy-initialization)
-    for (auto& track : tracksWithITS) {
+    for (auto const& track : tracksWithITS) {
       if constexpr (!IsFilteredData) {
         if (!track.isGlobalTrackWoDCA() && filterOptions.enableIsGlobalTrack) {
           continue;
@@ -2278,26 +2277,20 @@ struct LFNucleiBATask {
       float shiftPtNeg = 0.f;
 
       if (enablePtShiftHe && !fShiftPtHe) {
-        // NOLINTNEXTLINE(cppcoreguidelines-owning-memory, modernize-make-unique)
         fShiftPtHe = new TF1("fShiftPtHe", "[0] * exp([1] + [2] * x) + [3] + [4] * x", 0.f, 8.f);
-        // NOLINTNEXTLINE(cppcoreguidelines-pro-type-cstyle-cast)
-        auto parHe = (std::vector<float>)parShiftPtHe;
+        auto parHe = (std::vector<float>)parShiftPtHe; // NOLINT
         fShiftPtHe->SetParameters(parHe[0], parHe[1], parHe[2], parHe[3], parHe[4]);
       }
 
       if (enablePtShiftHe && !fShiftPtantiHe) {
-        // NOLINTNEXTLINE(cppcoreguidelines-owning-memory, modernize-make-unique)
         fShiftPtantiHe = new TF1("fShiftPtantiHe", "[0] * exp([1] + [2] * x) + [3] + [4] * x", 0.f, 8.f);
-        // NOLINTNEXTLINE(cppcoreguidelines-pro-type-cstyle-cast)
-        auto parAntiHe = (std::vector<float>)parShiftPtAntiHe;
+        auto parAntiHe = (std::vector<float>)parShiftPtAntiHe; // NOLINT
         fShiftPtantiHe->SetParameters(parAntiHe[0], parAntiHe[1], parAntiHe[2], parAntiHe[3], parAntiHe[4]);
       }
 
       if (enablePtShiftAntiD && !fShiftAntiD) {
-        // NOLINTNEXTLINE(cppcoreguidelines-owning-memory, modernize-make-unique)
         fShiftAntiD = new TF1("fShiftAntiD", "[0] * exp([1] + [2] * x) + [3] + [4] * x", 0.f, 8.f);
-        // NOLINTNEXTLINE(cppcoreguidelines-pro-type-cstyle-cast)
-        auto parAntiD = (std::vector<float>)parShiftPtAntiD;
+        auto parAntiD = (std::vector<float>)parShiftPtAntiD; // NOLINT
         fShiftAntiD->SetParameters(parAntiD[0], parAntiD[1], parAntiD[2], parAntiD[3], parAntiD[4]);
       }
 
@@ -2314,10 +2307,8 @@ struct LFNucleiBATask {
       }
 
       if (enablePtShiftD && !fShiftD) {
-        // NOLINTNEXTLINE(cppcoreguidelines-owning-memory, modernize-make-unique)
         fShiftD = new TF1("fShiftD", "[0] * exp([1] + [2] * x) + [3] + [4] * x", 0.f, 8.f);
-        // NOLINTNEXTLINE(cppcoreguidelines-pro-type-cstyle-cast)
-        auto parD = (std::vector<float>)parShiftPtD;
+        auto parD = (std::vector<float>)parShiftPtD; // NOLINT
         fShiftD->SetParameters(parD[0], parD[1], parD[2], parD[3], parD[4]);
       }
 
@@ -2664,17 +2655,15 @@ struct LFNucleiBATask {
         if constexpr (IsFilteredData) {
           isPhysPrim = track.isPhysicalPrimary();
           isProdByGen = track.producedByGenerator();
-          // NOLINTNEXTLINE(readability-magic-numbers)
-          isWeakDecay = track.getProcess() == 4;
+          isWeakDecay = track.getProcess() == 4; // NOLINT
           pdgCode = track.pdgCode();
         } else {
           if (!track.has_mcParticle()) {
             continue;
           }
           isPhysPrim = track.mcParticle().isPhysicalPrimary();
           isProdByGen = track.mcParticle().producedByGenerator();
-          // NOLINTNEXTLINE(readability-magic-numbers)
-          isWeakDecay = track.mcParticle().getProcess() == 4;
+          isWeakDecay = track.mcParticle().getProcess() == 4; // NOLINT
           pdgCode = track.mcParticle().pdgCode();
         }
 
@@ -3178,8 +3167,7 @@ struct LFNucleiBATask {
         if constexpr (IsFilteredData) {
           isPhysPrim = track.isPhysicalPrimary();
           isProdByGen = track.producedByGenerator();
-          // NOLINTNEXTLINE(readability-magic-numbers)
-          isWeakDecay = track.getProcess() == 4;
+          isWeakDecay = track.getProcess() == 4; // NOLINT
           pdgCode = track.pdgCode();
           genPt = std::sqrt(std::pow(track.px(), 2) + std::pow(track.py(), 2));
 
@@ -3189,8 +3177,7 @@ struct LFNucleiBATask {
           }
           isPhysPrim = track.mcParticle().isPhysicalPrimary();
           isProdByGen = track.mcParticle().producedByGenerator();
-          // NOLINTNEXTLINE(readability-magic-numbers)
-          isWeakDecay = track.mcParticle().getProcess() == 4;
+          isWeakDecay = track.mcParticle().getProcess() == 4; // NOLINT
           pdgCode = track.mcParticle().pdgCode();
 
           // Access to MC particles mother
@@ -3200,7 +3187,6 @@ struct LFNucleiBATask {
           firstMotherId = -1;
           firstMotherPdg = -1;
 
-          // int pdgList[8];
           nSaved = 0;
 
           for (int iMom = 0; iMom < nMothers; ++iMom) {
@@ -6073,8 +6059,7 @@ struct LFNucleiBATask {
     spectraGen.fill(HIST("histGenVetxZ"), mcCollision.posZ());
     if (mcCollision.centFT0M() < cfgMultCutLow || mcCollision.centFT0M() > cfgMultCutHigh)
       return;
-    // NOLINTNEXTLINE(performance-unnecessary-copy-initialization)
-    for (auto& mcParticleGen : mcParticles) {
+    for (auto& mcParticleGen : mcParticles) { // NOLINT
       if (mcParticleGen.y() > kinemOptions.cfgRapidityCutHigh || mcParticleGen.y() < kinemOptions.cfgRapidityCutLow) {
         continue;
       }