[PWGLF] Fix compilation warnings (#8386)

vkucera · alibuild · web-flow · commit 927ab79157f7 · 2024-11-25T08:42:10.000+01:00
Co-authored-by: ALICE Builder &lt;alibuild@users.noreply.github.com&gt;
diff --git a/PWGLF/TableProducer/Common/spvector.cxx b/PWGLF/TableProducer/Common/spvector.cxx
@@ -422,11 +422,6 @@ struct spvector {
           qxZDCC = qxZDCC / sumC;
           qyZDCC = qyZDCC / sumC;
         }
-      } else {
-        qxZDCA = qxZDCA;
-        qxZDCC = qxZDCC;
-        qyZDCA = qyZDCA;
-        qyZDCC = qyZDCC;
       }
       if (sumA <= 1e-4 || sumC <= 1e-4) {
         qxZDCA = 0.0;
diff --git a/PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx b/PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx
@@ -82,13 +82,13 @@ namespace
 constexpr double betheBlochDefault[1][6]{{-1.e32, -1.e32, -1.e32, -1.e32, -1.e32, -1.e32}};
 static const std::vector<std::string> betheBlochParNames{"p0", "p1", "p2", "p3", "p4", "resolution"};
 
-constexpr float he3Mass = o2::constants::physics::MassHelium3;
-constexpr float protonMass = o2::constants::physics::MassProton;
-constexpr float pionchargedMass = o2::constants::physics::MassPiPlus;
+// constexpr float he3Mass = o2::constants::physics::MassHelium3;
+// constexpr float protonMass = o2::constants::physics::MassProton;
+// constexpr float pionchargedMass = o2::constants::physics::MassPiPlus;
 constexpr int li4PDG = 1000030040;
 constexpr int prPDG = 2212;
 constexpr int hePDG = 1000020030;
-constexpr int pichargedPDG = 211;
+// constexpr int pichargedPDG = 211;
 
 enum Selections {
   kNoCuts = 0,
diff --git a/PWGLF/TableProducer/Strangeness/Converters/v0mlscoresconverter.cxx b/PWGLF/TableProducer/Strangeness/Converters/v0mlscoresconverter.cxx
@@ -26,7 +26,7 @@ struct v0mlscoresconverter {
 
   void process(aod::V0Cores const& v0cores)
   {
-    for (auto& values : v0cores) {
+    for (int64_t i = 0; i < v0cores.size(); ++i) {
       gammaMLSelections(-1);
       lambdaMLSelections(-1);
       antiLambdaMLSelections(-1);
diff --git a/PWGLF/TableProducer/Strangeness/cascadebuilder.cxx b/PWGLF/TableProducer/Strangeness/cascadebuilder.cxx
@@ -36,6 +36,8 @@
 //    david.dobrigkeit.chinellato@cern.ch
 //
 
+#include <string>
+#include <vector>
 #include <cmath>
 #include <array>
 #include <cstdlib>
@@ -2256,7 +2258,7 @@ struct cascadePreselector {
   void checkAndFinalize()
   {
     // parse + publish tag table now
-    for (int ii = 0; ii < selectionMask.size(); ii++) {
+    for (std::size_t ii = 0; ii < selectionMask.size(); ii++) {
       histos.fill(HIST("hPreselectorStatistics"), 0.0f); // All cascades
       bool validCascade = bitcheck(selectionMask[ii], bitTrackQuality);
       if (validCascade) {
diff --git a/PWGLF/TableProducer/Strangeness/cascadeflow.cxx b/PWGLF/TableProducer/Strangeness/cascadeflow.cxx
@@ -916,7 +916,6 @@ struct cascadeFlow {
       histosMCGen.fill(HIST("hNEventsMC"), 4.5);
 
     int biggestNContribs = -1;
-    int bestCollisionIndex = -1;
     float centrality = 100.5f;
     int nCollisions = 0;
     for (auto const& coll : collisions) {
@@ -925,7 +924,6 @@ struct cascadeFlow {
       }
       if (biggestNContribs < coll.multPVTotalContributors()) {
         biggestNContribs = coll.multPVTotalContributors();
-        bestCollisionIndex = coll.globalIndex();
         centrality = coll.centFT0C();
       }
       nCollisions++;
diff --git a/PWGLF/TableProducer/Strangeness/lambdakzerobuilder.cxx b/PWGLF/TableProducer/Strangeness/lambdakzerobuilder.cxx
@@ -36,6 +36,8 @@
 //    david.dobrigkeit.chinellato@cern.ch
 //
 
+#include <string>
+#include <vector>
 #include <cmath>
 #include <array>
 #include <cstdlib>
@@ -1562,7 +1564,7 @@ struct lambdakzeroPreselector {
   void checkAndFinalize()
   {
     // parse + publish tag table now
-    for (int ii = 0; ii < selectionMask.size(); ii++) {
+    for (std::size_t ii = 0; ii < selectionMask.size(); ii++) {
       histos.fill(HIST("hPreselectorStatistics"), 0.0f); // all V0s
       bool validV0 = bitcheck(selectionMask[ii], bitTrackQuality);
       if (validV0) {
diff --git a/PWGLF/TableProducer/Strangeness/lambdakzeromcfinder.cxx b/PWGLF/TableProducer/Strangeness/lambdakzeromcfinder.cxx
@@ -24,10 +24,18 @@
 //    david.dobrigkeit.chinellato@cern.ch
 //
 
-#include <Math/Vector4D.h>
 #include <cmath>
 #include <array>
 #include <cstdlib>
+#include <vector>
+
+#include "Math/Vector4D.h"
+#include <TFile.h>
+#include <TLorentzVector.h>
+#include <TH1F.h>
+#include <TH2F.h>
+#include <TProfile.h>
+#include <TPDGCode.h>
 
 #include "Framework/runDataProcessing.h"
 #include "Framework/AnalysisTask.h"
@@ -50,14 +58,6 @@
 #include "CommonConstants/PhysicsConstants.h"
 #include "PWGMM/Mult/DataModel/Index.h" // for Particles2Tracks table
 
-#include <TFile.h>
-#include <TLorentzVector.h>
-#include <TH1F.h>
-#include <TH2F.h>
-#include <TProfile.h>
-#include <TPDGCode.h>
-#include <TDatabasePDG.h>
-
 using namespace o2;
 using namespace o2::framework;
 using namespace o2::framework::expressions;
@@ -351,7 +351,7 @@ struct lambdakzeromcfinder {
         continue; // skip particles without decay mothers
       for (auto& posMotherParticle : posParticle.mothers_as<aod::McParticles>()) {
         // determine if mother particle satisfies any condition curently being searched for
-        for (int ipdg = 0; ipdg < searchedV0PDG.size(); ipdg++)
+        for (std::size_t ipdg = 0; ipdg < searchedV0PDG.size(); ipdg++)
           if (searchedV0PDG[ipdg] == posMotherParticle.pdgCode() && fabs(posMotherParticle.y()) < yPreFilter) {
             v0pdgIndex = ipdg; // index mapping to desired V0 species
             motherIndex = posMotherParticle.globalIndex();
diff --git a/PWGLF/Tasks/Nuspex/spectraTOF.cxx b/PWGLF/Tasks/Nuspex/spectraTOF.cxx
@@ -1124,7 +1124,7 @@ struct tofSpectra {
   }
 
   template <bool fillHistograms = false, typename TrackType, typename CollisionType>
-  bool isTrackSelected(TrackType const& track, CollisionType const& collision)
+  bool isTrackSelected(TrackType const& track, CollisionType const& /*collision*/)
   {
     if constexpr (fillHistograms) {
       histos.fill(HIST("tracksel"), 1);
diff --git a/PWGLF/Tasks/Resonances/highmasslambda.cxx b/PWGLF/Tasks/Resonances/highmasslambda.cxx
@@ -838,13 +838,6 @@ struct highmasslambda {
         }
         auto anglesign = (v0.x() - collision1.posX()) * v0.px() + (v0.y() - collision1.posY()) * v0.py() + (v0.z() - collision1.posZ()) * v0.pz();
         anglesign = anglesign / TMath::Abs(anglesign);
-        auto dcasum = 0.0;
-        if (useSignDCAV0) {
-          dcasum = anglesign * (v0.dcav0topv()) - track1.dcaXY();
-        }
-        if (!useSignDCAV0) {
-          dcasum = v0.dcav0topv() - track1.dcaXY();
-        }
 
         if (occupancy1 < cfgOccupancyCut && occupancy2 < cfgOccupancyCut && Lambdac.M() > cMinLambdaMass && Lambdac.M() <= cMaxLambdaMass && TMath::Abs(Lambdac.Rapidity()) < confRapidity && Lambdac.Pt() > 2.0 && Lambdac.Pt() <= 6.0) {
           if (fillDefault) {
diff --git a/PWGLF/Tasks/Resonances/kstarpbpb.cxx b/PWGLF/Tasks/Resonances/kstarpbpb.cxx
@@ -375,7 +375,7 @@ struct kstarpbpb {
     return result;
   }
   template <typename T>
-  bool isFakeKaon(T const& track, int PID)
+  bool isFakeKaon(T const& track, int /*PID*/)
   {
     const auto pglobal = track.p();
     const auto ptpc = track.tpcInnerParam();
diff --git a/PWGLF/Tasks/Resonances/phianalysisrun3_PbPb.cxx b/PWGLF/Tasks/Resonances/phianalysisrun3_PbPb.cxx
@@ -267,7 +267,7 @@ struct phianalysisrun3_PbPb {
     {
       return;
     }
-    float multiplicity;
+    float multiplicity{-1};
     if (cfgMultFT0)
       multiplicity = collision.centFT0C();
     histos.fill(HIST("hCentrality"), multiplicity);
diff --git a/PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx b/PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx
@@ -1206,7 +1206,7 @@ struct correlateStrangeness {
     }
   }
 
-  void processMCGenerated(aod::McCollision const& mcCollision, soa::SmallGroups<soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSels, aod::CentFT0Ms, aod::PVMults>> const& collisions, aod::McParticles const& mcParticles)
+  void processMCGenerated(aod::McCollision const& /*mcCollision*/, soa::SmallGroups<soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSels, aod::CentFT0Ms, aod::PVMults>> const& collisions, aod::McParticles const& mcParticles)
   {
     histos.fill(HIST("hClosureTestEventCounter"), 2.5f);
 
@@ -1349,7 +1349,7 @@ struct correlateStrangeness {
       });
     }
   }
-  void processClosureTest(aod::McCollision const& mcCollision, soa::SmallGroups<soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSels, aod::CentFT0Ms, aod::PVMults>> const& recCollisions, aod::McParticles const& mcParticles)
+  void processClosureTest(aod::McCollision const& /*mcCollision*/, soa::SmallGroups<soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSels, aod::CentFT0Ms, aod::PVMults>> const& recCollisions, aod::McParticles const& mcParticles)
   {
 
     std::vector<uint32_t> triggerIndices;
@@ -1508,7 +1508,7 @@ struct correlateStrangeness {
     associatedIndices.emplace_back(omegaPlusIndices);
     associatedIndices.emplace_back(piIndices);
 
-    for (Int_t iTrigger = 0; iTrigger < triggerIndices.size(); iTrigger++) {
+    for (std::size_t iTrigger = 0; iTrigger < triggerIndices.size(); iTrigger++) {
       auto triggerParticle = mcParticles.iteratorAt(triggerIndices[iTrigger]);
       // check range of trigger particle
       if (triggerParticle.pt() > axisRanges[3][1] || triggerParticle.pt() < axisRanges[3][0]) {
@@ -1518,10 +1518,10 @@ struct correlateStrangeness {
       Double_t gphitrigger = triggerParticle.phi();
       Double_t pttrigger = triggerParticle.pt();
       auto const& mother = triggerParticle.mothers_first_as<aod::McParticles>();
-      Int_t globalIndex = mother.globalIndex();
+      auto globalIndex = mother.globalIndex();
       static_for<0, 7>([&](auto i) { // associated loop
         constexpr int index = i.value;
-        for (Int_t iassoc = 0; iassoc < associatedIndices[index].size(); iassoc++) {
+        for (std::size_t iassoc = 0; iassoc < associatedIndices[index].size(); iassoc++) {
           auto assocParticle = mcParticles.iteratorAt(associatedIndices[index][iassoc]);
           if (triggerIndices[iTrigger] != associatedIndices[index][iassoc] && globalIndex != assocParticle.globalIndex()) { // avoid self
             Double_t getaassoc = assocParticle.eta();
diff --git a/PWGLF/Tasks/Strangeness/k0_mixed_events.cxx b/PWGLF/Tasks/Strangeness/k0_mixed_events.cxx
@@ -13,9 +13,14 @@
 /// \author Sofia Tomassini, Gleb Romanenko, Nicolò Jacazio
 /// \since 31 May 2023
 
+#include <vector>
+#include <map>
+#include <memory>
+#include <utility>
+
 #include <TParameter.h>
 #include <TH1F.h>
-#include <vector>
+#include <TLorentzVector.h>
 
 #include "Framework/runDataProcessing.h"
 #include "Framework/AnalysisTask.h"
@@ -32,9 +37,6 @@
 #include "PWGCF/Femto3D/DataModel/singletrackselector.h"
 #include "PWGCF/Femto3D/Core/femto3dPairTask.h"
 
-#include "TLorentzVector.h"
-#include "TDatabasePDG.h"
-
 using namespace o2;
 using namespace o2::soa;
 using namespace o2::aod;
@@ -297,7 +299,7 @@ struct K0MixedEvents {
       }
 
       registry.fill(HIST("Trks"), 1);
-      const float& vtxZ = track.singleCollSel_as<FilteredCollisions>().posZ();
+      const float vtxZ = track.singleCollSel_as<FilteredCollisions>().posZ();
       registry.fill(HIST("VTX"), vtxZ);
       if (std::abs(vtxZ) > _vertexZ)
         continue;
diff --git a/PWGLF/Tasks/Strangeness/v0ptinvmassplots.cxx b/PWGLF/Tasks/Strangeness/v0ptinvmassplots.cxx
@@ -19,6 +19,10 @@ for different pt ranges (constituting bins), so 3x20=60 plots.The values are ins
 Plots of the invariant masses at different stages of the analysis (ex. before and after the V0 cuts are enforced) and some pt distributions.
 This analysis includes two processes, one for Real Data and one for MC Data switchable at the end of the code, only run one at a time*/
 
+#include <memory>
+#include <vector>
+#include <string>
+
 #include "Framework/runDataProcessing.h"
 #include "Framework/AnalysisTask.h"
 #include "Common/DataModel/EventSelection.h"
@@ -193,7 +197,7 @@ struct v0ptinvmassplots {
   void RecMCprocess(soa::Filtered<soa::Join<aod::Collisions, aod::EvSels>>::iterator const&,
                     soa::Join<aod::V0Datas, aod::McV0Labels> const& V0s,
                     DaughterTracks const&, // no need to define a variable for tracks, if we don't access them directly
-                    aod::McParticles const& mcParticles)
+                    aod::McParticles const& /*mcParticles*/)
   {
     for (const auto& v0 : V0s) {
       rPtAnalysis.fill(HIST("hV0PtAll"), v0.pt());
diff --git a/PWGLF/Utils/svPoolCreator.h b/PWGLF/Utils/svPoolCreator.h
@@ -29,7 +29,7 @@ using namespace o2::framework::expressions;
 using std::array;
 using CollBracket = o2::math_utils::Bracket<int>;
 
-constexpr auto bOffsetMax = 241; // track compatibility can never go beyond 6 mus (ITS)
+constexpr uint64_t bOffsetMax = 241; // track compatibility can never go beyond 6 mus (ITS)
 
 struct TrackCand {
   int Idxtr;
@@ -86,7 +86,8 @@ class svPoolCreator
       return;
     }
     bool isDau0 = pdgHypo == track0Pdg;
-    uint64_t globalBC = -1;
+    constexpr uint64_t BcInvalid = -1;
+    uint64_t globalBC = BcInvalid;
     if (trackCand.has_collision()) {
       if (trackCand.template collision_as<C>().has_bc()) {
         globalBC = trackCand.template collision_as<C>().template bc_as<aod::BCsWithTimestamps>().globalBC();
@@ -97,17 +98,17 @@ class svPoolCreator
           continue;
         }
         if (!ambTrack.has_bc() || ambTrack.bc_as<aod::BCsWithTimestamps>().size() == 0) {
-          globalBC = -1;
+          globalBC = BcInvalid;
           break;
         }
         globalBC = ambTrack.bc_as<aod::BCsWithTimestamps>().begin().globalBC();
         break;
       }
     } else {
-      globalBC = -1;
+      globalBC = BcInvalid;
     }
 
-    if (globalBC == -1) {
+    if (globalBC == BcInvalid) {
       return;
     }
 
@@ -128,11 +129,13 @@ class svPoolCreator
       float collTimeRes2 = collision.collisionTimeRes() * collision.collisionTimeRes();
       uint64_t collBC = collision.template bc_as<aod::BCsWithTimestamps>().globalBC();
       int collIdx = collision.globalIndex();
-      int64_t bcOffset = globalBC - (int64_t)collBC;
-      if (std::abs(bcOffset) > bOffsetMax && bcOffset < 0) {
-        break;
-      } else if (std::abs(bcOffset) > bOffsetMax && bcOffset > 0) {
-        continue;
+      int64_t bcOffset = globalBC - static_cast<int64_t>(collBC);
+      if (static_cast<uint64_t>(std::abs(bcOffset)) > bOffsetMax) {
+        if (bcOffset < 0) {
+          break;
+        } else if (bcOffset > 0) {
+          continue;
+        }
       }
 
       float trackTime{0.};

Original file line number	Diff line number	Diff line change
`@@ -422,11 +422,6 @@ struct spvector {`
`422`	`422`	`qxZDCC = qxZDCC / sumC;`
`423`	`423`	`qyZDCC = qyZDCC / sumC;`
`424`	`424`	`}`
`425`		`- } else {`
`426`		`- qxZDCA = qxZDCA;`
`427`		`- qxZDCC = qxZDCC;`
`428`		`- qyZDCA = qyZDCA;`
`429`		`- qyZDCC = qyZDCC;`
`430`	`425`	`}`
`431`	`426`	`if (sumA <= 1e-4 \|\| sumC <= 1e-4) {`
`432`	`427`	`qxZDCA = 0.0;`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ struct v0mlscoresconverter {`
`26`	`26`
`27`	`27`	`void process(aod::V0Cores const& v0cores)`
`28`	`28`	`{`
`29`		`- for (auto& values : v0cores) {`
	`29`	`+ for (int64_t i = 0; i < v0cores.size(); ++i) {`
`30`	`30`	`gammaMLSelections(-1);`
`31`	`31`	`lambdaMLSelections(-1);`
`32`	`32`	`antiLambdaMLSelections(-1);`
Original file line number	Diff line number	Diff line change
`@@ -916,7 +916,6 @@ struct cascadeFlow {`
`916`	`916`	`histosMCGen.fill(HIST("hNEventsMC"), 4.5);`
`917`	`917`
`918`	`918`	`int biggestNContribs = -1;`
`919`		`- int bestCollisionIndex = -1;`
`920`	`919`	`float centrality = 100.5f;`
`921`	`920`	`int nCollisions = 0;`
`922`	`921`	`for (auto const& coll : collisions) {`
`@@ -925,7 +924,6 @@ struct cascadeFlow {`
`925`	`924`	`}`
`926`	`925`	`if (biggestNContribs < coll.multPVTotalContributors()) {`
`927`	`926`	`biggestNContribs = coll.multPVTotalContributors();`
`928`		`- bestCollisionIndex = coll.globalIndex();`
`929`	`927`	`centrality = coll.centFT0C();`
`930`	`928`	`}`
`931`	`929`	`nCollisions++;`
Original file line number	Diff line number	Diff line change
`@@ -1124,7 +1124,7 @@ struct tofSpectra {`
`1124`	`1124`	`}`
`1125`	`1125`
`1126`	`1126`	`template <bool fillHistograms = false, typename TrackType, typename CollisionType>`
`1127`		`- bool isTrackSelected(TrackType const& track, CollisionType const& collision)`
	`1127`	`+ bool isTrackSelected(TrackType const& track, CollisionType const& /collision/)`
`1128`	`1128`	`{`
`1129`	`1129`	`if constexpr (fillHistograms) {`
`1130`	`1130`	`histos.fill(HIST("tracksel"), 1);`
Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,7 @@ struct kstarpbpb {`
`375`	`375`	`return result;`
`376`	`376`	`}`
`377`	`377`	`template <typename T>`
`378`		`- bool isFakeKaon(T const& track, int PID)`
	`378`	`+ bool isFakeKaon(T const& track, int /PID/)`
`379`	`379`	`{`
`380`	`380`	`const auto pglobal = track.p();`
`381`	`381`	`const auto ptpc = track.tpcInnerParam();`