[PWGLF] Fix V0DataLink filling + return calls when moving TPC only tracks (#12330)

romainschotter · alibuild · web-flow · commit 8d2fe9ca6f3c · 2025-07-30T16:22:05.000+02:00
Co-authored-by: ALICE Action Bot &lt;alibuild@cern.ch&gt;
diff --git a/PWGLF/TableProducer/Strangeness/strangenessbuilder.cxx b/PWGLF/TableProducer/Strangeness/strangenessbuilder.cxx
@@ -1648,7 +1648,8 @@ struct StrangenessBuilder {
 
           auto const& collision = collisions.rawIteratorAt(v0.collisionId);
           if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, posTrack, posTrackPar)) {
-            return;
+            products.v0dataLink(-1, -1);
+            continue;
           }
         }
 
@@ -1660,7 +1661,8 @@ struct StrangenessBuilder {
 
           auto const& collision = collisions.rawIteratorAt(v0.collisionId);
           if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, negTrack, negTrackPar)) {
-            return;
+            products.v0dataLink(-1, -1);
+            continue;
           }
         }
       }
@@ -1925,6 +1927,8 @@ struct StrangenessBuilder {
             }
           } // enabled tables check
         } // constexpr requires check
+      } else {
+        products.v0dataLink(-1, -1);
       }
     }
 
diff --git a/PWGLF/Utils/strangenessBuilderModule.h b/PWGLF/Utils/strangenessBuilderModule.h
@@ -894,15 +894,15 @@ class BuilderModule
                 posTrackPar.setPID(o2::track::PID::Electron);
                 negTrackPar.setPID(o2::track::PID::Electron);
                 if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, pTrack, posTrackPar)) {
-                  return;
+                  continue;
                 }
               }
               if (isNegTPCOnly) {
                 // Nota bene: negative is TPC-only -> this entire V0 merits treatment as photon candidate
                 posTrackPar.setPID(o2::track::PID::Electron);
                 negTrackPar.setPID(o2::track::PID::Electron);
                 if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, nTrack, negTrackPar)) {
-                  return;
+                  continue;
                 }
               }
             } // end TPC drift treatment
@@ -1370,7 +1370,8 @@ class BuilderModule
 
           auto const& collision = collisions.rawIteratorAt(v0.collisionId);
           if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, posTrack, posTrackPar)) {
-            return;
+            products.v0dataLink(-1, -1);
+            continue;
           }
         }
 
@@ -1382,7 +1383,8 @@ class BuilderModule
 
           auto const& collision = collisions.rawIteratorAt(v0.collisionId);
           if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, negTrack, negTrackPar)) {
-            return;
+            products.v0dataLink(-1, -1);
+            continue;
           }
         }
       }
@@ -1647,6 +1649,8 @@ class BuilderModule
             }
           } // enabled tables check
         } // constexpr requires check
+      } else {
+        products.v0dataLink(-1, -1);
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1648,7 +1648,8 @@ struct StrangenessBuilder {`
`1648`	`1648`
`1649`	`1649`	`auto const& collision = collisions.rawIteratorAt(v0.collisionId);`
`1650`	`1650`	`if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, posTrack, posTrackPar)) {`
`1651`		`- return;`
	`1651`	`+ products.v0dataLink(-1, -1);`
	`1652`	`+ continue;`
`1652`	`1653`	`}`
`1653`	`1654`	`}`
`1654`	`1655`
`@@ -1660,7 +1661,8 @@ struct StrangenessBuilder {`
`1660`	`1661`
`1661`	`1662`	`auto const& collision = collisions.rawIteratorAt(v0.collisionId);`
`1662`	`1663`	`if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, negTrack, negTrackPar)) {`
`1663`		`- return;`
	`1664`	`+ products.v0dataLink(-1, -1);`
	`1665`	`+ continue;`
`1664`	`1666`	`}`
`1665`	`1667`	`}`
`1666`	`1668`	`}`
`@@ -1925,6 +1927,8 @@ struct StrangenessBuilder {`
`1925`	`1927`	`}`
`1926`	`1928`	`} // enabled tables check`
`1927`	`1929`	`} // constexpr requires check`
	`1930`	`+ } else {`
	`1931`	`+ products.v0dataLink(-1, -1);`
`1928`	`1932`	`}`
`1929`	`1933`	`}`
`1930`	`1934`
Original file line number	Diff line number	Diff line change
`@@ -894,15 +894,15 @@ class BuilderModule`
`894`	`894`	`posTrackPar.setPID(o2::track::PID::Electron);`
`895`	`895`	`negTrackPar.setPID(o2::track::PID::Electron);`
`896`	`896`	`if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, pTrack, posTrackPar)) {`
`897`		`- return;`
	`897`	`+ continue;`
`898`	`898`	`}`
`899`	`899`	`}`
`900`	`900`	`if (isNegTPCOnly) {`
`901`	`901`	`// Nota bene: negative is TPC-only -> this entire V0 merits treatment as photon candidate`
`902`	`902`	`posTrackPar.setPID(o2::track::PID::Electron);`
`903`	`903`	`negTrackPar.setPID(o2::track::PID::Electron);`
`904`	`904`	`if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, nTrack, negTrackPar)) {`
`905`		`- return;`
	`905`	`+ continue;`
`906`	`906`	`}`
`907`	`907`	`}`
`908`	`908`	`} // end TPC drift treatment`
`@@ -1370,7 +1370,8 @@ class BuilderModule`
`1370`	`1370`
`1371`	`1371`	`auto const& collision = collisions.rawIteratorAt(v0.collisionId);`
`1372`	`1372`	`if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, posTrack, posTrackPar)) {`
`1373`		`- return;`
	`1373`	`+ products.v0dataLink(-1, -1);`
	`1374`	`+ continue;`
`1374`	`1375`	`}`
`1375`	`1376`	`}`
`1376`	`1377`
`@@ -1382,7 +1383,8 @@ class BuilderModule`
`1382`	`1383`
`1383`	`1384`	`auto const& collision = collisions.rawIteratorAt(v0.collisionId);`
`1384`	`1385`	`if (!mVDriftMgr.moveTPCTrack<TBCs, TCollisions>(collision, negTrack, negTrackPar)) {`
`1385`		`- return;`
	`1386`	`+ products.v0dataLink(-1, -1);`
	`1387`	`+ continue;`
`1386`	`1388`	`}`
`1387`	`1389`	`}`
`1388`	`1390`	`}`
`@@ -1647,6 +1649,8 @@ class BuilderModule`
`1647`	`1649`	`}`
`1648`	`1650`	`} // enabled tables check`
`1649`	`1651`	`} // constexpr requires check`
	`1652`	`+ } else {`
	`1653`	`+ products.v0dataLink(-1, -1);`
`1650`	`1654`	`}`
`1651`	`1655`	`}`
`1652`	`1656`