Update TListHandler.h

Author: rahulverma012

Common/Tools/TListHandler.h

@@ -15,8 +15,8 @@
 ///        functions and methods defined in HistogramRegistry.h and HisgtogramRegistry.cxx
 /// \author Rahul Verma (rahul.verma@cern.ch, rahul.verma@iitb.ac.in)
 
-#ifndef FRAMEWORK_TLISTHANDLER_H_
-#define FRAMEWORK_TLISTHANDLER_H_
+#ifndef COMMON_TOOLS_TLISTHANDLER_H_
+#define COMMON_TOOLS_TLISTHANDLER_H_
 
 #include "Framework/AnalysisTask.h"
 #include "Framework/HistogramSpec.h"
@@ -42,22 +42,22 @@ class TListHandler
   struct HistName {
     // ctor for histogram names that are already hashed at compile time via HIST("myHistName")
     template <char... chars>
-    constexpr HistName(const ConstStr<chars...>& hashedHistName);
+    explicit constexpr HistName(const ConstStr<chars...>& hashedHistName);
     char const* const str{};
     const uint32_t hash{};
     const uint32_t idx{};
 
    protected:
     friend class TListHandler;
     // ctor that does the hashing at runtime (for internal use only)
-    constexpr HistName(char const* const name);
+    explicit constexpr HistName(char const* const name);
   };
 
  public:
   TList* rootList;
   bool makeNestedList;
   TListHandler() : rootList(nullptr) {}         // Default constructor
-  TListHandler(TList* list) : rootList(list) {} // Constructor accepting a TList*
+  explicit TListHandler(TList* list) : rootList(list) {} // Constructor accepting a TList*
 
   // operator() overload to assign a new list
   void operator()(TList* list, bool makeNestedListFlag)
@@ -378,10 +378,10 @@ void TListHandler::insertInNestedTList(const std::string& name, const HistPtr hi
       TString dirPathT(dirPath.c_str());
       TObjArray* folders = dirPathT.Tokenize('/');
       for (int i = 0; i < folders->GetEntries(); ++i) {
-        TString subdir = ((TObjString*)folders->At(i))->GetString();
+        TString subdir = reinterpret_cast<TObjString*>(folders->At(i))->GetString();
         TObject* existingObj = parentList->FindObject(subdir);
         if (existingObj && existingObj->InheritsFrom(TList::Class())) {
-          subList = (TList*)existingObj;
+          subList = reinterpret_cast<TList*>(existingObj);
         } else {
           subList = new TList();
           subList->SetName(subdir);
@@ -393,7 +393,7 @@ void TListHandler::insertInNestedTList(const std::string& name, const HistPtr hi
     }
 
     TNamed* rawPtrToObj = nullptr;
-    std::visit([&](const auto& sharedPtr) { rawPtrToObj = (TNamed*)sharedPtr.get(); }, tObj);
+    std::visit([&](const auto& sharedPtr) { rawPtrToObj = reinterpret_cast<TNamed*>(sharedPtr.get()); }, tObj);
     rawPtrToObj->SetName(histName.c_str());
   }
 
@@ -520,7 +520,7 @@ const TList* getRootSubList(TList* rootList, std::string dirPath)
     TString dirPathT(dirPath.c_str());
     TObjArray* folders = dirPathT.Tokenize('/');
     for (int i = 0; i < folders->GetEntries(); ++i) {
-      TString subdir = ((TObjString*)folders->At(i))->GetString();
+      TString subdir = reinterpret_cast<TObjString*>(folders->At(i))->GetString();
       TObject* existingObj = parentList->FindObject(subdir);
       if (existingObj && existingObj->InheritsFrom(TList::Class())) {
         parentList = static_cast<const TList*>(existingObj);
@@ -579,7 +579,7 @@ void TListHandler::addClone(const std::string& source, const std::string& target
       if (!sharedPtr.get()) {
         return;
       }
-      std::string sourceName{((TNamed*)sharedPtr.get())->GetName()};
+      std::string sourceName{reinterpret_cast<TNamed*>(sharedPtr.get())->GetName()};
       // search for histograms starting with source_ substring
       if (sourceName.rfind(source, 0) == 0) {
         // when cloning groups of histograms source_ and target_ must end with "/"
@@ -618,7 +618,7 @@ double TListHandler::getSize(double fillFraction)
 {
   double size{};
   for (auto j = 0u; j < kMaxTListSize; ++j) {
-    std::visit([&fillFraction, &size](auto&& hist) { if(hist) { size += HistFiller::getSize(hist, fillFraction);} }, mTListValue[j]);
+    std::visit([&fillFraction, &size](auto&& hist) { if (hist) { size += HistFiller::getSize(hist, fillFraction);} }, mTListValue[j]);
   }
   return size;
 }
@@ -787,4 +787,4 @@ template std::shared_ptr<StepTHn> TListHandler::add<StepTHn>(char const* const n
 //--------------------------------------------------------------------------------------------------
 //--------------------------------------------------------------------------------------------------
 
-#endif // FRAMEWORK_TLISTHANDLER_H_
+#endif // COMMON_TOOLS_TLISTHANDLER_H_