Skip to content

Commit 77700e3

Browse files
committed
fix remaining magic numbers
1 parent 757f99e commit 77700e3

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

PWGLF/TableProducer/Nuspex/ebyeMaker.cxx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,8 @@ struct ebyeMaker {
720720
float beta{track.hasTOF() ? track.length() / (track.tofSignal() - track.tofEvTime()) * o2::constants::physics::invLightSpeedCm2PS : -999.f};
721721
beta = std::min(1.f - 1.e-6f, std::max(1.e-4f, beta));
722722
float mass{track.tpcInnerParam() * std::sqrt(1.f / (beta * beta) - 1.f)};
723-
bool hasTof = track.hasTOF() && track.tofChi2() < 3;
723+
const float maxTofChi2 = 3.f;
724+
bool hasTof = track.hasTOF() && track.tofChi2() < maxTofChi2;
724725

725726
if (trackPt <= ptTof[iP] || (trackPt > ptTof[iP] && hasTof && std::abs(mass - partMass[iP]) < tofMassMaxQA)) { // for QA histograms
726727
if (nSigmaTPC > nSigmaTpcCutLow[iP] && nSigmaTPC < nSigmaTpcCutUp[iP]) {
@@ -1131,7 +1132,8 @@ struct ebyeMaker {
11311132
float cV0M = 105.f;
11321133
if (Run2V0MInfo.mCalibrationStored) {
11331134
cV0M = Run2V0MInfo.mhMultSelCalib->GetBinContent(Run2V0MInfo.mhMultSelCalib->FindFixBin(v0m));
1134-
if (!(collision.sel7() && collision.alias_bit(kINT7)) && (!kINT7Intervals || (kINT7Intervals && ((cV0M >= 10 && cV0M < 30) || cV0M > 50))))
1135+
const float centTriggerEdges[]{10.f, 30.f, 50.f};
1136+
if (!(collision.sel7() && collision.alias_bit(kINT7)) && (!kINT7Intervals || (kINT7Intervals && ((cV0M >= centTriggerEdges[0] && cV0M < centTriggerEdges[1]) || cV0M > centTriggerEdges[2]))))
11351137
continue;
11361138
}
11371139

@@ -1217,7 +1219,8 @@ struct ebyeMaker {
12171219
continue;
12181220

12191221
float v0m = getV0M(bc.globalIndex(), collision.posZ(), fv0as, fv0cs);
1220-
float cV0M = 105.f;
1222+
float maxV0M = 105.f;
1223+
float cV0M = maxV0M;
12211224
if (Run2V0MInfo.mCalibrationStored) {
12221225
cV0M = Run2V0MInfo.mhMultSelCalib->GetBinContent(Run2V0MInfo.mhMultSelCalib->FindFixBin(v0m));
12231226
}
@@ -1234,7 +1237,7 @@ struct ebyeMaker {
12341237
for (const auto& classId : classIds) {
12351238
if (bc.triggerMask() & BIT(classId)) {
12361239
trigger |= 0x2;
1237-
cV0M = cV0M < 104.f ? cV0M * 100. : cV0M;
1240+
cV0M = cV0M < (maxV0M - 1.f) ? cV0M * 100. : cV0M;
12381241
break;
12391242
}
12401243
}

0 commit comments

Comments
 (0)