Update

Author: njacazio

ALICE3/Core/TrackUtilities.h

@@ -20,6 +20,8 @@
 #define ALICE3_CORE_TRACKUTILITIES_H_
 
 #include "ReconstructionDataFormats/Track.h"
+#include "Framework/O2DatabasePDGPlugin.h"
+#include "Framework/AnalysisHelpers.h"
 
 namespace o2::upgrade
 {
@@ -32,7 +34,7 @@ void convertMCParticleToO2Track(McParticleType& particle,
                                 o2::track::TrackParCov& o2track,
                                 const o2::framework::Service<o2::framework::O2DatabasePDG>& pdg)
 {
-  auto pdgInfo = pdg->GetParticle(particle.pdgCode());
+  const auto pdgInfo = pdg->GetParticle(particle.pdgCode());
   int charge = 0;
   if (pdgInfo != nullptr) {
     charge = pdgInfo->Charge() / 3;
@@ -44,7 +46,7 @@ void convertMCParticleToO2Track(McParticleType& particle,
   o2::math_utils::rotateZInv(particle.vx(), particle.vy(), x, params[0], s, c);
   params[1] = particle.vz();
   params[2] = 0.; // since alpha = phi
-  auto theta = 2. * std::atan(std::exp(-particle.eta()));
+  const auto theta = 2. * std::atan(std::exp(-particle.eta()));
   params[3] = 1. / std::tan(theta);
   params[4] = charge / particle.pt();
 
@@ -59,7 +61,7 @@ template <typename McParticleType>
 o2::track::TrackParCov convertMCParticleToO2Track(McParticleType& particle,
                                                   const o2::framework::Service<o2::framework::O2DatabasePDG>& pdg)
 {
-  TrackParCov o2track;
+  o2::track::TrackParCov o2track;
   convertMCParticleToO2Track(particle, o2track, pdg);
 }
 

ALICE3/TableProducer/OTF/onTheFlyTracker.cxx

@@ -276,7 +276,7 @@ struct OnTheFlyTracker {
         mapPdgLut.insert(std::make_pair(1000010030, lutTrChar));
         mapPdgLut.insert(std::make_pair(1000020030, lutHe3Char));
       }
-      for (auto e : mapPdgLut) {
+      for (const auto& e : mapPdgLut) {
         if (!mSmearer.loadTable(e.first, e.second)) {
           LOG(fatal) << "Having issue with loading the LUT " << e.first << " " << e.second;
         }