Skip to content

Commit 5ac3495

Browse files
committed
Fix magic number issue in O2Linter
1 parent 91793e0 commit 5ac3495

File tree

1 file changed

+19
-12
lines changed

1 file changed

+19
-12
lines changed

PWGCF/Flow/Tasks/flowGfwTask.cxx

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -726,11 +726,11 @@ struct FlowGfwTask {
726726
registry.fill(HIST("hEventCount"), kISGOODITSLAYERSALL);
727727
}
728728

729-
float vtxz = -999;
729+
float vtxz = -999, zResmin=0.25, maxContrib=20;
730730
if (collision.numContrib() > 1) {
731731
vtxz = collision.posZ();
732732
float zRes = std::sqrt(collision.covZZ());
733-
if (zRes > 0.25 && collision.numContrib() < 20)
733+
if (zRes > zResmin && collision.numContrib() < maxContrib)
734734
vtxz = -999;
735735
}
736736

@@ -752,8 +752,9 @@ struct FlowGfwTask {
752752
}
753753

754754
// V0A T0A 5 sigma cut
755+
float five=5;
755756
if (cfgV0AT0A5Sigma) {
756-
if (std::abs(collision.multFV0A() - fT0AV0AMean->Eval(collision.multFT0A())) > 5 * fT0AV0ASigma->Eval(collision.multFT0A()))
757+
if (std::abs(collision.multFV0A() - fT0AV0AMean->Eval(collision.multFT0A())) > five * fT0AV0ASigma->Eval(collision.multFT0A()))
757758
return false;
758759
}
759760

@@ -933,13 +934,14 @@ struct FlowGfwTask {
933934

934935
registry.fill(HIST("ZNvsZEMcoll"), aZEM1 + aZEM2, aZNA + aZNC);
935936

936-
if (centrality >= 0 && centrality <= 5) {
937+
float zero=0, five=5, ten=10, twenty=20, thirty=30;
938+
if (centrality >= zero && centrality <= five) {
937939
registry.fill(HIST("ZNvsZEMcoll05"), aZEM1 + aZEM2, aZNA + aZNC);
938-
} else if (centrality > 5 && centrality <= 10) {
940+
} else if (centrality > five && centrality <= ten) {
939941
registry.fill(HIST("ZNvsZEMcoll510"), aZEM1 + aZEM2, aZNA + aZNC);
940-
} else if (centrality > 10 && centrality <= 20) {
942+
} else if (centrality > ten && centrality <= twenty) {
941943
registry.fill(HIST("ZNvsZEMcoll1020"), aZEM1 + aZEM2, aZNA + aZNC);
942-
} else if (centrality > 20 && centrality <= 30) {
944+
} else if (centrality > twenty && centrality <= thirty) {
943945
registry.fill(HIST("ZNvsZEMcoll2030"), aZEM1 + aZEM2, aZNA + aZNC);
944946
} else {
945947
registry.fill(HIST("ZNvsZEMcollrest"), aZEM1 + aZEM2, aZNA + aZNC);
@@ -1082,7 +1084,8 @@ struct FlowGfwTask {
10821084
fillProfile(corrconfigs.at(7), HIST("c34Nch"), nch);
10831085

10841086
// 0-5% centrality Nch
1085-
if (centrality >= 0 && centrality <= 5) {
1087+
float zero=0, five=5;
1088+
if (centrality >= zero && centrality <= five) {
10861089
fillProfile(corrconfigs.at(0), HIST("c22Nch05"), nch);
10871090
fillProfile(corrconfigs.at(1), HIST("c24Nch05"), nch);
10881091
fillProfile(corrconfigs.at(2), HIST("c26Nch05"), nch);
@@ -1117,7 +1120,8 @@ struct FlowGfwTask {
11171120
fillProfile(corrconfigs.at(6), bootstrapArray[sampleIndex][kc32Nchetagap], nch);
11181121
fillProfile(corrconfigs.at(7), bootstrapArray[sampleIndex][kc34Nch], nch);
11191122

1120-
if (centrality >= 0 && centrality <= 5) {
1123+
1124+
if (centrality >= zero && centrality <= five) {
11211125
fillProfile(corrconfigs.at(0), bootstrapArray[sampleIndex][kc22Nch05], nch);
11221126
fillProfile(corrconfigs.at(1), bootstrapArray[sampleIndex][kc24Nch05], nch);
11231127
fillProfile(corrconfigs.at(2), bootstrapArray[sampleIndex][kc26Nch05], nch);
@@ -1193,7 +1197,8 @@ struct FlowGfwTask {
11931197
registry.fill(HIST("hCenMCRec"), centrality);
11941198
registry.fill(HIST("hPtNchMCRec"), track.pt(), track.size());
11951199

1196-
if (centrality >= 0 && centrality <= 5) {
1200+
float zero=0, five=5;
1201+
if (centrality >= zero && centrality <= five) {
11971202
registry.fill(HIST("hPtMCRec05"), track.pt());
11981203
registry.fill(HIST("hCenMCRec05"), centrality);
11991204
registry.fill(HIST("hPtNchMCRec05"), track.pt(), track.size());
@@ -1257,7 +1262,8 @@ struct FlowGfwTask {
12571262
registry.fill(HIST("hPtMCGen"), particle.pt());
12581263
registry.fill(HIST("hCenMCGen"), centrality);
12591264

1260-
if (centrality >= 0 && centrality <= 5) {
1265+
float zero=0, five=5;
1266+
if (centrality >= zero && centrality <= five) {
12611267
registry.fill(HIST("hPtMCGen05"), particle.pt());
12621268
registry.fill(HIST("hCenMCGen05"), centrality);
12631269
registry.fill(HIST("hPtNchMCGen05"), particle.pt(), numberOfTracks[0]);
@@ -1271,7 +1277,8 @@ struct FlowGfwTask {
12711277
for (const auto& track : groupedTracksReco) {
12721278

12731279
registry.fill(HIST("hCorr"), numberOfTracks[0], track.size());
1274-
if (centrality >= 0 && centrality <= 5) {
1280+
float zero=0, five=5;
1281+
if (centrality >= zero && centrality <= five) {
12751282
registry.fill(HIST("hCorr05"), numberOfTracks[0], track.size());
12761283
}
12771284
}

0 commit comments

Comments
 (0)