Refactor CCDB URL handling in populateCCDBWithCommitAvailability

njacazio · web-flow · commit 4c754650d260 · 2025-10-11T13:08:04.000+02:00
diff --git a/Common/Core/macros/testMetadataHelper.C b/Common/Core/macros/testMetadataHelper.C
@@ -120,13 +120,13 @@ std::map<std::string, bool> buildMapForCommitHash(const std::string& hash)
 }
 
 void populateCCDBWithCommitAvailability(std::map<string, bool> hasHashMap,
-                                        const std::string commitHash)
+                                        const std::string commitHash const std::string ccdbUrl = "http://ccdb-test.cern.ch:8080/")
 {
   // First, init the CCDB manager to test if the ccdb is already populated
   o2::ccdb::CcdbApi api;
-  api.init("http://ccdb-test.cern.ch:8080/");
+  api.init(ccdbUrl);
   if (!api.isHostReachable()) {
-    LOG(fatal) << "CCDB host http://ccdb-test.cern.ch:8080/ is not reacheable, cannot go forward";
+    LOG(fatal) << "CCDB host " << ccdbUrl << " is not reacheable, cannot go forward";
   }
   for (const auto& entry : hasHashMap) {
     if (!entry.second) { // Version of the code does not have the hash

Original file line number	Diff line number	Diff line change
`@@ -120,13 +120,13 @@ std::map<std::string, bool> buildMapForCommitHash(const std::string& hash)`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`void populateCCDBWithCommitAvailability(std::map<string, bool> hasHashMap,`
`123`		`- const std::string commitHash)`
	`123`	`+ const std::string commitHash const std::string ccdbUrl = "http://ccdb-test.cern.ch:8080/")`
`124`	`124`	`{`
`125`	`125`	`// First, init the CCDB manager to test if the ccdb is already populated`
`126`	`126`	`o2::ccdb::CcdbApi api;`
`127`		`- api.init("http://ccdb-test.cern.ch:8080/");`
	`127`	`+ api.init(ccdbUrl);`
`128`	`128`	`if (!api.isHostReachable()) {`
`129`		`- LOG(fatal) << "CCDB host http://ccdb-test.cern.ch:8080/ is not reacheable, cannot go forward";`
	`129`	`+ LOG(fatal) << "CCDB host " << ccdbUrl << " is not reacheable, cannot go forward";`
`130`	`130`	`}`
`131`	`131`	`for (const auto& entry : hasHashMap) {`
`132`	`132`	`if (!entry.second) { // Version of the code does not have the hash`