Skip to content

Commit 25a1615

Browse files
minjungkim12claude
andcommitted
[PWGHF] Remove useless gapTypeToInt function and fix unused parameter warnings
- Remove gapTypeToInt pass-through function from utilsUpcHf.h - Replace hf_upc::gapTypeToInt(gap) calls with gap directly in taskD0 and taskDplus - Add /*tracks*/ comment to suppress unused parameter warnings in UPC process functions The gapTypeToInt function was a no-op that simply returned its input unchanged. As noted by @vkucera, this function serves no purpose since gap is already an int. 🤖 Generated with Claude Code (https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent b2ba951 commit 25a1615

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

PWGHF/D2H/Tasks/taskD0.cxx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -611,11 +611,10 @@ struct HfTaskD0 {
611611
if (hasZdc) {
612612
registry.fill(HIST("Data/fitInfo/ampFT0A_vs_ampFT0C"), fitInfo.ampFT0A, fitInfo.ampFT0C);
613613
registry.fill(HIST("Data/zdc/energyZNA_vs_energyZNC"), zdcEnergyZNA, zdcEnergyZNC);
614-
registry.fill(HIST("Data/hUpcGapAfterSelection"), hf_upc::gapTypeToInt(gap));
614+
registry.fill(HIST("Data/hUpcGapAfterSelection"), gap);
615615
}
616616

617617
if (hf_upc::isSingleSidedGap(gap)) {
618-
const int gapTypeInt = hf_upc::gapTypeToInt(gap);
619618
const auto thisCollId = collision.globalIndex();
620619
const auto& groupedD0Candidates = candidates.sliceBy(candD0PerCollision, thisCollId);
621620

@@ -676,7 +675,7 @@ struct HfTaskD0 {
676675
valuesToFill.push_back(occ);
677676
valuesToFill.push_back(ir);
678677
}
679-
valuesToFill.push_back(static_cast<double>(gapTypeInt));
678+
valuesToFill.push_back(static_cast<double>(gap));
680679
valuesToFill.push_back(static_cast<double>(fitInfo.ampFT0A));
681680
valuesToFill.push_back(static_cast<double>(fitInfo.ampFT0C));
682681
valuesToFill.push_back(static_cast<double>(fitInfo.ampFV0A));
@@ -1170,7 +1169,7 @@ struct HfTaskD0 {
11701169
void processDataWithDCAFitterNWithUpc(soa::Join<aod::Collisions, aod::EvSels> const& collisions,
11711170
aod::BcFullInfos const& bcs,
11721171
D0Candidates const&,
1173-
aod::TracksWExtra const& tracks,
1172+
aod::TracksWExtra const& /*tracks*/,
11741173
aod::FT0s const& ft0s,
11751174
aod::FV0As const& fv0as,
11761175
aod::FDDs const& fdds,
@@ -1183,7 +1182,7 @@ struct HfTaskD0 {
11831182
void processDataWithDCAFitterNMlWithUpc(soa::Join<aod::Collisions, aod::EvSels> const& collisions,
11841183
aod::BcFullInfos const& bcs,
11851184
D0CandidatesMl const&,
1186-
aod::TracksWExtra const& tracks,
1185+
aod::TracksWExtra const& /*tracks*/,
11871186
aod::FT0s const& ft0s,
11881187
aod::FV0As const& fv0as,
11891188
aod::FDDs const& fdds,

PWGHF/D2H/Tasks/taskDplus.cxx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -748,11 +748,10 @@ struct HfTaskDplus {
748748
if (hasZdc) {
749749
registry.fill(HIST("Data/fitInfo/ampFT0A_vs_ampFT0C"), fitInfo.ampFT0A, fitInfo.ampFT0C);
750750
registry.fill(HIST("Data/zdc/energyZNA_vs_energyZNC"), zdcEnergyZNA, zdcEnergyZNC);
751-
registry.fill(HIST("Data/hUpcGapAfterSelection"), hf_upc::gapTypeToInt(gap));
751+
registry.fill(HIST("Data/hUpcGapAfterSelection"), gap);
752752
}
753753

754754
if (hf_upc::isSingleSidedGap(gap)) {
755-
const int gapTypeInt = hf_upc::gapTypeToInt(gap);
756755
const auto thisCollId = collision.globalIndex();
757756
const auto& groupedDplusCandidates = candidates.sliceBy(candDplusPerCollision, thisCollId);
758757

@@ -800,7 +799,7 @@ struct HfTaskDplus {
800799
if (storeIR) {
801800
valuesToFill.push_back(ir);
802801
}
803-
valuesToFill.push_back(static_cast<double>(gapTypeInt));
802+
valuesToFill.push_back(static_cast<double>(gap));
804803
valuesToFill.push_back(static_cast<double>(fitInfo.ampFT0A));
805804
valuesToFill.push_back(static_cast<double>(fitInfo.ampFT0C));
806805
valuesToFill.push_back(static_cast<double>(fitInfo.ampFV0A));

PWGHF/Utils/utilsUpcHf.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -145,15 +145,6 @@ constexpr const char* getGapTypeName(int gap) noexcept
145145
}
146146
}
147147

148-
/// \brief Convert gap type to integer for histogram filling
149-
/// \param gap TrueGap enum value
150-
/// \return Integer representation (-1, 0, 1, 2, 3, 4, 5)
151-
/// \note This is a pass-through function for consistency with other utility functions
152-
constexpr int gapTypeToInt(int gap) noexcept
153-
{
154-
return gap;
155-
}
156-
157148
} // namespace o2::analysis::hf_upc
158149

159150
#endif // PWGHF_UTILS_UTILSUPCHF_H_

0 commit comments

Comments
 (0)