[PWGJE] adding rct selections for full jets #22333
nzardoshAnnotations
10 errors and 2 notices
|
O2 linter result
Issues have been found.
|
|
[name/workflow-file]:
PWGJE/TableProducer/derivedDataSelector.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
[name/o2-task]:
PWGJE/TableProducer/derivedDataSelector.cxx#L1
Specify task name only when it cannot be derived from the struct name. Only append to the default name.
|
|
[name/o2-task]:
PWGJE/TableProducer/derivedDataSelector.cxx#L501
Device names jet-deriveddata-selector and jet-derived-data-selector generated from the specified task name jet-deriveddata-selector and from the struct name JetDerivedDataSelector, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to JetDeriveddataSelector and removing TaskName.
|
|
[const-ref-in-for-loop]:
PWGJE/TableProducer/derivedDataSelector.cxx#L157
Use constant references for non-modified iterators in range-based for loops.
|
|
[const-ref-in-for-loop]:
PWGJE/TableProducer/derivedDataSelector.cxx#L155
Use constant references for non-modified iterators in range-based for loops.
|
|
[name/configurable]:
PWGJE/JetFinders/jetFinder.h#L107
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/configurable]:
PWGJE/JetFinders/jetFinder.h#L82
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[magic-number]:
PWGJE/JetFinders/jetFinder.h#L168
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGJE/JetFinders/jetFinder.h#L134
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|