[PWGEM/Dilepton] add flexbility to keep events with minNlepton #20972
dsekihatAnnotations
10 errors and 2 notices
|
[magic-number]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx#L415
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx#L363
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx#L275
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx#L227
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx#L224
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[pdg/explicit-code]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx#L275
Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
|
|
[name/workflow-file]:
PWGEM/Dilepton/TableProducer/filterEoI.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
[name/o2-task]:
PWGEM/Dilepton/TableProducer/filterEoI.cxx#L1
Specify task name only when it cannot be derived from the struct name. Only append to the default name.
|
|
[name/o2-task]:
PWGEM/Dilepton/TableProducer/filterEoI.cxx#L180
Device names filter-eoi and filter-eo-i generated from the specified task name filter-eoi and from the struct name filterEoI, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to FilterEoi and removing TaskName.
|
|
[magic-number]:
PWGEM/Dilepton/TableProducer/filterEoI.cxx#L103
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|