[PWGJE,PWGLF,Trigger] Improvements to the JE framework #20351
nzardoshAnnotations
11 errors and 2 notices
|
[const-ref-in-for-loop]:
PWGJE/Core/JetDerivedDataUtilities.h#L70
Use constant references for non-modified iterators in range-based for loops.
|
|
[pdg/explicit-mass]:
PWGJE/Core/JetDerivedDataUtilities.h#L36
Avoid hard-coded particle masses. Use o2::constants::physics::Mass... instead.
|
|
[std-prefix]:
PWGJE/Core/JetDerivedDataUtilities.h#L651
Use std:: prefix for names from the std namespace.
|
|
[const-ref-in-for-loop]:
PWGJE/Core/JetCandidateUtilities.h#L148
Use constant references for non-modified iterators in range-based for loops.
|
|
[const-ref-in-for-loop]:
PWGJE/Core/JetBkgSubUtils.cxx#L166
Use constant references for non-modified iterators in range-based for loops.
|
|
[const-ref-in-for-loop]:
PWGJE/Core/JetBkgSubUtils.cxx#L76
Use constant references for non-modified iterators in range-based for loops.
|
|
[name/configurable]:
EventFiltering/PWGJE/jetFilter.cxx#L71
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/configurable]:
EventFiltering/PWGJE/jetFilter.cxx#L70
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/workflow-file]:
EventFiltering/PWGJE/jetFilter.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
[magic-number]:
EventFiltering/PWGJE/jetFilter.cxx#L222
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
O2 linter
Canceling since a higher priority waiting request for O2 linter-13782 exists
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|