[PWGCF,PWGLF,Trigger] Clean PIDResponse in EventFiltering #19873
njacazioAnnotations
10 errors and 2 notices
|
[magic-number]:
EventFiltering/PWGLF/filterdoublephi.cxx#L159
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGLF/filterdoublephi.cxx#L154
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGLF/filterdoublephi.cxx#L151
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGLF/filterdoublephi.cxx#L139
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGLF/filterdoublephi.cxx#L138
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGLF/filterdoublephi.cxx#L135
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[const-ref-in-for-loop]:
EventFiltering/PWGLF/filterdoublephi.cxx#L218
Use constant references for non-modified iterators in range-based for loops.
|
|
[const-ref-in-for-loop]:
EventFiltering/PWGLF/filterdoublephi.cxx#L197
Use constant references for non-modified iterators in range-based for loops.
|
|
[pdg/database]:
EventFiltering/PWGLF/filterdoublephi.cxx#L42
Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.
|
|
[include-iostream]:
EventFiltering/PWGLF/filterdoublephi.cxx#L48
Do not include iostream. Use O2 logging instead.
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|