[PWGHF,Trigger] Fix redundant copies, useless conditions, variable scope #19262
vkuceraAnnotations
10 errors and 2 notices
|
[magic-number]:
EventFiltering/PWGHF/HFFilterHelpers.h#L862
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[pdg/explicit-mass]:
EventFiltering/PWGHF/HFFilterHelpers.h#L296
Avoid hard-coded particle masses. Use o2::constants::physics::Mass... instead.
|
|
[name/configurable]:
EventFiltering/PWGHF/HFFilter.cxx#L160
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/workflow-file]:
EventFiltering/PWGHF/HFFilter.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L1789
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L1467
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L1240
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L521
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L442
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L311
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|