[PWGHF] Cleanup and bug fixes using cppcheck and clang-tidy #18399
vkuceraAnnotations
10 errors and 2 notices
|
[magic-number]:
PWGHF/HFC/Macros/DhCorrelationExtraction.cxx#L186
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[pi-multiple-fraction]:
PWGHF/HFC/Macros/DhCorrelationExtraction.cxx#L1315
Use multiples/fractions of PI defined in o2::constants::math.
|
|
[include-iostream]:
PWGHF/HFC/Macros/DhCorrelationExtraction.cxx#L37
Do not include iostream. Use O2 logging instead.
|
|
[pwghf/struct-member-order]:
PWGHF/D2H/Tasks/taskSigmacToCascade.cxx#L1
Declare struct members in the conventional order. See the PWGHF coding guidelines.
|
|
[pwghf/struct-member-order]:
PWGHF/D2H/Tasks/taskSigmacToCascade.cxx#L48
HfTaskSigmacToCascade: ConfigurableAxis appears too early (before end of Filter).
|
|
[pwghf/struct-member-order]:
PWGHF/D2H/Tasks/taskSigmacToCascade.cxx#L59
HfTaskSigmacToCascade: Filter appears too early (before end of using).
|
|
[pwghf/struct-member-order]:
PWGHF/D2H/Tasks/taskSigmacToCascade.cxx#L62
HfTaskSigmacToCascade: using appears too early (before end of HfHelper).
|
|
[name/configurable]:
PWGHF/D2H/Tasks/taskSigmacToCascade.cxx#L55
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[magic-number]:
PWGHF/D2H/Tasks/taskSigmacToCascade.cxx#L186
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGHF/D2H/Tasks/taskSigmacToCascade.cxx#L156
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|