[PWGEM/PhotonMeson,PWGJE/EMCal] Add event selection cuts to omega and mcgenerator studies #15347
nstrangmAnnotations
10 errors and 2 notices
|
[const-ref-in-for-loop]:
PWGJE/Tasks/mcGeneratorStudies.cxx#L158
Use constant references for non-modified iterators in range-based for loops.
|
|
[const-ref-in-for-loop]:
PWGJE/Tasks/mcGeneratorStudies.cxx#L154
Use constant references for non-modified iterators in range-based for loops.
|
|
[pdg/explicit-code]:
PWGJE/Tasks/mcGeneratorStudies.cxx#L246
Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
|
|
[pdg/explicit-code]:
PWGJE/Tasks/mcGeneratorStudies.cxx#L233
Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
|
|
[pdg/database]:
PWGJE/Tasks/mcGeneratorStudies.cxx#L188
Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.
|
|
[pdg/database]:
PWGJE/Tasks/mcGeneratorStudies.cxx#L161
Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.
|
|
[pdg/database]:
PWGJE/Tasks/mcGeneratorStudies.cxx#L33
Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.
|
|
[name/o2-task]:
PWGEM/PhotonMeson/Tasks/OmegaMesonEMC.cxx#L1
Specify task name only when it cannot be derived from the struct name. Only append to the default name.
|
|
[name/o2-task]:
PWGEM/PhotonMeson/Tasks/OmegaMesonEMC.cxx#L351
Device names omega-meson-emc and omega-meson-e-m-c generated from the specified task name omega-meson-emc and from the struct name OmegaMesonEMC, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to OmegaMesonEmc and removing TaskName.
|
|
[name/file-cpp]:
PWGEM/PhotonMeson/Tasks/OmegaMesonEMC.cxx#L1
Use lowerCamelCase or UpperCamelCase for names of C++ files. See the O2 naming conventions for details.
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|