Skip to content

[Common] Fix bugs found by cppcheck and cpplint #10323

[Common] Fix bugs found by cppcheck and cpplint

[Common] Fix bugs found by cppcheck and cpplint #10323

Triggered via pull request May 22, 2025 14:10
@vkuceravkucera
opened #11310
Status Failure
Total duration 19s
Artifacts

o2-linter.yml

on: pull_request_target
O2 linter
12s
O2 linter
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 notices
[doc/file]: Common/Tasks/trackqa.cxx#L1
Provide mandatory file documentation.
[doc/file]: Common/Tasks/trackqa.cxx#L11
Documentation for \author is missing, incorrect or misplaced.
[doc/file]: Common/Tasks/trackqa.cxx#L11
Documentation for \brief is missing, incorrect or misplaced.
[doc/file]: Common/Tasks/trackqa.cxx#L11
Documentation for \file is missing, incorrect or misplaced.
[magic-number]: Common/Tasks/trackqa.cxx#L119
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
[magic-number]: Common/Tasks/trackqa.cxx#L107
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
[o2-workflow-options]: Common/Tasks/trackqa.cxx#L1
Do not use workflow options to customise workflow topology composition in defineDataProcessing. Use process function switches or metadata instead.
[pi-multiple-fraction]: Common/Tasks/trackqa.cxx#L60
Use multiples/fractions of PI defined in o2::constants::math.
[external-pi]: Common/Tasks/trackqa.cxx#L66
Use the PI constant (and its multiples and fractions) defined in o2::constants::math.
[external-pi]: Common/Tasks/trackqa.cxx#L60
Use the PI constant (and its multiples and fractions) defined in o2::constants::math.
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.