O2 linter

[PWGLF] Fix bug related to daughter index #8727

Sign in to view logs

Triggered via pull request April 23, 2025 16:08

skundu692

opened #10960

skundu692:doublephi23042025

Status Failure

Total duration 12s

Artifacts –

o2-linter.yml

on: pull_request

Annotations

2 errors, 10 warnings, and 1 notice

Process completed with exit code 1.

O2 linter result

Issues have been found.

[magic-number]: EventFiltering/PWGLF/filterdoublephi.cxx#L134

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGLF/filterdoublephi.cxx#L133

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGLF/filterdoublephi.cxx#L130

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[const-ref-in-for-loop]: EventFiltering/PWGLF/filterdoublephi.cxx#L210

Use constant references for non-modified iterators in range-based for loops.

[const-ref-in-for-loop]: EventFiltering/PWGLF/filterdoublephi.cxx#L189

Use constant references for non-modified iterators in range-based for loops.

[pdg/database]: EventFiltering/PWGLF/filterdoublephi.cxx#L22

Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.

[root/entity]: EventFiltering/PWGLF/filterdoublephi.cxx#L167

Replace ROOT entities with equivalents from standard C++ or from O2.

[root/entity]: EventFiltering/PWGLF/filterdoublephi.cxx#L150

Replace ROOT entities with equivalents from standard C++ or from O2.

[root/entity]: EventFiltering/PWGLF/filterdoublephi.cxx#L137

Replace ROOT entities with equivalents from standard C++ or from O2.

[include-iostream]: EventFiltering/PWGLF/filterdoublephi.cxx#L25

Do not include iostream. Use O2 logging instead.

Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.