O2 linter

[PWGHF,Trigger] Separate proton pt threshold for LcRes and ThetaC #8689

Sign in to view logs

Triggered via pull request April 23, 2025 11:20

apalasciano

synchronize #10947

apalasciano:LcRes

Status Failure

Total duration 12s

Artifacts –

o2-linter.yml

on: pull_request

Annotations

2 errors, 10 warnings, and 1 notice

Process completed with exit code 1.

O2 linter result

Issues have been found.

[pwghf/struct-member-order]: EventFiltering/PWGHF/HFFilter.cxx#L170

HfFilter: HistogramRegistry appears too early (before end of PresliceUnsorted<).

[pwghf/struct-member-order]: EventFiltering/PWGHF/HFFilter.cxx#L139

HfFilter: Service< appears too early (before end of Configurable<).

[name/configurable]: EventFiltering/PWGHF/HFFilter.cxx#L140

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)

[name/workflow-file]: EventFiltering/PWGHF/HFFilter.cxx#L0

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L1739

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L1417

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L1190

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L471

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L392

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L245

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.