O2 linter

[PWGHF] Add tagging of D* -> D0 pi -> K pi pi pi0 at gen level #8003

Sign in to view logs

Triggered via pull request April 9, 2025 08:30

fgrosa

synchronize #10793

fgrosa:dstar

Status Failure

Total duration 15s

Artifacts –

o2-linter.yml

on: pull_request

Annotations

2 errors, 10 warnings, and 1 notice

Process completed with exit code 1.

O2 linter result

Issues have been found.

[name/configurable]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L138

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)

[name/workflow-file]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L0

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

[magic-number]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L1621

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L1278

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L1244

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L1098

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L1000

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L996

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[pdg/explicit-code]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L1621

Avoid using hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.

[pdg/explicit-code]: PWGHF/D2H/Tasks/taskCharmPolarisation.cxx#L1098

Avoid using hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.

Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.