add protections and exit in case of missing parameters, remove defaul… (#62)

* add protections and exit in case of missing parameters, remove default value of generator

* add explicit setting of signal generator, since embedding test change energy to 5 TeV, add possiblity to change pythia process

Author: gconesab

MC/bin/o2dpg_sim_workflow.py

@@ -25,7 +25,7 @@
 parser = argparse.ArgumentParser(description='Create an ALICE (Run3) MC simulation workflow')
 
 parser.add_argument('-ns',help='number of signal events / timeframe', default=20)
-parser.add_argument('-gen',help='generator: pythia8, extgen', default='pythia8')
+parser.add_argument('-gen',help='generator: pythia8, extgen', default='')
 parser.add_argument('-proc',help='process type: dirgamma, jets, ccbar', default='')
 parser.add_argument('-trigger',help='event selection: particle, external', default='')
 parser.add_argument('-ini',help='generator init parameters file, for example: ${O2DPG_ROOT}/MC/config/PWGHF/ini/GeneratorHF.ini', default='')
@@ -47,9 +47,9 @@
 
 parser.add_argument('--embedding',action='store_true', help='With embedding into background')
 parser.add_argument('-nb',help='number of background events / timeframe', default=20)
-parser.add_argument('-genBkg',help='generator', default='pythia8hi')
-parser.add_argument('-iniBkg',help='generator init parameters file', default='${O2DPG_ROOT}/MC/config/common/ini/basic.ini')
-parser.add_argument('-colBkg',help='collision system: collision type of bkg in case of embedding', default='PbPb')
+parser.add_argument('-genBkg',help='embedding background generator', default='pythia8hi')
+parser.add_argument('-iniBkg',help='embedding background generator init parameters file', default='${O2DPG_ROOT}/MC/config/common/ini/basic.ini')
+parser.add_argument('-colBkg',help='embedding background collision system', default='PbPb')
 
 parser.add_argument('-e',help='simengine', default='TGeant4')
 parser.add_argument('-tf',help='number of timeframes', default=2)
@@ -115,6 +115,10 @@ def getDPL_global_options(bigshm=False,nosmallrate=False):
         # ---- do background transport task -------
         NBKGEVENTS=args.nb
         GENBKG=args.genBkg
+        if GENBKG =='':
+           print('o2dpg_sim_workflow: Error! embedding background generator name not provided')
+           exit(1)
+
         INIBKG=args.iniBkg
         BKGtask=createTask(name='bkgsim', lab=["GEANT"], cpu='8')
         BKGtask['cmd']='o2-sim -e ' + SIMENGINE + ' -j ' + str(NWORKERS) + ' -n ' + str(NBKGEVENTS) + ' -g  ' + str(GENBKG) + ' ' + str(MODULES) + ' -o bkg --configFile ' + str(INIBKG)
@@ -175,6 +179,10 @@ def getDPL_global_options(bigshm=False,nosmallrate=False):
    EBEAMB=float(args.eB)
    NSIGEVENTS=args.ns
    GENERATOR=args.gen
+   if GENERATOR =='':
+      print('o2dpg_sim_workflow: Error! generator name not provided')
+      exit(1)
+
    INIFILE=''
    if args.ini!= '':
       INIFILE=' --configFile ' + args.ini
@@ -272,7 +280,7 @@ def getDPL_global_options(bigshm=False,nosmallrate=False):
    # produce the signal configuration
    SGN_CONFIG_task=createTask(name='gensgnconf_'+str(tf), tf=tf, cwd=timeframeworkdir)
    SGN_CONFIG_task['cmd'] = 'echo "placeholder / dummy task"'
-   if GENERATOR == 'pythia8':
+   if GENERATOR == 'pythia8' and PROCESS!='':
       SGN_CONFIG_task['cmd'] = '${O2DPG_ROOT}/MC/config/common/pythia8/utils/mkpy8cfg.py \
                                 --output=pythia8.cfg                                     \
 	                        --seed='+str(RNDSEED)+'                                  \
@@ -292,6 +300,10 @@ def getDPL_global_options(bigshm=False,nosmallrate=False):
        # NOTE: Generator setup might be handled in a different file or different files (one per
        # possible generator)
 
+   if CONFKEY=='':
+      print('o2dpg_sim_workflow: Error! configuration file not provided')
+      exit(1)
+
    workflow['stages'].append(SGN_CONFIG_task)
 
    # -----------------

MC/run/PWGHF/embedding_benchmark.sh

@@ -21,9 +21,10 @@ NWORKERS=${NWORKERS:-8}
 NBKGEVENTS=${NBKGEVENTS:-20}
 MODULES="--skipModules ZDC"
 SIMENGINE=${SIMENGINE:-TGeant4}
+PYPROCESS=${PYPROCESS:-ccbar} #ccbar, bbar, ...
 
 # create workflow
-${O2DPG_ROOT}/MC/bin/o2dpg_sim_workflow.py -eCM 13000 -col pp -proc ccbar -tf ${NTIMEFRAMES} -nb ${NBKGEVENTS} \
+${O2DPG_ROOT}/MC/bin/o2dpg_sim_workflow.py -eCM 5020 -col pp -gen pythia8 -proc ${PYPROCESS} -tf ${NTIMEFRAMES} -nb ${NBKGEVENTS} \
                                                         -ns ${NSIGEVENTS} -e ${SIMENGINE}    \
                                                         -j ${NWORKERS} --embedding -interactionRate 50000