Skip to content

Commit cc2d037

Browse files
committed
[MCH] improvements to the pedestal calibrator
Added few options to the MCH pedestal calibration aggregator script: - configurable number of threads for the aggregator task - configurable logging interval - option to disable the final upload of the CCDB objects (for testing purposes)
1 parent 889a725 commit cc2d037

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

DATA/production/calib/mch-badchannel-aggregator.sh

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,25 @@ MCH_MAX_NOISE=${MCH_MAX_NOISE:-2.0}
1515
MCH_MIN_ENTRIES=${MCH_MIN_ENTRIES:-100}
1616
MCH_MIN_FRACTION=${MCH_MIN_FRACTION:-0.5}
1717
MCH_END_OF_STREAM_ONLY=${MCH_END_OF_STREAM_ONLY:-true}
18-
BADCHANNEL_CONFIG="${ARGS_ALL_CONFIG};MCHBadChannelCalibratorParam.maxPed=${MCH_MAX_PEDESTAL};MCHBadChannelCalibratorParam.maxNoise=${MCH_MAX_NOISE};MCHBadChannelCalibratorParam.minRequiredNofEntriesPerChannel=${MCH_MIN_ENTRIES};MCHBadChannelCalibratorParam.minRequiredCalibratedFraction=${MCH_MIN_FRACTION};MCHBadChannelCalibratorParam.onlyAtEndOfStream=${MCH_END_OF_STREAM_ONLY}"
18+
BADCHANNEL_CONFIG="${ARGS_ALL_CONFIG};MCHBadChannelCalibratorParam.maxPed=${MCH_MAX_PEDESTAL};MCHBadChannelCalibratorParam.maxNoise=${MCH_MAX_NOISE};MCHBadChannelCalibratorParam.minRequiredNofEntriesPerChannel=${MCH_MIN_ENTRIES};MCHBadChannelCalibratorParam.minRequiredCalibratedFraction=${MCH_MIN_FRACTION};MCHBadChannelCalibratorParam.onlyAtEndOfStream=${MCH_END_OF_STREAM_ONLY};"
19+
20+
if [ -n "${MCH_NTHREADS}" ]; then
21+
BADCHANNEL_CONFIG+="MCHBadChannelCalibratorParam.nThreads=${MCH_NTHREADS};"
22+
fi
23+
24+
MCH_LOGGING_OPT=
25+
if [ -n "${MCH_LOGGING_INTERVAL}" ]; then
26+
MCH_LOGGING_OPT="--logging-interval ${MCH_LOGGING_INTERVAL}"
27+
fi
1928

2029
WORKFLOW="o2-dpl-raw-proxy $ARGS_ALL --proxy-name mch-badchannel-input-proxy --dataspec \"$PROXY_INSPEC\" --network-interface ib0 --channel-config \"name=mch-badchannel-input-proxy,method=bind,type=pull,rateLogging=0,transport=zeromq\" | "
21-
WORKFLOW+="o2-calibration-mch-badchannel-calib-workflow $ARGS_ALL --configKeyValues \"$BADCHANNEL_CONFIG\" | "
22-
WORKFLOW+="o2-calibration-ccdb-populator-workflow $ARGS_ALL --configKeyValues \"$ARGS_ALL_CONFIG\" --ccdb-path=\"http://o2-ccdb.internal\" --sspec-min 0 --sspec-max 0 | "
23-
WORKFLOW+="o2-calibration-ccdb-populator-workflow $ARGS_ALL --configKeyValues \"$ARGS_ALL_CONFIG\" --ccdb-path=\"$DCSCCDBSERVER_PERS\" --sspec-min 1 --sspec-max 1 --name-extention dcs | "
30+
WORKFLOW+="o2-calibration-mch-badchannel-calib-workflow $ARGS_ALL --configKeyValues \"$BADCHANNEL_CONFIG\" ${MCH_LOGGING_OPT} | "
31+
32+
if [ -z "${MCH_SKIP_CCDB_UPLOAD}" ]; then
33+
WORKFLOW+="o2-calibration-ccdb-populator-workflow $ARGS_ALL --configKeyValues \"$ARGS_ALL_CONFIG\" --ccdb-path=\"http://o2-ccdb.internal\" --sspec-min 0 --sspec-max 0 | "
34+
WORKFLOW+="o2-calibration-ccdb-populator-workflow $ARGS_ALL --configKeyValues \"$ARGS_ALL_CONFIG\" --ccdb-path=\"$DCSCCDBSERVER_PERS\" --sspec-min 1 --sspec-max 1 --name-extention dcs | "
35+
fi
36+
2437
add_QC_from_consul "/o2/components/qc/ANY/any/mch-badchannel" ""
2538
WORKFLOW+="o2-dpl-run $ARGS_ALL $GLOBALDPLOPT"
2639

0 commit comments

Comments
 (0)