Skip to content

Commit 95651ca

Browse files
lmassacralcaliva
authored andcommitted
Fix for the MC aQC MCH+MFT task to avoid MID active cases (#1988)
1 parent 5c0c582 commit 95651ca

File tree

2 files changed

+8
-33
lines changed

2 files changed

+8
-33
lines changed

MC/bin/o2dpg_qc_finalization_workflow.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,10 @@ def add_QC_postprocessing(taskName, qcConfigPath, needs, runSpecific, prodSpecif
104104
add_QC_finalization('MCHTracksTaskQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/mch-tracks-task.json')
105105
if isActive('MCH') and isActive('MID'):
106106
add_QC_finalization('MCHMIDTracksTaskQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/mchmid-tracks-task.json')
107-
if isActive('MCH') and isActive('MFT'):
108-
add_QC_finalization('MCHMFTTaskQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/mftmch-tracks-task.json')
109107
if isActive('MCH') and isActive('MID') and isActive('MFT'):
110108
add_QC_finalization('MUONTracksMFTTaskQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/mftmchmid-tracks-task.json')
109+
elif isActive('MCH') and isActive('MFT'):
110+
add_QC_finalization('MCHMFTTaskQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/mftmch-tracks-task.json')
111111
if isActive('FT0') and isActive('TRD'):
112112
add_QC_finalization('tofft0PIDQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/pidft0tof.json')
113113
elif isActive('FT0'):

MC/bin/o2dpg_sim_workflow.py

Lines changed: 6 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1509,42 +1509,17 @@ def addQCPerTF(taskName, needs, readerCommand, configFilePath, objectsFile=''):
15091509
readerCommand='o2-global-track-cluster-reader --track-types "MCH,MID,MCH-MID" --cluster-types "MCH,MID"',
15101510
configFilePath='json://${O2DPG_ROOT}/MC/config/QC/json/mchmid-tracks-task.json')
15111511

1512-
1513-
### MCH && MFT
1514-
if isActive('MCH') and isActive('MFT') :
1515-
addQCPerTF(taskName='MCHMFTTaskQC',
1516-
needs=[MFTMCHMATCHtask['name']],
1517-
readerCommand='o2-global-track-cluster-reader --track-types "MCH,MFT,MFT-MCH" --cluster-types "MCH,MFT"',
1518-
configFilePath='json://${O2DPG_ROOT}/MC/config/QC/json/mftmch-tracks-task.json')
1519-
1520-
### MCH && MID && MFT
1512+
### MCH && MID && MFT || MCH && MFT
15211513
if isActive('MCH') and isActive('MID') and isActive('MFT') :
15221514
addQCPerTF(taskName='MUONTracksMFTTaskQC',
15231515
needs=[MFTMCHMATCHtask['name'], MCHMIDMATCHtask['name']],
15241516
readerCommand='o2-global-track-cluster-reader --track-types "MFT,MCH,MID,MCH-MID,MFT-MCH,MFT-MCH-MID" --cluster-types "MCH,MID,MFT"',
15251517
configFilePath='json://${O2DPG_ROOT}/MC/config/QC/json/mftmchmid-tracks-task.json')
1526-
1527-
#secondary vertexer
1528-
svfinder_threads = ' --threads 1 '
1529-
svfinder_cpu = 1
1530-
if COLTYPE == "PbPb" or (doembedding and COLTYPEBKG == "PbPb"):
1531-
svfinder_threads = ' --threads 8 '
1532-
svfinder_cpu = 8
1533-
SVFINDERtask = createTask(name='svfinder_'+str(tf), needs=[PVFINDERtask['name'], FT0FV0EMCCTPDIGItask['name']], tf=tf, cwd=timeframeworkdir, lab=["RECO"], cpu=svfinder_cpu, mem='5000')
1534-
SVFINDERtask = createTask(name='svfinder_'+str(tf), needs=[PVFINDERtask['name']], tf=tf, cwd=timeframeworkdir, lab=["RECO"], cpu=svfinder_cpu, mem='5000')
1535-
SVFINDERtask['cmd'] = '${O2_ROOT}/bin/o2-secondary-vertexing-workflow '
1536-
SVFINDERtask['cmd'] += getDPL_global_options(bigshm=True) + svfinder_threads + putConfigValuesNew(['svertexer', 'TPCCorrMap'], {"NameConf.mDirMatLUT" : ".."} | tpcLocalCFreco) \
1537-
+ tpc_corr_scaling_options + tpc_corr_options_mc
1538-
# Take None as default, we only add more if nothing from anchorConfig
1539-
svfinder_sources = anchorConfig.get('o2-secondary-vertexing-workflow-options', {}). get('vertexing-sources', 'ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,MFT-MCH,MCH-MID,ITS,MFT,TPC,TOF,FT0,MID,EMC,PHS,CPV,ZDC,FDD,HMP,FV0,TRD,MCH,CTP')
1540-
SVFINDERtask['cmd'] += ' --vertexing-sources ' + svfinder_sources + (' --combine-source-devices','')[args.no_combine_dpl_devices]
1541-
# strangeness tracking is now called from the secondary vertexer
1542-
if args.no_strangeness_tracking:
1543-
SVFINDERtask['cmd'] += ' --disable-strangeness-tracker'
1544-
# if enabled, it may require MC labels
1545-
else:
1546-
SVFINDERtask['cmd'] += ('',' --disable-mc')[args.no_mc_labels]
1547-
workflow['stages'].append(SVFINDERtask)
1518+
elif isActive('MCH') and isActive('MFT') :
1519+
addQCPerTF(taskName='MCHMFTTaskQC',
1520+
needs=[MFTMCHMATCHtask['name']],
1521+
readerCommand='o2-global-track-cluster-reader --track-types "MCH,MFT,MFT-MCH" --cluster-types "MCH,MFT"',
1522+
configFilePath='json://${O2DPG_ROOT}/MC/config/QC/json/mftmch-tracks-task.json')
15481523

15491524
# -----------
15501525
# produce AOD

0 commit comments

Comments
 (0)