Skip to content

Commit 865341a

Browse files
committed
Propagate --nmin to odc-epn-topo
1 parent f2f0adf commit 865341a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

DATA/production/production.desc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
synchronous-workflow: "O2PDPSuite" reco,128,128,"GPU_NUM_MEM_REG_CALLBACKS=5 SYNCMODE=1 NUMAGPUIDS=1 NUMAID=0 SHMSIZE=64000000000 production/dpl-workflow.sh" reco,128,128,"GPU_NUM_MEM_REG_CALLBACKS=5 SYNCMODE=1 NUMAGPUIDS=1 NUMAID=1 SHMSIZE=64000000000 production/dpl-workflow.sh"
2-
synchronous-workflow-1numa: "O2PDPSuite" reco,128,128,"SYNCMODE=1 production/dpl-workflow.sh"
1+
synchronous-workflow: "O2PDPSuite" reco,128,126,"GPU_NUM_MEM_REG_CALLBACKS=5 SYNCMODE=1 NUMAGPUIDS=1 NUMAID=0 SHMSIZE=64000000000 production/dpl-workflow.sh" reco,128,126,"GPU_NUM_MEM_REG_CALLBACKS=5 SYNCMODE=1 NUMAGPUIDS=1 NUMAID=1 SHMSIZE=64000000000 production/dpl-workflow.sh"
2+
synchronous-workflow-1numa: "O2PDPSuite" reco,128,126,"SYNCMODE=1 production/dpl-workflow.sh"

DATA/tools/parse

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,9 @@ for line in f:
154154
filename = filename_xml
155155
if reco_num_nodes_override > 0:
156156
reconodes = reco_num_nodes_override
157+
reconodesmin = min(reconodes, reconodesmin)
157158
if 'RECO_MAX_FAIL_NODES_OVERRIDE' in os.environ and os.environ['RECO_MAX_FAIL_NODES_OVERRIDE'] != '':
158-
reconodesmin = max(1, reconodes - int(os.environ['RECO_NUM_NODES_OVERRIDE']))
159+
reconodesmin = max(1, reconodes - int(os.environ['RECO_MAX_FAIL_NODES_OVERRIDE']))
159160
if os.environ['WORKFLOWMODE'] == 'dds':
160161
if 'GEN_TOPO_ODC_EPN_TOPO_CMD' in os.environ:
161162
odccommand = os.environ['GEN_TOPO_ODC_EPN_TOPO_CMD']
@@ -180,14 +181,15 @@ for line in f:
180181
if len(recoworkflows):
181182
odccommand += ' --reco ' + ' '.join(recoworkflows)
182183
odccommand += ' --n ' + str(reconodes)
183-
# odccommand += ' --nmin ' + str(reconodesmin) # Currently disabled, since odc-epn-topo does not accept --nmin
184+
odccommand += ' --nmin ' + str(reconodesmin) # Currently disabled, since odc-epn-topo does not accept --nmin
184185
if len(calibworkflows):
185186
odccommand += ' --calib ' + ' '.join(calibworkflows)
186187
if 'GEN_TOPO_STDERR_LOGGING' in os.environ and int(os.environ['GEN_TOPO_STDERR_LOGGING']):
187188
odccommand += ' --mon tools/monitoring_workflows/epnstderrlog.xml'
188189
if args[1] != '':
189190
odccommand += ' --prependexe "module load ' + args[1] + ' 2>&1 ; "'
190191
odccommand += ' -o ' + sys.argv[3]
192+
print('Running ODC command', odccommand)
191193
if os.system(odccommand) != 0:
192194
print('\nError running odc: ', odccommand)
193195
raise

0 commit comments

Comments
 (0)