Skip to content

Commit 3d00fd2

Browse files
committed
TRD QC: Do not write tracklets
While studying file-access graphs in O2DPG MC, I noticed that trdtracklets.root get written twice: One from the digitizer workflow and once from the TRD-DIGI-QC task. This can corrupt the processing and is probably a bug. QC should only read digits/trdtracklets. The reason appears to be the use of `o2-trd-trap-sim` as the reader command for digits and tracklets. For now, the problem can probably be avoided by using `o2-trd-trap-sim --disable-root-output true`. However, this might still create new trdtracklets in memory which should not be needed as they have been previously created during digitization. So it would be good to just use a true `o2-trd-sim-artefacts-reader` workflow or similar in the future.
1 parent d0e1981 commit 3d00fd2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

MC/bin/o2dpg_sim_workflow.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1849,9 +1849,10 @@ def remove_json_prefix(path):
18491849
configFilePath='json://${O2DPG_ROOT}/MC/config/QC/json/tpc-qc-standard-direct.json')
18501850

18511851
### TRD
1852+
# TODO: check if the readerCommand also reperforms tracklet construction (which already done in digitization)
18521853
addQCPerTF(taskName='trdDigitsQC',
18531854
needs=[TRDDigitask['name']],
1854-
readerCommand='o2-trd-trap-sim',
1855+
readerCommand='o2-trd-trap-sim --disable-root-output true',
18551856
configFilePath='json://${O2DPG_ROOT}/MC/config/QC/json/trd-standalone-task.json')
18561857

18571858
addQCPerTF(taskName='trdTrackingQC',

0 commit comments

Comments
 (0)