Allow check_clang_tidy.py to be configured with tool; reenable unit test

Author: sawenzel

check_clang_tidy.py

@@ -50,12 +50,14 @@ def main():
   parser.add_argument('-resource-dir')
   parser.add_argument('input_file_name')
   parser.add_argument('check_name')
+  parser.add_argument('checktool', nargs='?', default="O2codecheck")
 
   args, extra_args = parser.parse_known_args()
 
   resource_dir = args.resource_dir
   input_file_name = args.input_file_name
   check_name = args.check_name
+  tool = args.checktool
 
   extension = '.cpp'
   if (input_file_name.endswith('.c')):
@@ -92,7 +94,7 @@ def main():
   original_file_name = temp_file_name + ".orig"
   write_file(original_file_name, cleaned_test)
 
-  args = ['O2codecheck', temp_file_name, '-fix', '--checks=-*,' + check_name] + \
+  args = [tool, temp_file_name, '-fix', '--checks=-*,' + check_name] + \
         clang_tidy_extra_args
   print('Running ' + repr(args) + '...')
 

test/CMakeLists.txt

@@ -1,6 +1,18 @@
 # testing if regex works correctly (has problem with gcc < 4.9)
 add_executable(testregex testregex.cpp)
 add_test(testregexcorrect testregex)
-#add_test(NAME aliceo2namespace COMMAND ${CMAKE_SOURCE_DIR}/check_clang_tidy.py ${CMAKE_SOURCE_DIR}/test/aliceO2-namespace-naming.cpp aliceO2-namespace-naming)
 
-# correctness testing of checks
+# we need the FileCheck program in order to execute the check_clang_tidy.py script
+find_program(LLVMFILECHECK FileCheck HINTS PATH)
+if (LLVMFILECHECK)
+
+# testing namespace naming checker
+  add_test(NAME aliceo2namespace COMMAND
+                ${CMAKE_SOURCE_DIR}/check_clang_tidy.py
+                ${CMAKE_SOURCE_DIR}/test/aliceO2-namespace-naming.cpp
+                aliceO2-namespace-naming ${CMAKE_BINARY_DIR}/tool/O2codecheck)
+
+else()
+  message(STATUS "FileCheck not found; disabling the check_clang_tidy unit tests\n")
+endif(LLVMFILECHECK)
+