Skip to content

Commit 9d89d83

Browse files
authored
[OCTRL-1064] GO_ERROR calls should never be critical
Having to handle a failed GO_ERROR transition is something we should avoid. An interrupted GO_ERROR means that we might not perform the complete procedure and miss e.g. calling some services/subsystems. With this change, the only known way of failing GO_ERROR is to try it in an inappropriate state, which can be ERROR (no point in transitioning from ERROR to ERROR) or DONE (too late, nothing to do).
1 parent 79a02e7 commit 9d89d83

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

workflows/readout-dataflow.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1946,7 +1946,7 @@ roles:
19461946
trigger: before_GO_ERROR
19471947
await: after_GO_ERROR-1
19481948
timeout: "{{ odc_goerror_timeout }}"
1949-
critical: true
1949+
critical: false
19501950
- name: reset
19511951
call:
19521952
func: odc.Reset()

0 commit comments

Comments
 (0)