Skip to content

Commit ab79ae5

Browse files
committed
No need to force ERROR when GO_ERROR succeeded
Probably due to a mostly harmless mistake, we would force an environment into ERROR state even when not needed, after a successful GO_ERROR. If very unlucky, this could cause some conflicts with following transitions towards environment destruction. This affects only GO_ERROR due to ODC going to ERROR, other cases are fine. I did not see this issue cause any troubles, I just accidentally stumbled upon it.
1 parent 7f18908 commit ab79ae5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

core/environment/manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -997,8 +997,8 @@ func (envs *Manager) handleIntegratedServiceEvent(evt event.IntegratedServiceEve
997997
WithField("partition", envId.String()).
998998
WithError(err).
999999
Error("environment GO_ERROR transition failed after ODC_PARTITION_STATE_CHANGE ERROR event")
1000+
env.setState("ERROR")
10001001
}
1001-
env.setState("ERROR")
10021002
}
10031003
}()
10041004
}

0 commit comments

Comments
 (0)