Skip to content

Commit 7bfb4cc

Browse files
Copilotknopers8
andcommitted
Address PR review comments on package documentation
Co-authored-by: knopers8 <14327588+knopers8@users.noreply.github.com>
1 parent 9a2a33f commit 7bfb4cc

File tree

19 files changed

+22
-24
lines changed

19 files changed

+22
-24
lines changed

apricot/local/service.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
* Intergovernmental Organization or submit itself to any jurisdiction.
2323
*/
2424

25-
// Package local implements a local filesystem backend for the configuration
26-
// service, providing file-based configuration storage and retrieval.
25+
// Package local implements a local configuration backend for the configuration
26+
// service, providing direct access to the backend storage without gRPC.
2727
package local
2828

2929
import (

apricot/remote/service.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
* Intergovernmental Organization or submit itself to any jurisdiction.
2323
*/
2424

25-
// Package remote implements a remote gRPC client backend for the configuration
26-
// service, providing access to remote configuration stores.
25+
// Package remote implements a remote configuration backend for the configuration
26+
// service, accessing configuration handled by a different application via gRPC.
2727
package remote
2828

2929
import (

common/event/topic/topic.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
* Intergovernmental Organization or submit itself to any jurisdiction.
2323
*/
2424

25-
// Package topic defines topic constants and types for the event system,
26-
// providing structured topic names for different event types.
25+
// Package topic defines constants and types for event system topics.
2726
package topic
2827

2928
type Topic string

common/event/writer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
*/
2424

2525
// Package event provides event publishing and streaming functionality for
26-
// O² Control components, supporting both Kafka and in-memory event systems.
26+
// O² Control components, supporting Kafka and dummy event writers.
2727
package event
2828

2929
import (

common/monitoring/monitoring.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
* Intergovernmental Organization or submit itself to any jurisdiction.
2323
*/
2424

25-
// Package monitoring provides monitoring and metrics collection functionality,
26-
// including HTTP endpoints for health checks and metrics publishing.
25+
// Package monitoring provides monitoring and metrics collection functionality
26+
// for O² Control components.
2727
package monitoring
2828

2929
import (

common/utils/uid/uid.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
* Intergovernmental Organization or submit itself to any jurisdiction.
2323
*/
2424

25-
// Package uid provides unique identifier generation functionality,
26-
// including machine-specific and time-based ID generation utilities.
25+
// Package uid provides unique identifier generation functionality.
2726
package uid
2827

2928
import (

core/config.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
* Intergovernmental Organization or submit itself to any jurisdiction.
2323
*/
2424

25-
// Package core implements the main AliECS core functionality including
26-
// the gRPC API server, environment management, and integration with various services.
2725
package core
2826

2927
import (

core/core.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
* Intergovernmental Organization or submit itself to any jurisdiction.
2323
*/
2424

25+
// Package core implements the main AliECS core functionality including
26+
// the gRPC API server, environment management, and integration with various services.
2527
package core
2628

2729
import (

core/integration/bookkeeping/plugin.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
//go:generate protoc --go_out=. --go_opt=paths=source_relative --go-grpc_opt=paths=source_relative --go-grpc_out=require_unimplemented_servers=false:. protos/run.proto
3232
//go:generate protoc --go_out=. --go_opt=paths=source_relative --go-grpc_opt=paths=source_relative --go-grpc_out=require_unimplemented_servers=false:. protos/lhcFill.proto
3333

34+
// Package bookkeeping provides integration with the ALICE Bookkeeping system
35+
// for tracking runs and retrieving LHC fill information.
3436
package bookkeeping
3537

3638
import (

core/integration/bookkeeping/utils.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
* Intergovernmental Organization or submit itself to any jurisdiction.
2323
*/
2424

25-
// Package bookkeeping provides integration with the ALICE Bookkeeping system
26-
// for tracking runs and retrieving LHC fill information.
2725
package bookkeeping
2826

2927
import (

0 commit comments

Comments
 (0)