Call ODC STOP only when the partition is in RUNNING

This allows us to stop a run on EPNs when GO_ERROR transition is performed by adding a corresponding hook.
As GO_ERROR can occur with any source state, we make sure to make a STOP call only if the partition is in RUNNING.

At the same time, we will not call ODC STOP when an environment is transitioned due to an ODC partition going into ERROR - a stop does not make sense then.

Additionally, the commit includes minor corrections to a few related logs.

Fixes OCTRL-1036

Author: knopers8

core/integration/odc/plugin.go

@@ -1434,33 +1434,54 @@ func (p *Plugin) CallStack(data interface{}) (stack map[string]interface{}) {
 			err          error
 		)
 
+		timeout := callable.AcquireTimeout(ODC_STOP_TIMEOUT, varStack, "Stop", envId)
+
+		ctx, cancel := context.WithTimeout(context.Background(), timeout)
+		defer cancel()
+
+		state, err := handleGetState(ctx, p.odcClient, envId)
+		if err != nil {
+			log.WithError(err).
+				WithField("level", infologger.IL_Support).
+				WithField("partition", envId).
+				WithField("call", "Stop").
+				Error("ODC error")
+			call.VarStack["__call_error_reason"] = err.Error()
+			call.VarStack["__call_error"] = callFailedStr
+			return
+		}
+		if state != "RUNNING" {
+			log.WithField("level", infologger.IL_Devel).
+				WithField("partition", envId).
+				WithField("call", "Stop").
+				Infof("ODC Stop attempted, but ODC partition is not in 'RUNNING', but '%s', skipping", state)
+			return
+		}
+
 		rn, ok := varStack["run_number"]
 		if !ok {
 			log.WithField("partition", envId).
-				WithField("call", "Start").
+				WithField("call", "Stop").
 				Warn("cannot acquire run number for ODC Stop")
 		}
 		runNumberu64, err = strconv.ParseUint(rn, 10, 32)
 		if err != nil {
 			log.WithField("partition", envId).
+				WithField("call", "Stop").
 				WithError(err).
 				Error("cannot acquire run number for ODC EOR")
 			runNumberu64 = 0
 		}
 		runEndTimeMs, ok := varStack["run_end_time_ms"]
 		if !ok {
 			log.WithField("partition", envId).
-				WithField("call", "Start").
+				WithField("call", "Stop").
 				Warn("cannot acquire run_end_time_ms")
 		}
 
 		arguments := make(map[string]string)
 		arguments["run_end_time_ms"] = runEndTimeMs
 
-		timeout := callable.AcquireTimeout(ODC_STOP_TIMEOUT, varStack, "Stop", envId)
-
-		ctx, cancel := context.WithTimeout(context.Background(), timeout)
-		defer cancel()
 		err = handleStop(ctx, p.odcClient, arguments, paddingTimeout, envId, runNumberu64, call)
 		if err != nil {
 			log.WithError(err).