fixup! [core] INVARIANT status introduced

Author: Michal Tichák

core/workflow/safestatus.go

@@ -95,6 +95,8 @@ func aggregateStatus(roles []Role) (status task.Status) {
 	return
 }
 
+// TODO: this function is prime candidate for refactoring. The reason being that it mostly ignores status argument
+// for merging, moreover it also does not use status of role from argument. Both of these behaivour are counter-intuitive.
 func (t *SafeStatus) merge(s task.Status, r Role) {
 	t.mu.Lock()
 	defer t.mu.Unlock()

core/workflow/safestatus_test.go

@@ -62,7 +62,7 @@ var _ = Describe("safe status merge", func() {
 		})
 	})
 
-	When("Aggregate role is merged with any status (except UNDEFINED) status", func() {
+	When("Empty aggregate role is merged with any status (except UNDEFINED) status", func() {
 		It("becomes UNDEFINED", func() {
 			ar := &aggregatorRole{roleBase: roleBase{status: SafeStatus{status: task.INACTIVE}}}
 			ar.status.merge(task.ACTIVE, ar)
@@ -95,6 +95,8 @@ var _ = Describe("safe status merge", func() {
 					},
 				},
 			}
+			// SafeStatus.Merge basically ignores status argument in a lot of cases, so it does not matter what we use here
+			// and in following tests
 			ar.status.merge(task.INACTIVE, ar)
 			Expect(ar.GetStatus()).To(Equal(task.Status(task.ACTIVE)))
 		})