[core] fix malformatted fill_info_fill_number passed to controlled tasks

knopers8 · knopers8 · commit 1150c643e6fa · 2025-05-06T13:42:52.000+02:00
int32 to string() conversion takes the bytes literally, one should use strconv library instead.
Fixes OCTRL-1014.
diff --git a/core/integration/bookkeeping/plugin.go b/core/integration/bookkeeping/plugin.go
@@ -1440,7 +1440,7 @@ func (p *Plugin) CallStack(data interface{}) (stack map[string]interface{}) {
 				Errorf("could not access the parent role when trying to propagate the LHC fill info")
 			return
 		}
-		parentRole.SetGlobalRuntimeVar("fill_info_fill_number", string(lhcInfo.FillNumber))
+		parentRole.SetGlobalRuntimeVar("fill_info_fill_number", strconv.FormatInt(int64(lhcInfo.FillNumber), 10))
 		parentRole.SetGlobalRuntimeVar("fill_info_filling_scheme", lhcInfo.FillingSchemeName)
 		parentRole.SetGlobalRuntimeVar("fill_info_beam_type", lhcInfo.BeamType)
 		if lhcInfo.StableBeamsStart != nil {

Original file line number	Diff line number	Diff line change
`@@ -1440,7 +1440,7 @@ func (p *Plugin) CallStack(data interface{}) (stack map[string]interface{}) {`
`1440`	`1440`	`Errorf("could not access the parent role when trying to propagate the LHC fill info")`
`1441`	`1441`	`return`
`1442`	`1442`	`}`
`1443`		`- parentRole.SetGlobalRuntimeVar("fill_info_fill_number", string(lhcInfo.FillNumber))`
	`1443`	`+ parentRole.SetGlobalRuntimeVar("fill_info_fill_number", strconv.FormatInt(int64(lhcInfo.FillNumber), 10))`
`1444`	`1444`	`parentRole.SetGlobalRuntimeVar("fill_info_filling_scheme", lhcInfo.FillingSchemeName)`
`1445`	`1445`	`parentRole.SetGlobalRuntimeVar("fill_info_beam_type", lhcInfo.BeamType)`
`1446`	`1446`	`if lhcInfo.StableBeamsStart != nil {`