[core] tasks no longer update state to their parents if they are not critical

Author: justonedev1

core/workflow/callrole.go

@@ -228,7 +228,10 @@ func (t *callRole) updateState(s task.State) {
 		WithField("partition", t.GetEnvironmentId().String()).
 		Tracef("updated state to %s upon input state %s", t.state.get().String(), s.String())
 	t.SendEvent(&event.RoleEvent{Name: t.Name, State: t.state.get().String(), RolePath: t.GetPath()})
-	t.parent.updateState(s)
+
+	if t.Critical == true || s != task.ERROR {
+		t.parent.updateState(s)
+	}
 }
 
 func (t *callRole) copy() copyable {

core/workflow/taskrole.go

@@ -232,7 +232,10 @@ func (t *taskRole) updateState(s task.State) {
 		WithField("partition", t.GetEnvironmentId().String()).
 		Tracef("updated state to %s upon input state %s", t.state.get().String(), s.String())
 	t.SendEvent(&event.RoleEvent{Name: t.Name, State: t.state.get().String(), RolePath: t.GetPath()})
-	t.parent.updateState(s)
+
+	if t.Critical == true || s != task.ERROR {
+		t.parent.updateState(s)
+	}
 }
 
 func (t *taskRole) SetTask(taskPtr *task.Task) {