Optionally skip PV validation by interacting BC

Author: shahor02

Detectors/GlobalTrackingWorkflow/src/PrimaryVertexingSpec.cxx

@@ -161,11 +161,12 @@ void PrimaryVertexingSpec::run(ProcessingContext& pc)
   }
 
   mTimer.Stop();
-  LOGP(info, "Found {} PVs, Time CPU/Real:{:.3f}/{:.3f} (DBScan: {:.4f}, Finder:{:.4f}, MADSel:{:.4f}, Rej.Debris:{:.4f}, Reattach:{:.4f}) | {} trials for {} TZ-clusters, max.trials: {}, Slowest TZ-cluster: {} ms of mult {}",
+  LOGP(info, "Found {} PVs, Time CPU/Real:{:.3f}/{:.3f} (DBScan: {:.4f}, Finder:{:.4f}, MADSel:{:.4f}, Rej.Debris:{:.4f}, Reattach:{:.4f}) | {} trials for {} TZ-clusters, max.trials: {}, Slowest TZ-cluster: {} ms of mult {} | NInitial:{}, Rejections: NoFilledBC:{}, NoIntCand:{}, Debris:{}, Quality:{}, ITSOnly:{}",
        vertices.size(), mTimer.CpuTime() - timeCPU0, mTimer.RealTime() - timeReal0,
-       mVertexer.getTimeDBScan().CpuTime(), mVertexer.getTimeVertexing().CpuTime(), mVertexer.getTimeMADSel().CpuTime(), mVertexer.getTimeDebris().CpuTime(), mVertexer.getTimeReAttach().CpuTime(),
-       mVertexer.getTotTrials(), mVertexer.getNTZClusters(), mVertexer.getMaxTrialsPerCluster(),
-       mVertexer.getLongestClusterTimeMS(), mVertexer.getLongestClusterMult());
+       mVertexer.getTimeDBScan().CpuTime(), mVertexer.getTimeVertexing().CpuTime(), mVertexer.getTimeMADSel().CpuTime(), mVertexer.getTimeDebris().CpuTime(),
+       mVertexer.getTimeReAttach().CpuTime(), mVertexer.getTotTrials(), mVertexer.getNTZClusters(), mVertexer.getMaxTrialsPerCluster(),
+       mVertexer.getLongestClusterTimeMS(), mVertexer.getLongestClusterMult(), mVertexer.getNIniFound(),
+       mVertexer.getNKilledBCValid(), mVertexer.getNKilledIntCand(), mVertexer.getNKilledDebris(), mVertexer.getNKilledQuality(), mVertexer.getNKilledITSOnly());
 }
 
 void PrimaryVertexingSpec::endOfStream(EndOfStreamContext& ec)

Detectors/Vertexing/include/DetectorsVertexing/PVertexer.h

@@ -119,6 +119,12 @@ class PVertexer
   auto getMaxTrialsPerCluster() const { return mMaxTrialPerCluster; }
   auto getLongestClusterMult() const { return mLongestClusterMult; }
   auto getLongestClusterTimeMS() const { return mLongestClusterTimeMS; }
+  auto getNKilledBCValid() const { return mNKilledBCValid; }
+  auto getNKilledIntCand() const { return mNKilledIntCand; }
+  auto getNKilledDebris() const { return mNKilledDebris; }
+  auto getNKilledQuality() const { return mNKilledQuality; }
+  auto getNKilledITSOnly() const { return mNKilledITSOnly; }
+  auto getNIniFound() const { return mNIniFound; }
 
   TStopwatch& getTimeDBScan() { return mTimeDBScan; }
   TStopwatch& getTimeVertexing() { return mTimeVertexing; }
@@ -184,9 +190,7 @@ class PVertexer
   float mDBScanDeltaT = 0.;                 ///< deltaT cut for DBScan check
   float mDBSMaxZ2InvCorePoint = 0;          ///< inverse of max sigZ^2 of the track which can be core point in the DBScan
   bool mValidateWithIR = false;             ///< require vertex validation with InteractionCandidates (if available)
-
-  o2::InteractionRecord mStartIR{0, 0}; ///< IR corresponding to the start of the TF
-
+  o2::InteractionRecord mStartIR{0, 0};     ///< IR corresponding to the start of the TF
   // structure for the vertex refit
   o2d::VertexBase mVtxRefitOrig{};   ///< original vertex whose tracks are refitted
   std::vector<int> mRefitTrackIDs{}; ///< dummy IDs for refitted tracks
@@ -201,6 +205,12 @@ class PVertexer
   static constexpr float kHugeF = 1.e12;     ///< very large float
   static constexpr float kAlmost0F = 1e-12;  ///< tiny float
   static constexpr double kAlmost0D = 1e-16; ///< tiny double
+  int mNIniFound = 0;
+  int mNKilledBCValid = 0;
+  int mNKilledIntCand = 0;
+  int mNKilledDebris = 0;
+  int mNKilledQuality = 0;
+  int mNKilledITSOnly = 0;
   size_t mNTZClustersIni = 0;
   size_t mTotTrials = 0;
   size_t mMaxTrialPerCluster = 0;

Detectors/Vertexing/include/DetectorsVertexing/PVertexerParams.h

@@ -102,6 +102,8 @@ struct PVertexerParams : public o2::conf::ConfigurableParamHelper<PVertexerParam
   float nSigmaTimeCut = 4.;             ///< eliminate vertex if there is no FT0 or BC signal within this cut
   float timeBiasMS = 0;                 ///< relative bias in ms to add to TPCITS-based time stamp
   //
+  bool doBCValidation = true; ///< apply validation by interacting BC compatible with the vertex time span
+  //
   // stopping condition params
   float maxChi2Mean = 10.;          ///< max mean chi2 of vertex to accept
   int minTracksPerVtx = 2;          ///< min N tracks per vertex

Detectors/Vertexing/src/PVertexer.cxx

@@ -49,6 +49,12 @@ int PVertexer::runVertexing(const gsl::span<o2d::GlobalTrackID> gids, const gsl:
   mMaxTrialPerCluster = 0;
   mLongestClusterTimeMS = 0;
   mLongestClusterMult = 0;
+  mNIniFound = 0;
+  mNKilledBCValid = 0;
+  mNKilledIntCand = 0;
+  mNKilledDebris = 0;
+  mNKilledQuality = 0;
+  mNKilledITSOnly = 0;
   mPoolDumpProduced = false;
 
   std::vector<PVertex> verticesLoc;
@@ -82,6 +88,7 @@ int PVertexer::runVertexing(const gsl::span<o2d::GlobalTrackID> gids, const gsl:
     createMCLabels(lblTracks, trackIDs, v2tRefsLoc, lblVtxLoc);
   }
 #endif
+  mNIniFound = verticesLoc.size();
 
   if (mValidateWithIR && mPVParams->minNContributorsForIRcutIni >= 0) {
     applInteractionValidation(verticesLoc, vtTimeSortID, intCand, mPVParams->minNContributorsForIRcutIni);
@@ -126,6 +133,7 @@ int PVertexer::runVertexing(const gsl::span<o2d::GlobalTrackID> gids, const gsl:
     auto& vtx = verticesLoc[i];
     if (!setCompatibleIR(vtx)) {
       i = -1;
+      mNKilledBCValid++;
     }
   }
   // do we need to validate by Int. records ?
@@ -576,6 +584,7 @@ void PVertexer::applyMADSelection(std::vector<PVertex>& vertices, std::vector<in
       dvec.clear();
       if (tmad > mPVParams->maxTMAD || tmad < mPVParams->minTMAD) {
         timeSort[ivt] = -1; // disable vertex
+        mNKilledQuality++;
         LOGP(debug, "Killing vertex {} with TMAD {}, {} of {} killed", iv, tmad, ++nkill, nv);
         continue;
       }
@@ -590,6 +599,7 @@ void PVertexer::applyMADSelection(std::vector<PVertex>& vertices, std::vector<in
       float zmad = o2::math_utils::MAD2Sigma(dvec.size(), dvec.data());
       if (zmad > mPVParams->maxZMAD || zmad < mPVParams->minZMAD) {
         timeSort[ivt] = -1; // disable vertex
+        mNKilledQuality++;
         LOGP(debug, "Killing vertex {} with ZMAD {}, {} of {} killed", iv, zmad, ++nkill, nv);
         continue;
       }
@@ -621,6 +631,7 @@ void PVertexer::applITSOnlyFractionCut(std::vector<PVertex>& vertices, std::vect
     float frac = nITS / float(trefs.getEntries());
     if (frac > mPVParams->maxITSOnlyFraction || frac < mPVParams->minITSOnlyFraction) {
       timeSort[ivt] = -1; // disable vertex
+      mNKilledITSOnly++;
     }
   }
 }
@@ -669,6 +680,7 @@ void PVertexer::applInteractionValidation(std::vector<PVertex>& vertices, std::v
       }
     } else if (pv.getNContributors() >= minContrib) {
       timeSort[ivt] = -1; // discard
+      mNKilledIntCand++;
     }
   }
 }
@@ -724,6 +736,7 @@ void PVertexer::reduceDebris(std::vector<PVertex>& vertices, std::vector<int>& t
     }
     if (rej) {
       timeSort[j] = -1;
+      mNKilledDebris++;
       vtJ.setNContributors(0);
     }
     return false;
@@ -964,7 +977,7 @@ void PVertexer::setBunchFilling(const o2::BunchFilling& bf)
 bool PVertexer::setCompatibleIR(PVertex& vtx)
 {
   // assign compatible IRs accounting for the bunch filling scheme
-  if (mClosestBunchAbove[0] < 0) { // empty or no BF was provided
+  if (mClosestBunchAbove[0] < 0 && mPVParams->doBCValidation) { // empty or no BF was provided
     return false;
   }
   const auto& vtxT = vtx.getTimeStamp();
@@ -979,22 +992,24 @@ bool PVertexer::setCompatibleIR(PVertex& vtx)
   }
   irMax += o2::InteractionRecord(1.e3 * (t + rangeT)); // RS TODO: make sure that irMax does not exceed TF edge
   irMax++; // to account for rounding
-  // restrict using bunch filling
-  int bc = mClosestBunchAbove[irMin.bc];
-  LOG(debug) << "irMin.bc = " << irMin.bc << " bcAbove = " << bc;
-  if (bc < irMin.bc) {
-    irMin.orbit++;
-  }
-  irMin.bc = bc;
-  bc = mClosestBunchBelow[irMax.bc];
-  LOG(debug) << "irMax.bc = " << irMax.bc << " bcBelow = " << bc;
-  if (bc > irMax.bc) {
-    if (irMax.orbit == 0) {
-      return false;
-    }
-    irMax.orbit--;
-  }
-  irMax.bc = bc;
+  if (mPVParams->doBCValidation) {
+    // restrict using bunch filling
+    int bc = mClosestBunchAbove[irMin.bc];
+    LOG(debug) << "irMin.bc = " << irMin.bc << " bcAbove = " << bc;
+    if (bc < irMin.bc) {
+      irMin.orbit++;
+    }
+    irMin.bc = bc;
+    bc = mClosestBunchBelow[irMax.bc];
+    LOG(debug) << "irMax.bc = " << irMax.bc << " bcBelow = " << bc;
+    if (bc > irMax.bc) {
+      if (irMax.orbit == 0) {
+        return false;
+      }
+      irMax.orbit--;
+    }
+    irMax.bc = bc;
+  }
   vtx.setIRMin(irMin);
   vtx.setIRMax(irMax);
   if (irMin > irMax) {