Skip to content

Commit f83ef77

Browse files
authored
DPL Analysis: fix use-after-delete in expressions (#13869)
1 parent fcb75a1 commit f83ef77

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Framework/Core/src/Expressions.cxx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ size_t Filter::designateSubtrees(Node* node, size_t index)
6767
path.emplace(node, 0);
6868

6969
while (!path.empty()) {
70-
auto& top = path.top();
70+
auto top = path.top();
7171
top.node_ptr->index = local_index;
7272
path.pop();
7373
if (top.node_ptr->condition != nullptr) {
@@ -277,7 +277,7 @@ Operations createOperations(Filter const& expression)
277277

278278
// while the stack is not empty
279279
while (!path.empty()) {
280-
auto& top = path.top();
280+
auto top = path.top();
281281

282282
// create operation spec, pop the node and add its children
283283
auto operationSpec =
@@ -458,7 +458,7 @@ std::shared_ptr<gandiva::Filter>
458458
{
459459
std::shared_ptr<gandiva::Filter> filter;
460460
auto s = gandiva::Filter::Make(Schema,
461-
std::move(condition),
461+
condition,
462462
&filter);
463463
if (!s.ok()) {
464464
throw runtime_error_f("Failed to create filter: %s", s.ToString().c_str());

0 commit comments

Comments
 (0)