protect configurable fixed width axes against wrong ranges

mario-krueger · mario-krueger · commit e7fbccdcbcfa · 2025-12-12T12:21:15.000+01:00
diff --git a/Framework/Core/include/Framework/HistogramSpec.h b/Framework/Core/include/Framework/HistogramSpec.h
@@ -115,7 +115,10 @@ struct AxisSpec {
     }
     if (binEdges[0] != VARIABLE_WIDTH) {
       nBins = static_cast<int>(binEdges[0]);
-      binEdges.resize(3); // nBins, lowerBound, upperBound, disregard whatever else is stored in vecotr
+      if (binEdges.size() < 3 || binEdges[1] > binEdges[2]) {
+        LOG(fatal) << "Defined ill-defined axis";
+      }
+      binEdges.resize(3); // nBins, lowerBound, upperBound, disregard whatever else is stored in vector
     }
     binEdges.erase(binEdges.begin()); // remove first entry that we assume to be number of bins
   }

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,10 @@ struct AxisSpec {`
`115`	`115`	`}`
`116`	`116`	`if (binEdges[0] != VARIABLE_WIDTH) {`
`117`	`117`	`nBins = static_cast<int>(binEdges[0]);`
`118`		`- binEdges.resize(3); // nBins, lowerBound, upperBound, disregard whatever else is stored in vecotr`
	`118`	`+ if (binEdges.size() < 3 \|\| binEdges[1] > binEdges[2]) {`
	`119`	`+ LOG(fatal) << "Defined ill-defined axis";`
	`120`	`+ }`
	`121`	`+ binEdges.resize(3); // nBins, lowerBound, upperBound, disregard whatever else is stored in vector`
`119`	`122`	`}`
`120`	`123`	`binEdges.erase(binEdges.begin()); // remove first entry that we assume to be number of bins`
`121`	`124`	`}`