Skip to content

Commit d9ed9c7

Browse files
committed
fix benchmark compilation
1 parent 19406ce commit d9ed9c7

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

Framework/Core/include/Framework/GroupedCombinations.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ struct GroupedCombinationsGenerator {
9393
} else {
9494
mGrouping = std::make_shared<G>(std::vector{grouping.asArrowTable()});
9595
}
96-
mAssociated = std::make_shared<std::tuple<As...>>(std::make_tuple(std::get<has_type_at<As>(pack<T2s...>{})>(associated)...));
96+
mAssociated = std::make_shared<std::tuple<As...>>(std::make_tuple(std::get<has_type_at_v<As>(pack<T2s...>{})>(associated)...));
9797
setMultipleGroupingTables<sizeof...(As)>(grouping);
9898
if (!this->mIsEnd) {
9999
setCurrentGroupedCombination();

Framework/Core/test/benchmark_TableBuilder.cxx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,19 @@
1010
// or submit itself to any jurisdiction.
1111

1212
#include "Framework/TableBuilder.h"
13-
#include "Framework/TableConsumer.h"
1413

1514
#include <benchmark/benchmark.h>
1615

1716
using namespace o2::framework;
17+
using namespace o2::soa;
1818

1919
static void BM_TableBuilderOverhead(benchmark::State& state)
2020
{
2121
using namespace o2::framework;
2222

2323
for (auto _ : state) {
2424
TableBuilder builder;
25-
auto rowWriter = builder.persist<float, float, float>({"x", "y", "z"});
25+
[[maybe_unused]] auto rowWriter = builder.persist<float, float, float>({"x", "y", "z"});
2626
auto table = builder.finalize();
2727
}
2828
}
@@ -35,7 +35,7 @@ static void BM_TableBuilderScalar(benchmark::State& state)
3535
for (auto _ : state) {
3636
TableBuilder builder;
3737
auto rowWriter = builder.persist<float>({"x"});
38-
for (size_t i = 0; i < state.range(0); ++i) {
38+
for (auto i = 0; i < state.range(0); ++i) {
3939
rowWriter(0, 0.f);
4040
}
4141
auto table = builder.finalize();
@@ -52,7 +52,7 @@ static void BM_TableBuilderScalarReserved(benchmark::State& state)
5252
TableBuilder builder;
5353
auto rowWriter = builder.persist<float>({"x"});
5454
builder.reserve(o2::framework::pack<float>{}, state.range(0));
55-
for (size_t i = 0; i < state.range(0); ++i) {
55+
for (auto i = 0; i < state.range(0); ++i) {
5656
rowWriter(0, 0.f);
5757
}
5858
auto table = builder.finalize();
@@ -68,7 +68,7 @@ static void BM_TableBuilderScalarPresized(benchmark::State& state)
6868
for (auto _ : state) {
6969
TableBuilder builder;
7070
auto rowWriter = builder.preallocatedPersist<float>({"x"}, state.range(0));
71-
for (size_t i = 0; i < state.range(0); ++i) {
71+
for (auto i = 0; i < state.range(0); ++i) {
7272
rowWriter(0, 0.f);
7373
}
7474
auto table = builder.finalize();
@@ -86,7 +86,7 @@ static void BM_TableBuilderScalarBulk(benchmark::State& state)
8686
for (auto _ : state) {
8787
TableBuilder builder;
8888
auto bulkWriter = builder.bulkPersist<float>({"x"}, state.range(0));
89-
for (size_t i = 0; i < state.range(0) / chunkSize; ++i) {
89+
for (auto i = 0; i < state.range(0) / chunkSize; ++i) {
9090
bulkWriter(0, chunkSize, buffer.data());
9191
}
9292
auto table = builder.finalize();
@@ -101,7 +101,7 @@ static void BM_TableBuilderSimple(benchmark::State& state)
101101
for (auto _ : state) {
102102
TableBuilder builder;
103103
auto rowWriter = builder.persist<float, float, float>({"x", "y", "z"});
104-
for (size_t i = 0; i < state.range(0); ++i) {
104+
for (auto i = 0; i < state.range(0); ++i) {
105105
rowWriter(0, 0.f, 0.f, 0.f);
106106
}
107107
auto table = builder.finalize();
@@ -116,7 +116,7 @@ static void BM_TableBuilderSimple2(benchmark::State& state)
116116
for (auto _ : state) {
117117
TableBuilder builder;
118118
auto rowWriter = builder.persist<float, float, float>({"x", "y", "z"});
119-
for (size_t i = 0; i < state.range(0); ++i) {
119+
for (auto i = 0; i < state.range(0); ++i) {
120120
rowWriter(0, 0.f, 0.f, 0.f);
121121
}
122122
auto table = builder.finalize();
@@ -140,7 +140,7 @@ static void BM_TableBuilderSoA(benchmark::State& state)
140140
for (auto _ : state) {
141141
TableBuilder builder;
142142
auto rowWriter = builder.cursor<TestVectors>();
143-
for (size_t i = 0; i < state.range(0); ++i) {
143+
for (auto i = 0; i < state.range(0); ++i) {
144144
rowWriter(0, 0.f, 0.f, 0.f);
145145
}
146146
auto table = builder.finalize();
@@ -155,7 +155,7 @@ static void BM_TableBuilderComplex(benchmark::State& state)
155155
for (auto _ : state) {
156156
TableBuilder builder;
157157
auto rowWriter = builder.persist<int, float, std::string, bool>({"x", "y", "s", "b"});
158-
for (size_t i = 0; i < state.range(0); ++i) {
158+
for (auto i = 0; i < state.range(0); ++i) {
159159
rowWriter(0, 0, 0., "foo", true);
160160
}
161161
auto table = builder.finalize();

0 commit comments

Comments
 (0)