DPL: have helper which returns true if running online

Author: ktf

Framework/Core/include/Framework/DefaultsHelpers.h

@@ -18,6 +18,8 @@ enum struct DeploymentMode;
 
 struct DefaultsHelpers {
   static DeploymentMode deploymentMode();
+  /// @true if running online
+  static bool onlineDeploymentMode();
   /// get max number of timeslices in the queue
   static unsigned int pipelineLength();
 };

Framework/Core/src/CommonServices.cxx

@@ -848,8 +848,7 @@ o2::framework::ServiceSpec CommonServices::dataProcessingStats()
       bool enableDebugMetrics = true;
 #endif
       bool arrowAndResourceLimitingMetrics = false;
-      DeploymentMode deploymentMode = DefaultsHelpers::deploymentMode();
-      if (deploymentMode != DeploymentMode::OnlineDDS && deploymentMode != DeploymentMode::OnlineECS && deploymentMode != DeploymentMode::OnlineAUX && deploymentMode != DeploymentMode::FST) {
+      if (!DefaultsHelpers::onlineDeploymentMode() && DefaultsHelpers::deploymentMode() != DeploymentMode::FST) {
         arrowAndResourceLimitingMetrics = true;
       }
       // Input proxies should not report cpu_usage_fraction,
@@ -1243,8 +1242,7 @@ std::vector<ServiceSpec> CommonServices::defaultServices(std::string extraPlugin
     objectCache(),
     ccdbSupportSpec()};
 
-  DeploymentMode deploymentMode = DefaultsHelpers::deploymentMode();
-  if (deploymentMode != DeploymentMode::OnlineDDS && deploymentMode != DeploymentMode::OnlineECS && deploymentMode != DeploymentMode::OnlineAUX && deploymentMode != DeploymentMode::FST) {
+  if (!DefaultsHelpers::onlineDeploymentMode() && DefaultsHelpers::deploymentMode() != DeploymentMode::FST) {
     specs.push_back(ArrowSupport::arrowBackendSpec());
   }
   specs.push_back(CommonMessageBackends::fairMQBackendSpec());
@@ -1253,7 +1251,7 @@ std::vector<ServiceSpec> CommonServices::defaultServices(std::string extraPlugin
 
   std::string loadableServicesStr = extraPlugins;
   // Do not load InfoLogger by default if we are not at P2.
-  if (deploymentMode == DeploymentMode::OnlineDDS || deploymentMode == DeploymentMode::OnlineECS || deploymentMode == DeploymentMode::OnlineAUX) {
+  if (DefaultsHelpers::onlineDeploymentMode()) {
     if (loadableServicesStr.empty() == false) {
       loadableServicesStr += ",";
     }

Framework/Core/src/DefaultsHelpers.cxx

@@ -64,4 +64,16 @@ DeploymentMode DefaultsHelpers::deploymentMode()
   return retVal;
 }
 
+bool DefaultsHelpers::onlineDeploymentMode()
+{
+  switch (DefaultsHelpers::deploymentMode()) {
+    case DeploymentMode::OnlineAUX:
+    case DeploymentMode::OnlineECS:
+    case DeploymentMode::OnlineDDS:
+      return true;
+    default:
+      return false;
+  }
+}
+
 } // namespace o2::framework