Skip to content

Commit c6dc003

Browse files
author
Michal Tichák
committed
perfect forwarding to reference
1 parent b9d26ef commit c6dc003

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

Utilities/Mergers/src/MergerAlgorithm.cxx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
#include "Mergers/MergeInterface.h"
2020
#include "Mergers/ObjectStore.h"
21+
#include "Framework/Logger.h"
2122

2223
#include <TEfficiency.h>
2324
#include <TGraph.h>
@@ -52,7 +53,7 @@ size_t estimateTreeSize(TTree* tree)
5253
// we need to recursively transverse whole TPad structure.
5354
auto collectUnderlyingObjects(TCanvas* canvas) -> std::vector<TObject*>
5455
{
55-
auto collectFromTPad = [](TPad* pad, std::vector<TObject*>& objects, auto&& collectFromTPad) {
56+
auto collectFromTPad = [](TPad* pad, std::vector<TObject*>& objects, const auto& collectFromTPad) {
5657
if (!pad) {
5758
return;
5859
}

Utilities/Mergers/test/test_Algorithm.cxx

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
/// \author Piotr Konopka, piotr.jan.konopka@cern.ch
1616

1717
#include <boost/mpl/pair.hpp>
18-
#include <boost/test/tools/interface.hpp>
19-
#include <boost/test/tools/old/interface.hpp>
2018
#include <gsl/span>
2119
#include <memory>
2220
#include <stdexcept>
@@ -323,13 +321,10 @@ TCanvas* createCanvas(std::string name, std::string title, std::vector<std::shar
323321

324322
auto collectUnderlyingObjects(TCanvas* canvas) -> std::vector<TObject*>
325323
{
326-
if (!canvas) {
327-
return {};
328-
}
329-
330-
auto collectFromTPad = []<class TPadOrTCanvas>
331-
requires std::same_as<TPadOrTCanvas, TPad> || std::same_as<TPadOrTCanvas, TCanvas>
332-
(TPadOrTCanvas * pad, std::vector<TObject*> & objects, auto&& collectFromTPad) -> void {
324+
auto collectFromTPad = [](TPad* pad, std::vector<TObject*>& objects, const auto& collectFromTPad) {
325+
if (!pad) {
326+
return;
327+
}
333328
auto* primitives = pad->GetListOfPrimitives();
334329
for (int i = 0; i < primitives->GetSize(); ++i) {
335330
auto* primitive = primitives->At(i);

0 commit comments

Comments
 (0)