rANS: Suppress bogus compiler warnings, and add / improve some comments

Author: davidrohr

GPU/GPUTracking/Base/cuda/GPUReconstructionCUDA.cu

@@ -416,7 +416,7 @@ int32_t GPUReconstructionCUDA::InitDevice_Runtime()
     mInternals = master->mInternals;
     GPUFailedMsg(cudaSetDevice(mDeviceId));
 
-    GPUInfo("CUDA Initialized from master");
+    GPUInfo("CUDA Initialisation successfull (from master)");
   }
 
   for (uint32_t i = 0; i < mEvents.size(); i++) {

GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesHost.h

@@ -21,7 +21,7 @@
 #include <hip/hip_ext.h>
 #include <hipcub/hipcub.hpp>
 #pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wshadow"
+#pragma GCC diagnostic ignored "-Wshadow" // FIXME: Is this still needed?
 #include <thrust/sort.h>
 #include <thrust/execution_policy.h>
 #include <thrust/device_ptr.h>

GPU/GPUTracking/Merger/GPUTPCGMMergedTrack.h

@@ -114,6 +114,7 @@ class GPUTPCGMMergedTrack
   float mLastY;                  //* outer Y
   float mLastZ;                  //* outer Z
   uint32_t mFirstClusterRef;     //* index of the first track cluster in corresponding cluster arrays
+  // TODO: Change to 8 bit
   uint32_t mNClusters;           //* number of track clusters
   uint32_t mNClustersFitted;     //* number of clusters used in fit
   uint8_t mFlags;

Utilities/rANS/benchmarks/bench_ransDecode.cxx

@@ -112,8 +112,11 @@ void ransDecodeBenchmark(benchmark::State& st, Args&&... args)
   using input_data_type = std::remove_cv_t<std::remove_reference_t<decltype(inputData)>>;
   using source_type = typename input_data_type::value_type;
 
+#pragma GCC diagnostic push // TODO: Remove me when fixed in GCC
+#pragma GCC diagnostic ignored "-Walloc-size-larger-than="
   EncodeBuffer<source_type> encodeBuffer{inputData.size()};
   DecodeBuffer<source_type> decodeBuffer{inputData.size()};
+#pragma GCC diagnostic pop
 
   const auto histogram = makeDenseHistogram::fromSamples(gsl::span<const source_type>(inputData));
   Metrics<source_type> metrics{histogram};