Skip to content

Commit c324ffb

Browse files
committed
DPL: reduce chances to drop offers
Workaround. Proper fix coming.
1 parent e049e58 commit c324ffb

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

Framework/Core/include/Framework/ComputingQuotaEvaluator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class ComputingQuotaEvaluator
3232
{
3333
public:
3434
// Maximum number of offers this evaluator can hold
35-
static constexpr int MAX_INFLIGHT_OFFERS = 16;
35+
static constexpr int MAX_INFLIGHT_OFFERS = 32;
3636
ComputingQuotaEvaluator(ServiceRegistryRef ref);
3737
/// @a task the task which needs some quota
3838
/// @a request the resource request the @a task needs

Framework/Core/include/Framework/ComputingQuotaOffer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ using ComputingQuotaRequest = std::function<OfferScore(ComputingQuotaOffer const
8484

8585
/// A consumer is a function which updates a given function removing the
8686
/// amount of resources which are considered as consumed.
87-
using ComputingQuotaConsumer = std::function<void(int id, std::array<ComputingQuotaOffer, 16>&, ComputingQuotaStats&, std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats& stats)>)>;
87+
using ComputingQuotaConsumer = std::function<void(int id, std::array<ComputingQuotaOffer, 32>&, ComputingQuotaStats&, std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats& stats)>)>;
8888

8989
} // namespace o2::framework
9090

Framework/Core/src/DataProcessor.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ void DataProcessor::doSend(DataSender& sender, ArrowContext& context, ServiceReg
123123
}
124124
static int64_t previousBytesSent = 0;
125125
auto disposeResources = [bs = context.bytesSent() - previousBytesSent](int taskId,
126-
std::array<ComputingQuotaOffer, 16>& offers,
126+
std::array<ComputingQuotaOffer, 32>& offers,
127127
ComputingQuotaStats& stats,
128128
std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats&)> accountDisposed) {
129129
ComputingQuotaOffer disposed;

Framework/Core/test/test_ComputingQuotaEvaluator.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ TEST_CASE("TestComputingQuotaEvaluator")
2828
};
2929

3030
ComputingQuotaConsumer dispose2MB = [bs = 2000000](int taskId,
31-
std::array<ComputingQuotaOffer, 16>& offers,
31+
std::array<ComputingQuotaOffer, 32>& offers,
3232
ComputingQuotaStats& stats,
3333
std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats&)> accountDisposed) {
3434
ComputingQuotaOffer disposed;
@@ -51,7 +51,7 @@ TEST_CASE("TestComputingQuotaEvaluator")
5151
};
5252

5353
ComputingQuotaConsumer dispose10MB = [bs = 10000000](int taskId,
54-
std::array<ComputingQuotaOffer, 16>& offers,
54+
std::array<ComputingQuotaOffer, 32>& offers,
5555
ComputingQuotaStats& stats,
5656
std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats&)> accountDisposed) {
5757
ComputingQuotaOffer disposed;

0 commit comments

Comments
 (0)