Fix some codechecker violations (#14936)

davidrohr · web-flow · commit bfcff02b88be · 2025-12-24T23:16:32.000+01:00
diff --git a/Detectors/CPV/reconstruction/include/CPVReconstruction/CTFCoder.h b/Detectors/CPV/reconstruction/include/CPVReconstruction/CTFCoder.h
@@ -32,7 +32,7 @@ namespace o2
 namespace cpv
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::CPV) {}
diff --git a/Detectors/CTP/reconstruction/include/CTPReconstruction/CTFCoder.h b/Detectors/CTP/reconstruction/include/CTPReconstruction/CTFCoder.h
@@ -34,7 +34,7 @@ namespace o2
 namespace ctp
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::CTP) {}
diff --git a/Detectors/EMCAL/reconstruction/include/EMCALReconstruction/CTFCoder.h b/Detectors/EMCAL/reconstruction/include/EMCALReconstruction/CTFCoder.h
@@ -32,7 +32,7 @@ namespace o2
 namespace emcal
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::EMC) {}
diff --git a/Detectors/FIT/FDD/reconstruction/include/FDDReconstruction/CTFCoder.h b/Detectors/FIT/FDD/reconstruction/include/FDDReconstruction/CTFCoder.h
@@ -33,7 +33,7 @@ namespace o2
 namespace fdd
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::FDD) {}
diff --git a/Detectors/FIT/FT0/reconstruction/include/FT0Reconstruction/CTFCoder.h b/Detectors/FIT/FT0/reconstruction/include/FT0Reconstruction/CTFCoder.h
@@ -34,7 +34,7 @@ namespace o2
 namespace ft0
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::FT0) {}
diff --git a/Detectors/FIT/FV0/reconstruction/include/FV0Reconstruction/CTFCoder.h b/Detectors/FIT/FV0/reconstruction/include/FV0Reconstruction/CTFCoder.h
@@ -30,7 +30,7 @@ namespace o2
 namespace fv0
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::FV0) {}
diff --git a/Detectors/GlobalTrackingWorkflow/study/src/DumpTracks.cxx b/Detectors/GlobalTrackingWorkflow/study/src/DumpTracks.cxx
@@ -48,7 +48,7 @@ using TBracket = o2::math_utils::Bracketf_t;
 
 using timeEst = o2::dataformats::TimeStampWithError<float, float>;
 
-class DumpTracksSpec : public Task
+class DumpTracksSpec final : public Task
 {
  public:
   DumpTracksSpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, bool useMC)
diff --git a/Detectors/GlobalTrackingWorkflow/study/src/SVStudy.cxx b/Detectors/GlobalTrackingWorkflow/study/src/SVStudy.cxx
@@ -68,7 +68,7 @@ using V0ID = o2::dataformats::V0Index;
 
 using timeEst = o2::dataformats::TimeStampWithError<float, float>;
 
-class SVStudySpec : public Task
+class SVStudySpec final : public Task
 {
  public:
   SVStudySpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, bool useTPCCl, bool useMC)
diff --git a/Detectors/GlobalTrackingWorkflow/study/src/TPCTrackStudy.cxx b/Detectors/GlobalTrackingWorkflow/study/src/TPCTrackStudy.cxx
@@ -47,7 +47,7 @@ using TBracket = o2::math_utils::Bracketf_t;
 
 using timeEst = o2::dataformats::TimeStampWithError<float, float>;
 
-class TPCTrackStudySpec : public Task
+class TPCTrackStudySpec final : public Task
 {
  public:
   TPCTrackStudySpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, const o2::tpc::CorrectionMapsLoaderGloOpts& sclOpts, GTrackID::mask_t src, bool useMC)
diff --git a/Detectors/GlobalTrackingWorkflow/study/src/TrackMCStudy.cxx b/Detectors/GlobalTrackingWorkflow/study/src/TrackMCStudy.cxx
@@ -83,7 +83,7 @@ using TBracket = o2::math_utils::Bracketf_t;
 
 using timeEst = o2::dataformats::TimeStampWithError<float, float>;
 
-class TrackMCStudy : public Task
+class TrackMCStudy final : public Task
 {
  public:
   TrackMCStudy(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, const o2::tpc::CorrectionMapsLoaderGloOpts& sclOpts, bool checkSV)
diff --git a/Detectors/GlobalTrackingWorkflow/study/src/TrackingStudy.cxx b/Detectors/GlobalTrackingWorkflow/study/src/TrackingStudy.cxx
@@ -67,7 +67,7 @@ using TBracket = o2::math_utils::Bracketf_t;
 
 using timeEst = o2::dataformats::TimeStampWithError<float, float>;
 
-class TrackingStudySpec : public Task
+class TrackingStudySpec final : public Task
 {
  public:
   TrackingStudySpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, bool useMC, const o2::tpc::CorrectionMapsLoaderGloOpts& sclOpts)
@@ -444,7 +444,7 @@ void TrackingStudySpec::process(o2::globaltracking::RecoContainer& recoData)
         }
         bool ambig = vid.isAmbiguous();
         auto trc = recoData.getTrackParam(vid);
-        if (abs(trc.getEta()) > mMaxEta) {
+        if (fabs(trc.getEta()) > mMaxEta) {
           continue;
         }
         if (iv < nv - 1 && is == GTrackID::TPC && tpcTr && !tpcTr->hasBothSidesClusters()) { // for unconstrained TPC tracks correct track Z
diff --git a/Detectors/HMPID/reconstruction/include/HMPIDReconstruction/CTFCoder.h b/Detectors/HMPID/reconstruction/include/HMPIDReconstruction/CTFCoder.h
@@ -32,7 +32,7 @@ namespace o2
 namespace hmpid
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::HMP) {}
diff --git a/Detectors/ITSMFT/ITS/QC/TestDataReaderWorkflow/src/TestDataReader.cxx b/Detectors/ITSMFT/ITS/QC/TestDataReaderWorkflow/src/TestDataReader.cxx
@@ -509,7 +509,6 @@ void TestDataReader::run(ProcessingContext& pc)
 
 std::vector<string> TestDataReader::GetFName(std::string folder)
 {
-
   DIR* dirp;
 
   char cstr[folder.size() + 1];
diff --git a/Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/CTFCoder.h b/Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/CTFCoder.h
@@ -39,7 +39,7 @@ namespace o2
 namespace itsmft
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   using PMatrix = std::array<std::array<bool, ClusterPattern::MaxRowSpan + 2>, ClusterPattern::MaxColSpan + 2>;
diff --git a/Detectors/MUON/MCH/CTF/include/MCHCTF/CTFCoder.h b/Detectors/MUON/MCH/CTF/include/MCHCTF/CTFCoder.h
@@ -34,7 +34,7 @@ namespace o2
 namespace mch
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::MCH) {}
diff --git a/Detectors/MUON/MID/CTF/include/MIDCTF/CTFCoder.h b/Detectors/MUON/MID/CTF/include/MIDCTF/CTFCoder.h
@@ -34,7 +34,7 @@ namespace o2
 namespace mid
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::MID) {}
diff --git a/Detectors/PHOS/reconstruction/include/PHOSReconstruction/CTFCoder.h b/Detectors/PHOS/reconstruction/include/PHOSReconstruction/CTFCoder.h
@@ -32,7 +32,7 @@ namespace o2
 namespace phos
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::PHS) {}
diff --git a/Detectors/TOF/reconstruction/include/TOFReconstruction/CTFCoder.h b/Detectors/TOF/reconstruction/include/TOFReconstruction/CTFCoder.h
@@ -31,7 +31,7 @@ namespace o2
 namespace tof
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::TOF) {}
diff --git a/Detectors/TPC/reconstruction/include/TPCReconstruction/CTFCoder.h b/Detectors/TPC/reconstruction/include/TPCReconstruction/CTFCoder.h
@@ -119,7 +119,7 @@ struct MergedColumnsDecoder {
 
 } // namespace detail
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::TPC) {}
diff --git a/Detectors/TRD/reconstruction/include/TRDReconstruction/CTFCoder.h b/Detectors/TRD/reconstruction/include/TRDReconstruction/CTFCoder.h
@@ -33,7 +33,7 @@ namespace o2
 namespace trd
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::TRD) {}
diff --git a/Detectors/ZDC/reconstruction/include/ZDCReconstruction/CTFCoder.h b/Detectors/ZDC/reconstruction/include/ZDCReconstruction/CTFCoder.h
@@ -32,7 +32,7 @@ namespace o2
 namespace zdc
 {
 
-class CTFCoder : public o2::ctf::CTFCoderBase
+class CTFCoder final : public o2::ctf::CTFCoderBase
 {
  public:
   CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::ZDC) {}
diff --git a/Framework/Utils/include/DPLUtils/RootTreeWriter.h b/Framework/Utils/include/DPLUtils/RootTreeWriter.h
@@ -714,7 +714,7 @@ class RootTreeWriter
         impl.start = &(data[0]);
         impl.end = &(data[data.size() - 1]) + 1; // end pointer (beyond last element)
         impl.cap = impl.end;
-        std::memcpy(&v, &impl, sizeof(VecBase));
+        std::memcpy((void*)&v, (const void*)&impl, sizeof(VecBase));
       };
 
       // if the value type is messagable and has a ROOT dictionary, two serialization methods are possible

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ namespace o2`
`32`	`32`	`namespace cpv`
`33`	`33`	`{`
`34`	`34`
`35`		`-class CTFCoder : public o2::ctf::CTFCoderBase`
	`35`	`+class CTFCoder final : public o2::ctf::CTFCoderBase`
`36`	`36`	`{`
`37`	`37`	`public:`
`38`	`38`	`CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::CPV) {}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ namespace o2`
`34`	`34`	`namespace ctp`
`35`	`35`	`{`
`36`	`36`
`37`		`-class CTFCoder : public o2::ctf::CTFCoderBase`
	`37`	`+class CTFCoder final : public o2::ctf::CTFCoderBase`
`38`	`38`	`{`
`39`	`39`	`public:`
`40`	`40`	`CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::CTP) {}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ namespace o2`
`33`	`33`	`namespace fdd`
`34`	`34`	`{`
`35`	`35`
`36`		`-class CTFCoder : public o2::ctf::CTFCoderBase`
	`36`	`+class CTFCoder final : public o2::ctf::CTFCoderBase`
`37`	`37`	`{`
`38`	`38`	`public:`
`39`	`39`	`CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::FDD) {}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ namespace o2`
`30`	`30`	`namespace fv0`
`31`	`31`	`{`
`32`	`32`
`33`		`-class CTFCoder : public o2::ctf::CTFCoderBase`
	`33`	`+class CTFCoder final : public o2::ctf::CTFCoderBase`
`34`	`34`	`{`
`35`	`35`	`public:`
`36`	`36`	`CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::FV0) {}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ using TBracket = o2::math_utils::Bracketf_t;`
`48`	`48`
`49`	`49`	`using timeEst = o2::dataformats::TimeStampWithError<float, float>;`
`50`	`50`
`51`		`-class DumpTracksSpec : public Task`
	`51`	`+class DumpTracksSpec final : public Task`
`52`	`52`	`{`
`53`	`53`	`public:`
`54`	`54`	`DumpTracksSpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, bool useMC)`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ using V0ID = o2::dataformats::V0Index;`
`68`	`68`
`69`	`69`	`using timeEst = o2::dataformats::TimeStampWithError<float, float>;`
`70`	`70`
`71`		`-class SVStudySpec : public Task`
	`71`	`+class SVStudySpec final : public Task`
`72`	`72`	`{`
`73`	`73`	`public:`
`74`	`74`	`SVStudySpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, bool useTPCCl, bool useMC)`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ using TBracket = o2::math_utils::Bracketf_t;`
`47`	`47`
`48`	`48`	`using timeEst = o2::dataformats::TimeStampWithError<float, float>;`
`49`	`49`
`50`		`-class TPCTrackStudySpec : public Task`
	`50`	`+class TPCTrackStudySpec final : public Task`
`51`	`51`	`{`
`52`	`52`	`public:`
`53`	`53`	`TPCTrackStudySpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, const o2::tpc::CorrectionMapsLoaderGloOpts& sclOpts, GTrackID::mask_t src, bool useMC)`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ using TBracket = o2::math_utils::Bracketf_t;`
`83`	`83`
`84`	`84`	`using timeEst = o2::dataformats::TimeStampWithError<float, float>;`
`85`	`85`
`86`		`-class TrackMCStudy : public Task`
	`86`	`+class TrackMCStudy final : public Task`
`87`	`87`	`{`
`88`	`88`	`public:`
`89`	`89`	`TrackMCStudy(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, const o2::tpc::CorrectionMapsLoaderGloOpts& sclOpts, bool checkSV)`