Improved logging + colsys check

Author: jackal1-66

Generators/src/Generator.cxx

@@ -50,11 +50,15 @@ Generator::Generator() : FairGenerator("ALICEo2", "ALICEo2 Generator"),
     if (transport) {
       bool tpcActive = (std::find(simConfig.getReadoutDetectors().begin(), simConfig.getReadoutDetectors().end(), "TPC") != simConfig.getReadoutDetectors().end());
       if (tpcActive) {
-        if(initLoopersGen()){
+        if (initLoopersGen()) {
           mAddTPCLoopers = kTRUE;
         }
+      } else {
+        LOG(info) << "TPC not active in readout detectors: loopers fast generator disabled.";
       }
     }
+  } else {
+    LOG(info) << "Loopers fast generator turned OFF with veto flag.";
   }
 #endif
 }
@@ -78,8 +82,12 @@ Generator::Generator(const Char_t* name, const Char_t* title) : FairGenerator(na
         if (initLoopersGen()) {
           mAddTPCLoopers = kTRUE;
         }
+      } else {
+        LOG(info) << "TPC not active in readout detectors: loopers fast generator disabled.";
       }
     }
+  } else {
+    LOG(info) << "Loopers fast generator turned OFF with veto flag.";
   }
 #endif
 }
@@ -97,8 +105,14 @@ bool Generator::initLoopersGen()
   const auto& scaler_compton = gSystem->ExpandPathName(loopersParam.scaler_compton.c_str());
   const auto& poisson = gSystem->ExpandPathName(loopersParam.poisson.c_str());
   const auto& gauss = gSystem->ExpandPathName(loopersParam.gauss.c_str());
-  auto flat_gas = loopersParam.flat_gas;
+  const auto& flat_gas = loopersParam.flat_gas;
+  const auto& colsys = loopersParam.colsys;
   if (flat_gas) {
+    if (colsys != "PbPb" && colsys != "pp") {
+      LOG(warning) << "Automatic background loopers configuration supports only 'pp' and 'PbPb' systems.";
+      LOG(warning) << "Fast loopers generator will remain OFF.";
+      return kFALSE;
+    }
     bool isContext = std::filesystem::exists("collisioncontext.root");
     if (!isContext) {
       LOG(warning) << "Warning: No collisioncontext.root file found!";
@@ -156,17 +170,12 @@ bool Generator::initLoopersGen()
   try {
     // Create the TPC loopers generator with the provided parameters
     mLoopersGen = std::make_unique<o2::eventgen::GenTPCLoopers>(model_pairs, model_compton, poisson, gauss, scaler_pair, scaler_compton);
-    auto& colsys = loopersParam.colsys;
-    auto &intrate = loopersParam.intrate;
+    const auto &intrate = loopersParam.intrate;
     // Configure the generator with flat gas loopers defined per orbit with clusters/track info
+    // If intrate is negative (default), automatic IR from collisioncontext.root will be used
     if (flat_gas) {
-      if (colsys != "PbPb" && colsys != "pp") {
-        LOG(fatal) << "Error: collision system must be either 'PbPb' or 'pp'";
-        exit(1);
-      } else {
-        mLoopersGen->SetRate(nclxrate, (colsys == "PbPb") ? true : false, intrate);
-        mLoopersGen->SetAdjust(loopersParam.adjust_flatgas);
-      }
+      mLoopersGen->SetRate(nclxrate, (colsys == "PbPb") ? true : false, intrate);
+      mLoopersGen->SetAdjust(loopersParam.adjust_flatgas);
     } else {
       // Otherwise, Poisson+Gauss sampling or fixed number of loopers per event will be used
       // Multiplier is applied only with distribution sampling

Generators/src/TPCLoopers.cxx

@@ -141,7 +141,7 @@ GenTPCLoopers::GenTPCLoopers(std::string model_pairs, std::string model_compton,
     scaler_file[0].close();
     scaler_file[1].close();
     // Checking if the poisson file exists and it's not empty
-    if (poisson != "")
+    if (poisson != "" && poisson != "None" && poisson != "none")
     {
         std::ifstream poisson_file(poisson);
         if (!poisson_file.is_open() || poisson_file.peek() == std::ifstream::traits_type::eof())
@@ -157,7 +157,7 @@ GenTPCLoopers::GenTPCLoopers(std::string model_pairs, std::string model_compton,
         }
     }
     // Checking if the gauss file exists and it's not empty
-    if (gauss != "")
+    if (gauss != "" && gauss != "None" && gauss != "none")
     {
         std::ifstream gauss_file(gauss);
         if (!gauss_file.is_open() || gauss_file.peek() == std::ifstream::traits_type::eof())
@@ -205,9 +205,11 @@ Bool_t GenTPCLoopers::generateEvent()
     // Set number of loopers if poissonian params are available
     if (mPoissonSet) {
       mNLoopersPairs = static_cast<unsigned int>(std::round(mMultiplier[0] * PoissonPairs()));
+      LOG(debug) << "Generated loopers pairs (Poisson): " << mNLoopersPairs;
     }
     if (mGaussSet) {
       mNLoopersCompton = static_cast<unsigned int>(std::round(mMultiplier[1] * GaussianElectrons()));
+      LOG(debug) << "Generated compton electrons (Gauss): " << mNLoopersCompton;
     }
     // Generate pairs
     for (int i = 0; i < mNLoopersPairs; ++i) {