Skip to content

Commit b0e6623

Browse files
committed
Fix angular variations in derivatives calculations.
1 parent 032b9eb commit b0e6623

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Detectors/Align/src/AlignableSensor.cxx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ void AlignableSensor::dPosTraDParGeomLOC(const AlignmentPoint* pnt, double* deri
4747
// Jacobian of position in sensor tracking frame (tra) vs sensor LOCAL frame
4848
// parameters in TGeoHMatrix convention.
4949
// Result is stored in array deriv as linearized matrix 6x3
50-
const double kDelta[kNDOFGeom] = {0.1, 0.1, 0.1, 0.5, 0.5, 0.5};
50+
const double kDelta[kNDOFGeom] = {0.1, 0.1, 0.1, 0.5 * DegToRad(), 0.5 * DegToRad(), 0.5 * DegToRad()}; // changed angles to radians
5151
double delta[kNDOFGeom], pos0[3], pos1[3], pos2[3], pos3[3];
5252
TGeoHMatrix matMod;
5353
//
@@ -94,7 +94,7 @@ void AlignableSensor::dPosTraDParGeomLOC(const AlignmentPoint* pnt, double* deri
9494
// Jacobian of position in sensor tracking frame (tra) vs parent volume LOCAL frame parameters.
9595
// NO check of parentship is done!
9696
// Result is stored in array deriv as linearized matrix 6x3
97-
const double kDelta[kNDOFGeom] = {0.1, 0.1, 0.1, 0.5, 0.5, 0.5};
97+
const double kDelta[kNDOFGeom] = {0.1, 0.1, 0.1, 0.5 * DegToRad(), 0.5 * DegToRad(), 0.5 * DegToRad()}; // changed angles to radians
9898
double delta[kNDOFGeom], pos0[3], pos1[3], pos2[3], pos3[3];
9999
TGeoHMatrix matMod;
100100
// this is the matrix for transition from sensor to parent volume local frames: LOC=matRel*loc
@@ -193,7 +193,7 @@ void AlignableSensor::dPosTraDParGeomTRA(const AlignmentPoint* pnt, double* deri
193193
// tra' = tau*tra
194194
//
195195
// Result is stored in array deriv as linearized matrix 6x3
196-
const double kDelta[kNDOFGeom] = {0.1, 0.1, 0.1, 0.5, 0.5, 0.5};
196+
const double kDelta[kNDOFGeom] = {0.1, 0.1, 0.1, 0.5 * DegToRad(), 0.5 * DegToRad(), 0.5 * DegToRad()}; // changed angles to radians
197197
double delta[kNDOFGeom], pos0[3], pos1[3], pos2[3], pos3[3];
198198
TGeoHMatrix matMod;
199199
//

0 commit comments

Comments
 (0)